Re: [compress] Added in-memory support for zip and 7z

2016-11-01 Thread M N
ook, agree or disagree, thanks. Cheers, Maciej From: Stefan Bodewig Sent: Saturday, October 22, 2016 4:46:34 PM To: dev@commons.apache.org Subject: Re: [compress] Added in-memory support for zip and 7z Hi Maciej patch applied. On 2016-10-22, M N wrote: > Going

Re: [compress] Added in-memory support for zip and 7z

2016-10-22 Thread M N
... and patch is attached to Jira COMPRESS-327 From: M N Sent: Saturday, October 22, 2016 2:04:53 PM To: dev@commons.apache.org Subject: Re: [compress] Added in-memory support for zip and 7z All, OK, volatile won't hurt anyway. Going back to the fix -

Re: [compress] Added in-memory support for zip and 7z

2016-10-22 Thread M N
All, OK, volatile won't hurt anyway. Going back to the fix - first I've done the homework and read the contract of SeekableByteChannel.position(long) method. It influences read() and write() operation. Citation of the most important part: "Setting the position to a value that is greater t

Re: [compress] Added in-memory support for zip and 7z

2016-10-20 Thread M N
Hi Stefan, I have created tests for SeekableInMemoryByteChannel and spot small error. Attached is a patch with tests and proposed fix. Regarding thread safety I think would be more clear to remove volatile and document a class as not thread safe. I think the need for thread safe SeekableInMe