at 23:44, Gary Gregory wrote:
> On Tue, Jul 18, 2017 at 11:27 AM, Jonathan Bluett-Duncan <
> jbluettdun...@gmail.com> wrote:
>
> > I would strongly discourage subclassing `Properties` and instead I'd
> > encourage composing it into the proposed `SortedProperties` cla
I would strongly discourage subclassing `Properties` and instead I'd
encourage composing it into the proposed `SortedProperties` class, as
subclassing classes which weren't designed for inheritance is risky
according to Effective Java 2nd Edition, Items 16 and 17.
So for example:
```
public final
Javen,
Just for clarity, by persistent collections, are you talking about
_functional_ persistent collections (a la Scala, Clojure and Haskell),
_disk_-persisted collections, or some other definition of "persistent"?
Jonathan
On 18 Jul 2017 08:41, "Javen O'Neal" wrote:
+1 for Lang.
There aren
or it.
>
>
> Agreed.
>
> Gary
>
>
> On 9 July 2017 at 20:19, Jonathan Bluett-Duncan
> wrote:
>
> > Okay, thanks for the clarification Gary.
> >
> > Does this mean, by extension, that there's no need to create a new JIRA
> > issue? In other words, w
d if the only thing we are talking about
> are clean-up style refactoring.
>
> Gary
>
> On Sun, Jul 9, 2017 at 2:27 PM, Jonathan Bluett-Duncan <
> jbluettdun...@gmail.com> wrote:
>
> > I've re-read the contribution guidelines
> > <https://github.com/
I've re-read the contribution guidelines
<https://github.com/apache/commons-lang/blob/master/CONTRIBUTING.md>, but
it's not clear to me if my changes are non-trivial enough to warrant a new
JIRA issue.
Can someone advise me on this?
Jonathan
On 6 July 2017 at 00:51, Jonath
e.
>
> On 5 July 2017 at 17:24, Jonathan Bluett-Duncan
> wrote:
>
> > Great! Sounds like there's general agreement on me pursuing at least some
> > of these refactorings, right?
> >
> > On the subject of code style guidelines, AFAIK [lang] uses Checkstyle to
>
bly with a comment in the
> > code explaining why).
> >
> >
> > On Wed, Jul 5, 2017 at 6:42 PM, Matt Sicker wrote:
> >
> > > I like the idea myself at least, though I'm not sure if it conflicts
> with
> > > any coding styleguides establishe
Hi all,
I'm interested in going through commons-lang with IntelliJ IDEA and
applying small refactorings to make the code base easier to read and/or
more performant (and also make IntelliJ IDEA itself report less warnings).
Is this something that the [lang] team would find useful?
Examples of ref
