Hi Benedikt,
see inline (with my vote at the bottom):
On May 3, 2015, at 5:18 PM, Benedikt Ritter wrote:
> Hi,
>
> We have fixed quite a few bugs and added some significant enhancements
> since CLI 1.2 was released and the Groovy Project is asking for a new
> release, so I would like to releas
On May 3, 2015, at 12:54 PM, Benedikt Ritter wrote:
> Sounds good to me. Go for it!
I have attached a patch for one (but will resolve two) of the issues in the
list:
https://issues.apache.org/jira/browse/CLI-179
I am not sure if it is the right direction but this is what I could do today,
so
de.
>
> br,
> Benedikt
>
> [1]
> https://issues.apache.org/jira/browse/CLI-179?jql=project%20%3D%20CLI%20AND%20fixVersion%20%3D%201.3%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>
> [2] http://markmail.org/message/yl
Hi guys,
any news on this? If there are pending tickets that are blocking the release I
could try to help to resolve them.
Thanks,
Jacopo
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-m
On Oct 6, 2014, at 2:31 AM, sebb wrote:
>> The only way to do it is to make
>> lastReturnTime field thread-safe using locks.
>
> Volatile does make the field thread-safe.
> It's just a question of whether the JVM can re-order the statements
> when volatile is used.
I think Xavier's comments ar
On Oct 2, 2014, at 7:24 PM, Mark Thomas wrote:
>> 2) removed an if block that was unnecessary
I have also create a ticket for this and another code cleanup:
https://issues.apache.org/jira/browse/POOL-280
Regards,
Jacopo
-
T
On Oct 2, 2014, at 7:24 PM, Mark Thomas wrote:
> On 02/10/2014 18:00, Jacopo Cappellato wrote:
>> Thank you Phil and Gary for the responses.
>>
>> Phil, the approach you described makes sense to me and I agree: even if part
>> of the fields of DefaultPooledObject a
On Oct 2, 2014, at 7:24 PM, Mark Thomas wrote:
>> @@ -311,12 +310,8 @@
>> // Override getMessage to avoid creating objects and formatting
>> // dates unless the log message will actually be used.
>> @Override
>> -public String getMessage() {
>> -String
PM, Phil Steitz wrote:
> On 9/27/14 10:16 AM, Jacopo Cappellato wrote:
>> On Sep 27, 2014, at 6:46 PM, Gary Gregory wrote:
>>
>>> It is not enough to set them volatile because the class has some invariants
>>> that include more than one field.
>> Fo
On Sep 27, 2014, at 6:46 PM, Gary Gregory wrote:
> It is not enough to set them volatile because the class has some invariants
> that include more than one field.
For example, under unlucky thread concurrency the method getIdleTimeMillis()
could return a negative value.
Jacopo
---
yes, sure. Should I create a new ticket?
Jacopo
On Sep 27, 2014, at 6:46 PM, Gary Gregory wrote:
> Hi and thanks for chiming in.
>
> The best path is to use Jira so we can all look and discuss.
>
> Gary
>
> Original message ----
> From: Jacopo Cappell
Hi Gary, all,
I am sorry if I jump in in this conversation: I am a committer of another ASF
project (I am actually the PMC chairman for Apache OFBiz) and my project is
using dbcp2/pool2, so thank you for all the work you did and are doing.
I am reviewing the code in DefaultPooledObject and Gary
+1
On Mar 6, 2012, at 6:42 PM, Emmanuel Bourg wrote:
> Commons CSV is approaching a releasable state. Considering the general
> interest in this component I think it's time to promote it to Commons proper.
>
> There are a few points I'd like to address before a release:
> - Handle CSV headers,
Thank you Jörg.
Jacopo
On Feb 1, 2011, at 5:49 PM, Jörg Schaible wrote:
> Hi Jacopo,
>
> Jacopo Cappellato wrote:
>
>>
>> On Jan 31, 2011, at 12:12 PM, Jörg Schaible wrote:
>>
>>> Hi Jacopo,
>>>
>>> Jacopo Cappellato wrote:
,
>
> Gary Gregory
> Senior Software Engineer
> Rocket Software
> 3340 Peachtree Road, Suite 820 . Atlanta, GA 30326 . USA
> Tel: +1.404.760.1560
> Email: ggreg...@seagullsoftware.com
> Web: seagull.rocketsoftware.com
>
>
>
>> -Original Message-
>>
On Jan 31, 2011, at 12:12 PM, Jörg Schaible wrote:
> Hi Jacopo,
>
> Jacopo Cappellato wrote:
>
>> I would like to fix some of the code formatting inconsistencies in the
>> classes commons-csv, starting with indentation: most of the classes use
>> the 4-blanks unit
I would like to fix some of the code formatting inconsistencies in the classes
commons-csv, starting with indentation:
most of the classes use the 4-blanks unit for indentation but CSVParser,
CSVPrinter and ExtendedBufferedReader use a 2-blanks unit; there are also some
inconsistencies within th
On Jan 30, 2011, at 10:17 PM, Niall Pemberton wrote:
> On Fri, Jan 28, 2011 at 4:13 PM, Jacopo Cappellato
> wrote:
>> Hi all,
>>
>> I am a committer of the Apache OFBiz project and I am using commons-csv for
>> a project at work.
>> I am wondering if there
Thanks Jörg!
Jacopo
On Jan 30, 2011, at 4:54 PM, Jörg Schaible wrote:
> Hi Jacopo,
>
> Jacopo Cappellato wrote:
>
>> Thank you Jörg.
>>
>> At this point I would be happy to get karma for the sandbox (my account is
>> jacopoc): of course I will be very
deally,
> a selector would be passed to a factory method:
>
> CSVStrategy strategy = CSVStrategy.getInstance(CSVStrategy.DEFAULT_STRATEGY);
>
>
> -Adrian
>
>
> On 1/29/2011 8:51 PM, Jacopo Cappellato wrote:
>> Hi Gary,
>>
>> I initially proposed
t; WDYT? HTH, that's just my opinion,
>> Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://www.99soft.org/
>>
>>
>>
>> On Sat, Jan 29, 2011 at 2:33 PM, Jacopo Cappellato
>> wrote:
>>> Thank you Stephen,
>>>
&g
g Spring via bean methods
> rather than the constructor.
>
> These days, immutability and concurrency are more important, so this
> change may be applicable, buts its good to understand the history and
> wide use cases of classes like these.
>
> Stephen
>
>
> O
Thank you Jörg.
At this point I would be happy to get karma for the sandbox (my account is
jacopoc): of course I will be very careful about my commits and I will discuss
any ideas here before.
Kind regards,
Jacopo
On Jan 29, 2011, at 1:37 PM, Jörg Schaible wrote:
> Hi Jacopo,
>
&g
Hi all,
in my opinion all the setter methods should be removed from the CSVStrategy
class: in this way the fields will only be set using the constructors and they
will become readonly.
The main issue I see with the current implementation is that a calling method
can modify the values of the fie
tripodi/
> http://www.99soft.org/
>
>
>
> On Fri, Jan 28, 2011 at 6:54 PM, Jacopo Cappellato
> wrote:
>> Hi Gary,
>>
>> first of all, thanks for the quick response; please see my comments inline:
>>
>> On Jan 28, 2011, at 5:23 PM, Gary Gregory wrote:
com
> Web: seagull.rocketsoftware.com
>
>
>
>> -Original Message-
>> From: Jacopo Cappellato [mailto:jacopo.cappell...@gmail.com]
>> Sent: Friday, January 28, 2011 11:14
>> To: dev@commons.apache.org
>> Subject: [csv] Fixes for commons-csv
>>
Hi all,
I am a committer of the Apache OFBiz project and I am using commons-csv for a
project at work.
I am wondering if there are plans to maintain the common-csv package; if I will
submit some patches and small enhancements will they be considered?
If there is interest around this, I may also
27 matches
Mail list logo
