Re: [collections] Next Steps after 4.1 release

2015-12-01 Thread Dipanjan Laha
Hi Thomas, I would be happy to help out here. Sorry for completely disappearing after my initial stint. Unavoidable personal reasons, but now I should be able to find enough time to dive back in. Btw, just checked out the release today and it looks really good :) Cheers Dipanjan On Wednesday, 2

Re: New to open source . want to learn to contribute.

2014-12-06 Thread Dipanjan Laha
Hello, Maven will be enough for collections. It will also be good to download maven seperately so that you can run it from console. Happy coding :) Dipanjan On Saturday, 6 December 2014, Jan Matèrne (jhm) wrote: > Ant is one of many buildtools. > Each individual project decides which buildtool

Re: [discuss] Vote to git it?

2014-09-10 Thread Dipanjan Laha
+1 for moving to git, and using Atlassian's stash and crucible. Git branching is very different than subversion, and any feature or issue can have it's own branch and merged into master through a pull request. We can also have rules on code reviews before a branch is merged onto master or say rules

Re: [CSV] Naming pattern of getters and setters in CSVFormat (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

2014-07-19 Thread Dipanjan Laha
Although i am not familiar with CSV's codebase, imho "get" is more straight forward, so +1 to Gary's suggestion. On Saturday, 19 July 2014, Gary Gregory wrote: > On Sat, Jul 19, 2014 at 12:14 PM, Emmanuel Bourg > wrote: > > > Le 19/07/2014 13:48, Gary Gregory a écrit : > > > > > Can we go back

Re: commons-collections - Build # 285 - Failure

2014-07-13 Thread Dipanjan Laha
Thank you so much Thomas. Regards Dipanjan On Sunday, 13 July 2014, Thomas Neidhart wrote: > On 07/13/2014 04:29 PM, Dipanjan Laha wrote: > > Hello, > > > > I checked in some code yesterday in commons collection. This triggered a > > build which failed. The l

Fwd: commons-collections - Build # 285 - Failure

2014-07-13 Thread Dipanjan Laha
Hello, I checked in some code yesterday in commons collection. This triggered a build which failed. The log around the failure reads [commons-collections] $ /home/hudson/tools/java/latest1.5/bin/java -cp /home/jenkins/jenkins-slave/maven3-agent.jar:/home/jenkins/jenkins-slave/tools/hudson.tasks.M

Re: Please welcome our newest Commons committer Dipanjan Laha

2014-07-01 Thread Dipanjan Laha
On Wed, Jul 2, 2014 at 11:56 AM, Thomas Neidhart wrote: > On 07/02/2014 04:30 AM, Dipanjan Laha wrote: > > On Wednesday, 2 July 2014, Bernd Eckenfels > wrote: > > > >> Am Sat, 28 Jun 2014 22:00:34 -0400 > >> schrieb Gary Gregory >: > >>> *We

Re: Please welcome our newest Commons committer Dipanjan Laha

2014-07-01 Thread Dipanjan Laha
On Wednesday, 2 July 2014, Bernd Eckenfels wrote: > Am Sat, 28 Jun 2014 22:00:34 -0400 > schrieb Gary Gregory >: > > *Welcome* aboard Dipanjan! > > Welcome Diphanjan :) Whats your fav. components in Apache Commons? Thank you, It would be collections for now, but looking forward to getting invol

Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src: changes/ main/java/org/apache/commons/collections4/

2014-05-01 Thread Dipanjan Laha
-1 Imho this usecase also gives a false impression of over riding, so maybe we should make the util classes final as Gary suggested. And imo switching to Guava would be much more of an effort than to compose ones own util class :) On Thursday, 1 May 2014, Jörg Schaible > wrote: > sebb wrote: > >

Re: Bugs in Apache commons collections, version 4.0

2014-04-12 Thread Dipanjan Laha
On Sat, Apr 12, 2014 at 3:18 PM, Thomas Neidhart wrote: > On 04/12/2014 08:41 AM, Dipanjan Laha wrote: > > On Sat, Apr 12, 2014 at 1:04 AM, Thomas Neidhart > > wrote: > > > >> On 04/11/2014 05:52 AM, Dipanjan Laha wrote: > >>> Hi, > >>>

Re: Bugs in Apache commons collections, version 4.0

2014-04-11 Thread Dipanjan Laha
On Sat, Apr 12, 2014 at 1:04 AM, Thomas Neidhart wrote: > On 04/11/2014 05:52 AM, Dipanjan Laha wrote: > > Hi, > > > > The only issue here is then Collection's equals implementation would need > > to check individually whether the Collection also implements

Re: Bugs in Apache commons collections, version 4.0

2014-04-10 Thread Dipanjan Laha
; That's why Collection.equals(List) must return false, as well as > Collection.equals(Set), while Collection.equals(Collection) may return > true if it contains the same values. > > My 2 cents, > Regards, > Julien > > 2014-04-10 11:27 GMT+04:00 Dipanjan Laha : > &

Re: Bugs in Apache commons collections, version 4.0

2014-04-10 Thread Dipanjan Laha
Hello, I checked the equals symmetry mismatch issue in https://issues.apache.org/jira/browse/COLLECTIONS-512. I haven't checked the hascode mismatch or any other issue yet. The test in BugReport1_1.java initializes AbstractIterableGetMapDecorator which is meant to be abstract but is not. So imho

Re: [collections] MultiValuedMap interface discussion

2014-03-28 Thread Dipanjan Laha
Thanks Ted for pointing to this. I checked out the guavas Multimap and if I understand correctly, they are returning a wrapped Collection with an internal reference to the Multimap. The basic behavior is - When add is triggered on the collection, they create the mapping in their Multimap if it is

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-03-02 Thread Dipanjan Laha
raise a JIRA issue > and attach there. > > Matt > > > On Sun, Mar 2, 2014 at 10:46 AM, Dipanjan Laha > wrote: > > > Hi Thomas, > > > > I have implemented the MultiValuedMap interface, the MultiValuedHashMap > > and a MultiValuedHashMapTest as per th

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-03-02 Thread Dipanjan Laha
e in some other way. Regards Dipanjan On Wed, Feb 26, 2014 at 8:04 PM, Dipanjan Laha wrote: > Thanks for pointing this out. However, implementing Get & Put directly > would pose the following problems. > > If interface MultiValuedMap extends Get> > > the method

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-26 Thread Dipanjan Laha
terfaces and provide that amount of > abstraction anyway. > > Matt > On Feb 26, 2014 3:26 AM, "Dipanjan Laha" wrote: > > > Hi Thomas, > > > > This sounds great. Moving MultiKeyMap to the new package does sound like > > the way to go ahead. I will st

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-26 Thread Dipanjan Laha
For the package, I think we can stick with multimap, and at some point we > could also move the MultiKeyMap there, which would be logical imho. > > The implementation names are also sound. > > Thomas > > > > > On Wed, Feb 26, 2014 at 9:28 AM, Dipanjan Laha > wrot

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-26 Thread Dipanjan Laha
ow of your thoughts on these. Regards Dipanjan On Sun, Feb 23, 2014 at 8:36 PM, Dipanjan Laha wrote: > Hi Thomas, > > Thanks for your feedback. I created an improvement request in Jira for the > same (https://issues.apache.org/jira/browse/COLLECTIONS-508 ) as I > thought it cou

Re: [collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-23 Thread Dipanjan Laha
gards Dipanjan On Sun, Feb 23, 2014 at 6:09 PM, Thomas Neidhart wrote: > On 02/22/2014 02:00 PM, Dipanjan Laha wrote: > > Hello, > > Hi Dipanjan, > > > Recently I had the need of using a MultiMap in one of my projects. I > found > > that commons collection a

[collections] Issues with MultiMap generics and need of a MultiTrie

2014-02-22 Thread Dipanjan Laha
Hello, Recently I had the need of using a MultiMap in one of my projects. I found that commons collection already has a MultiMap interface and an implementation. While using the same, I found that the MultiMap interface has methods that are not strongly typed even though the interface supports g