Re: [codec] RuntimeException DigestUtils.getDigest(String)

2012-09-01 Thread Christian Hammers
Linking the exceptions is a good idea as it preserves the original stack trace. What could cause this Exception is hard to guess but a wrong paramter string is more likely than a broken Java installation thus IllegalArgument probably fits better. bye, -christian- Am Sat, 1 Sep 2012 11:27:51 -04

Re: commons-codec pull request: More tests

2012-08-31 Thread Christian Hammers
equest: > > > >https://github.com/apache/commons-codec/pull/1 > > > >More tests > > > >Please apply the following commits: > > > >$ git log --name-status aead18a..71bdb57 > >commit 71bdb5725169e4dba533ab50a3afab4b4fedb788

Re: [codec] javadoc style

2012-08-30 Thread Christian Hammers
Am Thu, 30 Aug 2012 18:05:50 -0400 schrieb Gary Gregory : > On Aug 30, 2012, at 17:58, Christian Hammers wrote: > > > Am Thu, 30 Aug 2012 16:21:43 -0400 > > schrieb Gary Gregory : > > > >> On Thu, Aug 30, 2012 at 2:57 PM, Thomas Neidhart > >> wrote:

Re: [codec] MD5 impls

2012-08-30 Thread Christian Hammers
Am Thu, 30 Aug 2012 19:58:54 +0200 schrieb Thomas Neidhart : > On 08/30/2012 06:31 PM, Gary Gregory wrote: > > On Thu, Aug 30, 2012 at 11:53 AM, sebb wrote: > > > >> On 30 August 2012 16:51, Gary Gregory > >> wrote: > >>> On Thu, Aug 30, 2012 at 11:41 AM, sebb wrote: > >>> > On 30 August

Re: [codec] javadoc style

2012-08-30 Thread Christian Hammers
Am Thu, 30 Aug 2012 16:21:43 -0400 schrieb Gary Gregory : > On Thu, Aug 30, 2012 at 2:57 PM, Thomas Neidhart > wrote: > > > Hi, > > > > there are quite some differences on the javadoc style in the source > > files, e.g. the number of spaces before a @param description, > > whether there is an emp

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-29 Thread Christian Hammers
uot;vacuous" code) > > Also to do is fix the remaining check styles. > > Patches welcome! > > Gary > > On Tue, Aug 28, 2012 at 2:47 AM, Thomas Neidhart > wrote: > > > On 08/28/2012 03:33 AM, Christian Hammers wrote: > > > Am Tue, 28 Aug 2012 00:09:41

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-27 Thread Christian Hammers
Am Tue, 28 Aug 2012 00:09:41 +0200 schrieb Christian Hammers : > Hello > > Am Mon, 27 Aug 2012 16:39:23 -0400 > schrieb Gary Gregory : > > > On Mon, Aug 27, 2012 at 2:53 PM, Thomas Neidhart > > wrote: > > > > > On 08/27/2012 03

Re: [codec] Vacuous bit mask operation on integer value in UnixCrypt

2012-08-27 Thread Christian Hammers
Hello Am Mon, 27 Aug 2012 16:39:23 -0400 schrieb Gary Gregory : > On Mon, Aug 27, 2012 at 2:53 PM, Thomas Neidhart > wrote: > > > On 08/27/2012 03:36 PM, Gary Gregory wrote: > > > Hi All: > > > > > > FindBugs says the following a couple of times for UnixCrypt: > > > "Vacuous bit mask operation o

Re: [Codec] Next Commons-Codec release?

2012-08-27 Thread Christian Hammers
Am Mon, 27 Aug 2012 08:59:52 -0400 schrieb Gary Gregory : > On Sat, Aug 25, 2012 at 7:09 PM, Christian Hammers > wrote: > > > Hello > > > > Am Fri, 24 Aug 2012 09:28:55 -0400 > > schrieb Gary Gregory : > > > > > On Thu, Aug 23, 2012 at 4:05 PM,

Re: [Codec] Next Commons-Codec release?

2012-08-25 Thread Christian Hammers
Hello Am Fri, 24 Aug 2012 09:28:55 -0400 schrieb Gary Gregory : > On Thu, Aug 23, 2012 at 4:05 PM, Thomas Neidhart > wrote: > > > On 08/22/2012 01:23 PM, Gary Gregory wrote: > > > > > I did the SVN update from E and the build from a Win7 command > > > line. > > > > Does it still not work for you