[CSV] [CSV-270]: Introduce parsing exception for Parser issues in CSV

2023-09-11 Thread Buddhi De Silva
tps://github.com/apache/commons-csv/compare/master...gbidsilva:commons-csv-osc:CSV-270 Appreciate your feedback on this. Thank you. Buddhi De Silva.

Re: Misleading error message when QuoteMode set to None

2023-09-06 Thread Buddhi De Silva
Apologies for missing the component name on the Subject line. This is for the [CSV] component. On Thu, 7 Sept 2023 at 09:26, Buddhi De Silva wrote: > Hello Commons-Devs, > > Related Jira issue: https://issues.apache.org/jira/browse/CSV-310 > > Scenario: > When we try to print

Misleading error message when QuoteMode set to None

2023-09-06 Thread Buddhi De Silva
message which we are getting is sort of misleading. It implies that the code has not set any quote mode even though we set it. Simple and more meaningful exception message could be: *Quote mode set to NONE but no escape character is set.* Please see the PR created on this: https://github.com/apache/commons-csv/pull/352 Thank you. Buddhi De SIlva.

Re: [CSV] Odd behavior when using 'QuoteMode.MINIMAL' with empty columns

2023-09-05 Thread Buddhi De Silva
utput "looks odd" because you've asked > for the MINIMAL format. > > If you change the code to produce larger output, then it is no longer > minimal. > > Gary > > On Mon, Sep 4, 2023 at 10:38 AM Buddhi De Silva > wrote: > > > > Hello Commons-De

[CSV] Odd behavior when using 'QuoteMode.MINIMAL' with empty columns

2023-09-04 Thread Buddhi De Silva
tual refactoring): https://github.com/apache/commons-csv/pull/351 If we apply changes as suggested in above PR, then we might be able to produce more accurate output which will not print empty quotes for empty first column. Appreciate your feedback on this. Thank You. Buddhi De Silva.

[CSV-147] - Include parsed content in exception message up to the error point

2023-08-30 Thread Buddhi De Silva
/apache/commons-csv/pull/347 Your effort in carrying this forward is appreciated. Thank you. Buddhi De Silva

[CSV] Remove duplicate exception class name from message

2023-08-30 Thread Buddhi De Silva
n to the throw clause as follows to make this more meaningful. "throw new UncheckedIOException("Error in reading next record: " + e.toString(), e);" GitHub PR Link: https://github.com/apache/commons-csv/pull/348 Jira issue: https://issues.apache.org/jira/browse/CSV-309 Appreciate your help in this! Thank You. Buddhi De Silva.

Re: [CSV] - Contribution Support

2023-08-24 Thread Buddhi De Silva
Java > > 8 is EOL anyway. > > > > Gary > > > > On Thu, Aug 24, 2023, 6:34 AM Elliotte Rusty Harold > > wrote: > > > > > On Thu, Aug 24, 2023 at 8:28 AM Buddhi De Silva > > > wrote: > > > > > > > > HI Team, > >

[CSV] - Contribution Support

2023-08-24 Thread Buddhi De Silva
and unresolved. In this case, before I dig into some issues for possible fixes, I would like to know whether all open issues in the CSV Jira board are still valid and planned to be integrated in the upcoming releases if we have possible PRs. Appreciate your help on this. - Buddhi De Silva.

[CSV] Possible JavaDoc optimization

2023-08-21 Thread Buddhi De Silva
Hi Team. I am new to the Apache mailing list and I would like to contribute. I was trying some samples with Apache CSV library and I have one JavaDoc. optimization suggestion. Scenario: If we want to set a header comment in the CSV when writing a new CSV content, we can achieve it by doing the f