Re: [VOTE] Release commons-io 2.5 based on RC1

2015-11-25 Thread Adrian Crum
I had the same maven errors while working on IO-487, but I assumed it was because my local copy was not set up correctly. The TailerTest fails intermittently with or without Cobertura. Adrian Crum Sandglass Software www.sandglass-software.com On 11/24/2015 5:36 PM, Gary Gregory wrote: Just

Re: [VOTE] Release Validator 1.5.0 based on RC1

2015-11-19 Thread Adrian Crum
ant build completely? I have the same problem with a number of Commons projects. I prefer to use ant (since Commons poms are huge black boxes), but the ant builds aren't kept current. I agree the ant build files should be dropped if no one is willing to maintain them. Adrian Crum Sand

Re: [validator] Inconsistent behavior in UrlValidator

2015-09-27 Thread Adrian Crum
The address range 127.0.0.0 to 127.255.255.255 is reserved for loopback testing. It seems pretty straightforward to me. Adrian Crum Sandglass Software www.sandglass-software.com On 9/27/2015 8:07 AM, Kristian Rosenvold wrote: 127.0.0.1 is not always the address for localhost. This is a can of

[validator] Inconsistent behavior in UrlValidator

2015-09-25 Thread Adrian Crum
to me that it shouldn't - to be consistent with the localhost behavior. What do you think? -- Adrian Crum Sandglass Software www.sandglass-software.com - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For addit

Re: need some help

2015-09-02 Thread Adrian Crum
or Commons-Convert. Adrian Crum Sandglass Software www.sandglass-software.com On 9/2/2015 12:53 PM, Gary Gregory wrote: You can also look at incubating projects like Commons-RDF. Gary On Wed, Sep 2, 2015 at 12:39 PM, Arsen Babakhanyan wrote: My problem that i am currently trying to figure

Re: [dbutils] Adding fluent api

2015-07-01 Thread Adrian Crum
You can make the builder support generic SQL 2003, and provide a way to extend the builder with vendor-specific grammar. Adrian Crum Sandglass Software www.sandglass-software.com On 6/30/2015 11:10 PM, Benedikt Ritter wrote: Hello Mansour, 2015-06-30 23:57 GMT+02:00 Mansour Al Akeel : I am

Re: [Git] drop SVN repos for components using Git?

2015-05-08 Thread Adrian Crum
Do the Git repos include the Subversion commit history? Adrian Crum Sandglass Software www.sandglass-software.com On 5/8/2015 8:53 AM, sebb wrote: Is there any point in keeping the SVN repos for components that have moved to Git? They are read-only (or should be) and are not synchronised with

Re: org.apache.commons.lang3.SystemUtils.IS_OS_WINDOWS_8_1

2015-04-25 Thread Adrian Crum
I can do that. Adrian Crum Sandglass Software www.sandglass-software.com On 4/25/2015 9:56 AM, Gary Gregory wrote: Is there anyone with a Windows 8.1 system available to implement and test a new method org.apache.commons.lang3.SystemUtils.IS_OS_WINDOWS_8_1? Thank you, Gary

Re: [collections] Revert a performance related fix in 4.1

2015-01-24 Thread Adrian Crum
uced the code by one line, but there was no "performance improvement" - because the StringBuilder constructor calls append(). So, I agree that suggested performance improvements should be met with a great deal of skepticism and they should be closely scrutinized. Adrian Crum Sandg

Re: [ALL] staging and production website commit mails now got to notifications@

2015-01-19 Thread Adrian Crum
Thanks! Adrian Crum Sandglass Software www.sandglass-software.com On 1/19/2015 12:46 PM, sebb wrote: It looks as though the notifications@commons.a.o mailing list is finally being used for: buildbot commits website publication This should reduce the noise on the commits@ mailing list

Re: Commons Dev List Activity Levels

2015-01-06 Thread Adrian Crum
You can set up your email client to filter out messages you are not interested in. Adrian Crum Sandglass Software www.sandglass-software.com On 1/6/2015 3:37 PM, Christopher wrote: Hi, With the recent announcement about commits to commons being opened up, I joined the dev@commons.apache.org

Re: svn commit: r1649038 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java

2015-01-02 Thread Adrian Crum
Thank you for fixing that. I had my IDE set for Java 1.4 but somehow it let me use that method anyway. Adrian Crum Sandglass Software www.sandglass-software.com On 1/2/2015 6:17 AM, s...@apache.org wrote: Author: sebb Date: Fri Jan 2 14:17:48 2015 New Revision: 1649038 URL: http

Re: svn commit: r1648642 - /commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java

2014-12-30 Thread Adrian Crum
Be aware that the file contains encoded Chinese TLDs (XN--*). So, it needs additional parsing. Adrian Crum Sandglass Software www.sandglass-software.com On 12/30/2014 5:23 PM, s...@apache.org wrote: Author: sebb Date: Wed Dec 31 01:23:26 2014 New Revision: 1648642 URL: http://svn.apache.org

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC1

2014-12-26 Thread Adrian Crum
It would be nice if the maintenance release included this fix: https://issues.apache.org/jira/browse/VALIDATOR-307 I was planning on working on it this weekend. Adrian Crum Sandglass Software www.sandglass-software.com On 12/26/2014 3:00 PM, Benedikt Ritter wrote: Hello, We have received

Re: [ANNOUNCEMENT] Apache Commons grants write access to all ASF committers

2014-12-17 Thread Adrian Crum
The challenge will be to keep Jira up-to-date. I would like to wrap up some Jira issues too, but ASF committers do not have edit permissions in Commons Jira. Adrian Crum Sandglass Software www.sandglass-software.com On 12/18/2014 2:42 AM, Carl Hall wrote: Very cool! I've been di

Re: svn commit: r1635052 - in /commons/proper/csv/trunk/src: changes/ main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2014-10-29 Thread Adrian Crum
this discussion. Adrian Crum Sandglass Software www.sandglass-software.com On 10/29/2014 5:01 PM, Gary Gregory wrote: This should be something simple to use, it's just a parser for a 'simple' file format. I get a format, a parser and my data. If each new feature is a decorator

Re: svn commit: r1635052 - in /commons/proper/csv/trunk/src: changes/ main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2014-10-29 Thread Adrian Crum
perspective, that makes client code cleaner and simpler, not more complicated. But like many design discussions, that is a personal preference and others may feel differently. Adrian Crum Sandglass Software www.sandglass-software.com On 10/29/2014 4:08 PM, Gary Gregory wrote: On Wed, Oct 29, 2014 at 4

Re: svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/java/org/apache/commons/beanut

2014-10-24 Thread Adrian Crum
From my perspective, the final keywords don't add anything of value to the library. If their addition to the library makes code maintenance difficult, then it would be best to remove them. Adrian Crum Sandglass Software www.sandglass-software.com On 10/24/2014 9:01 PM, Gary Gregory wrote

Re: [CANCEL][VOTE] Release Commons CSV 1.0 based on RC1

2014-07-13 Thread Adrian Crum
I would be inclined to leave Java 5 compatibility to the few (if any) people who still use it. They have access to the CSV source code and they can modify it to make it Java 5 compatible. Adrian Crum Sandglass Software www.sandglass-software.com On 7/13/2014 10:30 AM, Benedikt Ritter wrote

Re: [CANCEL][VOTE] Release Commons CSV 1.0 based on RC1

2014-07-13 Thread Adrian Crum
Why would we target Java 5? It is long past end-of-life. Adrian Crum Sandglass Software www.sandglass-software.com On 7/13/2014 10:12 AM, Benedikt Ritter wrote: Hi all, this vote it canceled to address the various issues identified. I'll need some time to work through the list, so I e

Re: [CSV] Proposed fix for CSV-35 (Was: Fwd: [jira] [Comment Edited] (CSV-35) Escaped line separators are not supported)

2014-07-10 Thread Adrian Crum
I agree that we should stop worrying about edge cases and release a version that covers the majority of needs. Adrian Crum Sandglass Software www.sandglass-software.com On 7/10/2014 9:12 AM, Benedikt Ritter wrote: 2014-07-09 4:15 GMT+02:00 Gary Gregory : We do have a discrepancy between our

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread Adrian Crum
hread, two fail-slow designs that provide default values, and one fail-fast design that throws an exception.] So, it helps if a project can state clearly its fundamental design philosophy. Some users might disagree with it, but at least it makes code maintenance and new development easier. Adrian Cru

Re: [beanutils2] Assertions class vs. lang Validate

2014-03-03 Thread Adrian Crum
me. Adrian Crum Sandglass Software www.sandglass-software.com On 3/3/2014 12:07 AM, Benedikt Ritter wrote: Hi Adrian 2014-03-02 8:03 GMT+01:00 Adrian Crum : On 3/1/2014 9:33 AM, Benedikt Ritter wrote: I don't like the idea of creating some kind of component hierarchy, where compo

Re: [beanutils2] Assertions class vs. lang Validate

2014-03-01 Thread Adrian Crum
want it to have a multitude of silly dependencies. One of the main problems with this community is the top-down-one-size-fits-all mentality. It just makes things a lot harder than they should be from a user's/developer's perspective. Adrian Crum Sandglass Software www.sa

Re: [SITE] New design is finally online

2014-02-18 Thread Adrian Crum
The site looks great! Thanks Benedikt! Adrian Crum Sandglass Software www.sandglass-software.com On 2/18/2014 9:51 AM, Benedikt Ritter wrote: Hi all, I've just published our website. The new skin is now online. [1] Since site publication takes a long time with my internet connection,

Re: [math] Annotations

2014-02-12 Thread Adrian Crum
developer needs any more detail, they can go to the interface's JavaDocs. The annotations being proposed here are pretty basic and intuitive, so I don't see them as being some kind of hurdle a developer needs to overcome. Adrian

Re: commons-lang pull request: add isNull and isNotNull methods

2014-02-04 Thread Adrian Crum
Personally, I view this as an anti-pattern. You have a null reference in your hand, and instead of checking the reference that is in your hand, you give it to an unrelated class and have that class check to see if it is a null reference. That just doesn't make any sense to me. Adrian

Re: [csv] CSVRecord and Map

2014-01-22 Thread adrian . crum
ere are "to" methods after all. This just restricts the usability of the objects. Gary -Adrian Quoting Adrian Crum : I agree with Emmanuel. We don't want CSVRecord to devolve into a god class that tries to be everything to everybody. "Do only one thing, and do it really well&

Re: [csv] CSVRecord and Map

2014-01-22 Thread adrian . crum
o the record, there should be no expectancy of synchronizing the map with the record. There are "to" methods after all. This just restricts the usability of the objects. Gary -Adrian Quoting Adrian Crum : I agree with Emmanuel. We don't want CSVRecord to devolve into a

Re: [csv] CSVRecord and Map

2014-01-22 Thread adrian . crum
the objects are not connected to the record, there should be no expectancy of synchronizing the map with the record. There are "to" methods after all. This just restricts the usability of the objects. Gary -Adrian Quoting Adrian Crum : I agree with Emmanuel. We don't want C

Re: [csv] CSVRecord and Map

2014-01-22 Thread adrian . crum
being backed by a HashMap, then reduced that to a simplified version of Gray's implementation. I apologize for the confusion. -Adrian Quoting Adrian Crum : I agree with Emmanuel. We don't want CSVRecord to devolve into a god class that tries to be everything to everybody. "Do o

Re: [csv] CSVRecord and Map

2014-01-22 Thread Adrian Crum
ing it. https://issues.apache.org/jira/browse/CSV-104 Adrian Crum Sandglass Software www.sandglass-software.com On 1/22/2014 8:01 AM, Emmanuel Bourg wrote: Le 21/01/2014 15:08, Gary Gregory a écrit : This kind of complication is unnecessary IMO, why not just have the record implement Map? Beca

Re: [csv] CSVRecord and Map

2014-01-21 Thread Adrian Crum
keys? Is the CSVRecord-derived Map going to behave differently than any other Map in a significant way? If yes, do we really want to do that? Adrian Crum Sandglass Software www.sandglass-software.com On 1/21/2014 8:04 AM, Gary Gregory wrote: My story: There should be some kind of play between a

Re: svn commit: r1559905 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordTest.java

2014-01-21 Thread Adrian Crum
http://mail-archives.apache.org/mod_mbox/commons-dev/201401.mbox/%3C52D5C3A7.4060004%40sandglass-software.com%3E http://mail-archives.apache.org/mod_mbox/commons-dev/201401.mbox/%3C52D7C612.8040601%40sandglass-software.com%3E Adrian Crum Sandglass Software www.sandglass-software.com On 1/21

Re: svn commit: r1559905 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordTest.java

2014-01-21 Thread Adrian Crum
Btw, line #179 - potential NPE. If CSVRecord is intended to be read-only, then the toMap() method should return an unmodifiable Map. Adrian Crum Sandglass Software www.sandglass-software.com On 1/21/2014 6:44 AM, Adrian Crum wrote: I must be confused. If the goal was to give CSVRecord a Map

Re: svn commit: r1559905 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordTest.java

2014-01-21 Thread Adrian Crum
I must be confused. If the goal was to give CSVRecord a Map interface, then that would include the interface's put method. If we don't support the Map interface, then what is the point of this change? Adrian Crum Sandglass Software www.sandglass-software.com On 1/21/2014 6:36 AM

Re: svn commit: r1559905 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVRecord.java test/java/org/apache/commons/csv/CSVRecordTest.java

2014-01-21 Thread Adrian Crum
This looks really ugly. How do I update the CSVRecord using Map.put()? Is there a reason you didn't use the design I proposed? Adrian Crum Sandglass Software www.sandglass-software.com On 1/20/2014 9:12 PM, ggreg...@apache.org wrote: Author: ggregory Date: Tue Jan 21 02:12:02 201

Re: [csv] CSVRecord implements Map

2014-01-16 Thread Adrian Crum
CSVRecordMap implements Map { CSVRecordMap(CSVRecord record) { } } Use the Map implementation to access the record in a Map-like way, use the CSVRecord instance to access the record in a List-like way. Adrian Crum Sandglass Software www.sandglass-software.com On 1/16/2014 1:04 AM

Re: [csv] CSVRecord implements Map

2014-01-14 Thread Adrian Crum
That would only work if the CSV file had column names. Maybe make a class that implements Map and contains a CSVRecord - so it's optional. Adrian Crum Sandglass Software www.sandglass-software.com On 1/14/2014 5:27 PM, Gary Gregory wrote: Hi All: Any thoughts on making CSVRecord impl

Re: [help] restoring javadocs to site

2013-12-30 Thread Adrian Crum
I could never get that to work for Convert either. I just update the site manually by committing the local changes. Adrian Crum Sandglass Software www.sandglass-software.com On 12/30/2013 7:04 PM, Phil Steitz wrote: I ran with scissors and tried mvn site-deploy and it seems to have (sic

Re: [DRAFT][REPORT] Status report for the Apache Commons Project December 2013

2013-12-09 Thread Adrian Crum
Try this: http://commons.markmail.org/ Adrian Crum Sandglass Software www.sandglass-software.com On 12/9/2013 12:17 PM, Stefan Bodewig wrote: On 2013-12-09, Gary Gregory wrote: Thank you for the corrections. I do not see how to get mailing list stats out of ezmlm. <http://pulse.apache.

Re: [all] Removing websites of dormant components

2013-11-29 Thread Adrian Crum
You can remove the dormant convert. A new version is in the sandbox and I doubt anything will be done with the dormant version. Adrian Crum Sandglass Software www.sandglass-software.com On 11/29/2013 8:24 AM, Christian Grobmeier wrote: On 19.10. I wrote a mail in response to Henri Yandell

Re: [Math] Controlled and and assisted switch to "Git"

2013-11-27 Thread Adrian Crum
g git instead of svn will become "easy" is by doing it - like anything else. Adrian Crum Sandglass Software www.sandglass-software.com On 11/27/2013 7:47 AM, Gilles wrote: On Wed, 27 Nov 2013 12:44:27 +0100, Emmanuel Bourg wrote: Le 27/11/2013 12:13, Gilles a écrit : I'm only a b

Re: [all] Welcome to the new Apache Commons PMC chair: Gary Gregory

2013-11-22 Thread Adrian Crum
Congrats Gary! Adrian Crum Sandglass Software www.sandglass-software.com On 11/22/2013 9:19 AM, Luc Maisonobe wrote: Hi all, The Apache board meeting was held on wednesday. The resolution we proposed to change Apache Commons VP has been adopted, and its result can be seen here: <h

Re: [validator] EmailValidator, DomainValidator questions

2013-11-22 Thread Adrian Crum
st to have two methods: one that checks the domain format, and another that checks if the domain exists. Adrian Crum Sandglass Software www.sandglass-software.com On 11/22/2013 8:07 AM, Jaun Oliver wrote: Hi I have got some questions regarding the EmailValidator. The documentation st

Re: [math] commit screw-up

2013-10-20 Thread Adrian Crum
With Tortoise SVN it's easy. Right-click on your local copy, select Tortoise SVN -> Show Log. Right-click on your commit, select Revert changes from this revision. Commit. Adrian Crum Sandglass Software www.sandglass-software.com On 10/19/2013 11:22 PM, Phil Steitz wrote: I inadv

Re: [CHALLENGE] Move All of Commons to the Dormant

2013-10-15 Thread Adrian Crum
ove was based on something concrete and measurable. Adrian Crum Sandglass Software www.sandglass-software.com - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [CHALLENGE] Move All of Commons to the Dormant

2013-10-14 Thread Adrian Crum
Thanks! I'm a committer in the sandbox, but I haven't ventured into proper yet. I was hoping to get Commons Convert promoted to proper someday. In the meantime I would be happy to work on CSV. Adrian Crum Sandglass Software www.sandglass-software.com On 10/14/2013 9:32 PM, Phil St

Re: [CHALLENGE] Move All of Commons to the Dormant

2013-10-14 Thread Adrian Crum
I am willing to help out with CSV. ID = adrianc. Adrian Crum Sandglass Software www.sandglass-software.com On 10/14/2013 9:14 PM, Phil Steitz wrote: On 10/14/13 8:55 PM, Henri Yandell wrote: I contend that all of the Commons components are inactive and should move to the Attic/Dormant. In

Re: New committers: Ate Douma and Woonsan Ko

2013-10-14 Thread Adrian Crum
Congratulations to Ate Douma and Woonsan Ko! Adrian Crum Sandglass Software www.sandglass-software.com On 10/14/2013 10:51 AM, Luc Maisonobe wrote: Hi all, Please welcome Ate Douma and Woonsan Ko as a new committers of the Apache Commons project. The Commons PMC has voted to grant

Re: [DISCUSS] Putting several unmaintained components to dormant

2013-10-09 Thread Adrian Crum
That is a good point. Those Commons GPG commits are just Maven black box updates. Adrian Crum Sandglass Software www.sandglass-software.com On 10/9/2013 1:28 PM, Christian Grobmeier wrote: Here is some commit activity: http://svnsearch.org/svnsearch/repos/ASF/search?view=plot&from=2013

Re: [DISCUSS] Putting several unmaintained components to dormant

2013-10-09 Thread Adrian Crum
Can we include commit activity and Jira activity in the analysis? Adrian Crum Sandglass Software www.sandglass-software.com On 10/9/2013 1:04 PM, Benedikt Ritter wrote: I've looked at all the proper components and listed all components where I've seen activity since I'm subsc

Re: [DISCUSS] Putting several unmaintained components to dormant

2013-10-09 Thread Adrian Crum
What criteria are you using to come up with this list? Adrian Crum Sandglass Software www.sandglass-software.com On 10/9/2013 12:17 PM, Benedikt Ritter wrote: Hi, I think Phil came up with the idea to try to focus on the components that we are able to maintain and put all other stuff to

Re: [DISCUSS] Mission Statement for Commons...

2013-10-06 Thread Adrian Crum
I would like to know the metrics for that conclusion. I see plenty of discussions and commits, but I'm not seeing any languishing. Adrian Crum Sandglass Software www.sandglass-software.com On 10/6/2013 11:30 AM, James Carman wrote: All, The Apache Commons project seems to be languishi

Re: [csv] should CSVRecord's values() method be public?

2013-09-15 Thread Adrian Crum
I needed access to that method too, so I made that method public in my local copy. Adrian Crum Sandglass Software www.sandglass-software.com On 9/15/2013 12:05 PM, Michele Rossi wrote: hi, I am trying to use commons-csv for a simple CSV transformation tool and I have encountered a couple of

Re: [KARMA] Re: [jira] [Created] (SANDBOX-461) FloatToString

2013-09-14 Thread Adrian Crum
It works. Thanks! Adrian Crum Sandglass Software www.sandglass-software.com On 9/14/2013 12:06 PM, Luc Maisonobe wrote: Hi Adrian, Le 14/09/2013 16:37, Adrian Crum a écrit : I need someone to grant me permission to manage Jira sandbox issues. My Jira login ID is adri...@hlmksw.com Could

[KARMA] Re: [jira] [Created] (SANDBOX-461) FloatToString

2013-09-14 Thread Adrian Crum
I need someone to grant me permission to manage Jira sandbox issues. My Jira login ID is adri...@hlmksw.com Thanks! Adrian Crum Sandglass Software www.sandglass-software.com On 9/13/2013 3:48 PM, Brad Davis (JIRA) wrote: Brad Davis created SANDBOX-461

[ALL] Re: [jira] [Created] (SANDBOX-461) FloatToString

2013-09-13 Thread Adrian Crum
I need someone to grant me permission to manage Jira sandbox issues. My Jira login ID is adri...@hlmksw.com Thanks! Adrian Crum Sandglass Software www.sandglass-software.com On 9/13/2013 3:48 PM, Brad Davis (JIRA) wrote: Brad Davis created SANDBOX-461

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Configuration - Group (shared) Maven 3 Build Definition (Java 1.6)

2013-09-11 Thread Adrian Crum
In my experience, SVN update is unreliable for CI environments, so I always use a fresh checkout. Adrian Crum Sandglass Software www.sandglass-software.com On 9/11/2013 1:51 PM, sebb wrote: The group build definition is set to use SCM update rather than a clean checkout. However surely svn

Re: [spam] Re: svn commit: r1518802 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2013-08-30 Thread Adrian Crum
I've seen a lot of discussions on NPE versus IAE, and in the end they all condense down to what Matt stated here: Those who favor NPE cite the JDK classes as a pattern to follow, and those who favor IAE say it is a better description of the problem. From my perspective, both are valid viewpoint

Re: [ALL] Design question: static utility classes

2013-08-25 Thread Adrian Crum
+1 -Adrian On 8/25/2013 9:26 AM, James Carman wrote: AtomicReference? On Sunday, August 25, 2013, Phil Steitz wrote: On 8/24/13 11:33 AM, Oliver Heger wrote: Hi all, regarding a principle design question I would like to get your opinion: In [configuration] there are a few static utility c

Re: [CSV] Creating CSVParser instances

2013-08-14 Thread Adrian Crum
On 8/14/2013 1:10 PM, Emmanuel Bourg wrote: Le 14/08/2013 20:09, Benedikt Ritter a écrit : Every factory method an the constructor now take a CSVFormat. How about using CSVFormat.DEFAULT is null is passed as CSVFormat? Keeping null is better, using the default format might hide a bug in the

Re: [CSV] Prohibit creation of more than one iterator over a CSVParser?

2013-08-14 Thread Adrian Crum
The Iterator should contain a Parser, but not the other way around. -Adrian On 8/14/2013 11:22 AM, Benedikt Ritter wrote: Thanks for the input. Now is the time to talk about this kind of stuff. I understand Matt's proposal and it should be relatively easy to implement. However I see Paul's poi

Re: [convert] Automatic conversion based on proxies

2013-08-14 Thread Adrian Crum
I don't think CSV needs anything special to accommodate type conversion. The pattern I tried to introduce in the Commons Convert "Getting Started" section is one that works in any part of an application where conversion might be needed. So, instead of hard-coding conversions, the developer cre

Re: [spam] Re: [CONVERT] Toward Release 1.0

2013-08-12 Thread Adrian Crum
I had to commit it manually. -Adrian On 8/12/2013 1:01 PM, Matt Benson wrote: Your account is likely locked out now. I just reset mine from a mvn site:stage build I did earlier today. ;) Matt On Mon, Aug 12, 2013 at 2:51 PM, Adrian Crum < adrian.c...@sandglass-software.com>

Re: [CONVERT] Toward Release 1.0

2013-08-12 Thread Adrian Crum
-Adrian On 8/12/2013 10:43 AM, Benedikt Ritter wrote: Hey, site publication has changed. Use the steps described on the website: http://commons.apache.org/site-publish.html Benedikt 2013/8/12 Adrian Crum In revision 1513175 I updated the code with the latest bug fixes. I can't deplo

Re: svn commit: r1513173 - /commons/sandbox/convert/trunk/build.xml

2013-08-12 Thread Adrian Crum
The Convert devs use Ant. We are not accustomed to using Maven. -Adrian On 8/12/2013 11:34 AM, sebb wrote: On 12 August 2013 18:45, Benedikt Ritter wrote: 2013/8/12 Author: adrianc Date: Mon Aug 12 15:47:17 2013 New Revision: 1513173 URL: http://svn.apache.org/r1513173 Log: Fixed some bui

[CONVERT] Toward Release 1.0

2013-08-12 Thread Adrian Crum
In revision 1513175 I updated the code with the latest bug fixes. I can't deploy the site changes because the maven site:deploy target is broken - most likely due to recent changes to the deployment scripts. It worked fine the last time I used it. So, I need help from a maven guru to get it fix

Re: [CSV] Creating CSVParser instances

2013-08-08 Thread Adrian Crum
+1 for createParser(...) -Adrian On 8/8/2013 6:14 AM, Gary Gregory wrote: On Thu, Aug 8, 2013 at 5:30 AM, Emmanuel Bourg wrote: Thank you for pointing this, I didn't notice this recent addition. I'm not fond of the parseType(Type t) methods, I'd prefer parse(Type t). I'm OK with 'parse' o

Re: [convert] String to Boolean converter

2013-08-05 Thread Adrian Crum
Yes, that would be a good change. The general goal of String conversions was to mimic the type's toString() and valueOf() methods, but there are some exceptions that are left over from OFBiz. I tried to remove the OFBiz-specific code when I ported the code to Commons, but I can see I missed a

Re: [csv] accessing primitives and other record values

2013-08-04 Thread Adrian Crum
thing happened for BeanUtils from Lang). If Convert is to be released, I think BeanUtils should get some refactoring for a 2.0 release. They should harmonize but not duplicate functionality. Paul On Sat, Aug 3, 2013 at 11:58 AM, Gary Gregory wrote: On Sat, Aug 3, 2013 at 12:55 PM, Adrian C

Re: [csv] accessing primitives and other record values

2013-08-03 Thread Adrian Crum
I am working on getting the bug fixes committed today. I will also include some more JavaDocs - hopefully that will help. If anyone wants to improve things further, they are welcome to do so. -Adrian On 8/3/2013 9:17 AM, James Carman wrote: On Sat, Aug 3, 2013 at 12:05 PM, Gary Gregory wrote

Re: [csv] accessing primitives and other record values

2013-08-03 Thread Adrian Crum
On 8/3/2013 9:49 AM, Gary Gregory wrote: On Sat, Aug 3, 2013 at 12:10 PM, Adrian Crum < adrian.c...@sandglass-software.com> wrote: Inline... On 8/3/2013 9:05 AM, Gary Gregory wrote: On Sat, Aug 3, 2013 at 11:50 AM, Adrian Crum < adrian.crum@sandglass-**software.com > wrote:

Re: [csv] accessing primitives and other record values

2013-08-03 Thread Adrian Crum
he same thing? Paul On Sat, Aug 3, 2013 at 11:25 AM, Adrian Crum < adrian.c...@sandglass-software.com> wrote: Actually, I picture it like this: Commons CSV does not contain any conversions, and data type conversions are left to the application developer. We can recommend Commons Convert.

Re: [csv] accessing primitives and other record values

2013-08-03 Thread Adrian Crum
/2013 9:18 AM, Paul Benedict wrote: Adrian, the conversions would be configurable. At least that's how I envisioned it using existing BeanUtils functionality. Gary has a request our to me to demo that. On Aug 3, 2013 11:10 AM, "Adrian Crum" wrote: Inline... On 8/3/2013 9:05 AM, Gar

Re: [csv] accessing primitives and other record values

2013-08-03 Thread Adrian Crum
Inline... On 8/3/2013 9:05 AM, Gary Gregory wrote: On Sat, Aug 3, 2013 at 11:50 AM, Adrian Crum < adrian.c...@sandglass-software.com> wrote: Have you considered recommending Commons Convert? No: it is unreleased. Are you willing to help polish it to 1.0? Aside from a pending bug fi

Re: [csv] accessing primitives and other record values

2013-08-03 Thread Adrian Crum
Have you considered recommending Commons Convert? I agree that Java data type conversion is outside the scope of CSV. -Adrian On 8/3/2013 8:36 AM, Gary Gregory wrote: Hi All: I recently added these CSVRecord APIs: getBoolean(String), getInt(String), getLong(String), getBigInteger(String). So

Re: [CHAIN] Why does ConextMap extend ConcurrentHashMap instead of delegating to a Map?

2013-06-24 Thread Adrian Crum
I have always preferred the "has-a" approach over the "is-a" approach. It makes things easier to refactor down the road. -Adrian On 6/24/2013 7:30 PM, Benedikt Ritter wrote: Hi, I just wonder why ContextMap inherits from ConcurrentHashMap. This seems like an unnecessary restriction. The cont

Re: [CSV] change line number from 0-based to 1-based

2013-05-07 Thread Adrian Crum
processed, reached end of record. Current line number = 3, lines processed = 2, records processed = 1. -Adrian On 5/7/2013 12:08 PM, sebb wrote: On 7 May 2013 11:36, Adrian Crum wrote: Maybe the method could be named better, something like ExtendedBufferedReader.getCurrentLineNumber() - which

Re: [CSV] change line number from 0-based to 1-based

2013-05-07 Thread Adrian Crum
Maybe the method could be named better, something like ExtendedBufferedReader.getCurrentLineNumber() - which would be different than total lines processed. -Adrian On 5/7/2013 11:05 AM, sebb wrote: I've been looking at it further and there is an issue with 1-based counting. The line number c

Re: svn commit: r1477592 - in /commons/proper/codec/trunk/src: changes/changes.xml main/java/org/apache/commons/codec/language/Metaphone.java

2013-04-30 Thread Adrian Crum
implemenations: -> implementations: -Adrian On 4/30/2013 1:44 PM, Gary Gregory wrote: ah, where? Gary On Tue, Apr 30, 2013 at 8:36 AM, Adrian Crum < adrian.c...@sandglass-software.com> wrote: On 4/30/2013 1:32 PM, ggreg...@apache.org wrote: Author: ggregory Date: Tue Apr 30

Re: svn commit: r1477592 - in /commons/proper/codec/trunk/src: changes/changes.xml main/java/org/apache/commons/codec/language/Metaphone.java

2013-04-30 Thread Adrian Crum
On 4/30/2013 1:32 PM, ggreg...@apache.org wrote: Author: ggregory Date: Tue Apr 30 12:32:24 2013 New Revision: 1477592 URL: http://svn.apache.org/r1477592 Log: [CODEC-170] Link broken in Metaphone Javadoc. Modified: commons/proper/codec/trunk/src/changes/changes.xml commons/proper/co

Re: [CSV] Should the Builder API be optional?

2013-04-09 Thread Adrian Crum
True. Users are free to create their own facade to make object construction easier. -Adrian On 4/9/2013 6:22 AM, Gary Gregory wrote: WRT org.apache.commons.csv.CSVFormat.CSVFormat(char, Character, Quote, Character, Character, boolean, boolean, String, String, String[]) There does not seem to

Re: [ALL] Cobertura and Parent POM

2013-04-04 Thread Adrian Crum
Thank you for working on this. The original proposal was to replace Cobertura with something else. I asked that the sub projects have an option to use whatever reporting tool they want. So, it would be fine if some other reporting tool was the default as long as sub projects can use something

Re: svn commit: r1461134 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2013-03-26 Thread Adrian Crum
I like the idea of improving the JavaDoc. The DEFAULT field was very intuitive. -Adrian On 3/26/2013 2:14 PM, Gary Gregory wrote: On Tue, Mar 26, 2013 at 10:06 AM, Emmanuel Bourg wrote: Le 26/03/2013 14:58, ggreg...@apache.org a écrit : -public static final CSVFormat DEFAULT = // TODO

Re: [all] replacing cobertura with jacoco in parent pom

2013-03-25 Thread Adrian Crum
Is there any way a project can select its own code coverage tool? I don't like the top-down, all-or-nothing approach to Commons build files. -Adrian On 3/25/2013 10:01 AM, Luc Maisonobe wrote: Hi all, We have already discussed about some problems with the cobertura maven plugin (see

Re: [CSV] Extract interfaces?

2013-03-24 Thread Adrian Crum
On 3/23/2013 12:59 PM, Thomas Neidhart wrote: On 03/23/2013 12:41 PM, Benedikt Ritter wrote: Hi, while looking through the code, I was asking myself why we expose implementation classes. Wouldn't it be better to extract interfaces from CSVParser, CSVPrinter and CSVRecord? At least for the CSVRe

Re: [CSV] Problems building the page Was: [CSV] Finishing v1.0

2013-03-21 Thread Adrian Crum
lol - NOW you ask me. I think it was 2.2. -Adrian On 3/21/2013 4:12 PM, Gary Gregory wrote: What version did you use before? Gary On Thu, Mar 21, 2013 at 11:35 AM, Adrian Crum < adrian.c...@sandglass-software.com> wrote: I upgraded to Maven 3.0.5 and the problem was solved.

Re: [CSV] Problems building the page Was: [CSV] Finishing v1.0

2013-03-21 Thread Adrian Crum
2013 at 7:14 AM, Benedikt Ritter wrote: 2013/3/21 Adrian Crum Running mvn site generates an error: [ERROR] BUILD ERROR [INFO] --**--** [INFO] Error during page generation Embedded error: Error rendering Maven report: org.

Re: [CSV] Finishing v1.0

2013-03-21 Thread Adrian Crum
] -Adrian On 3/21/2013 9:38 AM, Adrian Crum wrote: The CSV site is very confusing: 1. The nightly build is not current. 2. The "JavaDoc (latest)" link points to an API that does not match the latest API. -Adrian On 3/20/2013 8:59 AM, Adrian Crum wrote: Okay, that lo

Re: [CSV] Finishing v1.0

2013-03-21 Thread Adrian Crum
The CSV site is very confusing: 1. The nightly build is not current. 2. The "JavaDoc (latest)" link points to an API that does not match the latest API. -Adrian On 3/20/2013 8:59 AM, Adrian Crum wrote: Okay, that looks better. -Adrian On 3/20/2013 8:52 AM, Benedikt Ritter wr

Re: [CSV] Finishing v1.0

2013-03-20 Thread Adrian Crum
Okay, that looks better. -Adrian On 3/20/2013 8:52 AM, Benedikt Ritter wrote: That build is dated 30-Jul-2007. Please have a look at trunk in SVN ;-) Benedikt 2013/3/20 Adrian Crum I grabbed the latest build: http://people.apache.org/** builds/commons/nightly/**commons-csv/<h

Re: [CSV] Finishing v1.0

2013-03-20 Thread Adrian Crum
013/3/20 Adrian Crum There is a part of the API that I don't like - the CSVStrategy class is mutable. I can't imagine a file's strategy changing mid-file, so from my perspective the class should be immutable. Plus, the previous version used a builder pattern that I liked. -Adrian

Re: [CSV] Finishing v1.0

2013-03-20 Thread Adrian Crum
ets can be postponed. IMO the only items that must be fixed are regressions (not possible for first release of course). Also if there is new code with a bad API, that needs to be fixed before first release as it may be impossible to fix later without causing lots of trouble, Benedikt 2013/3

Re: [CSV] Finishing v1.0

2013-03-19 Thread Adrian Crum
I would be interested in helping too. -Adrian On 3/19/2013 12:53 PM, Gary Gregory wrote: I am interested in seeing it through a 1.0. Let's make sure we like the API... Gary On Tue, Mar 19, 2013 at 8:39 AM, Benedikt Ritter wrote: Hi all, we have this request [1] from the Any23 community r

Re: [BeanUtils2] WeakHashMap is not a cache (?)

2012-08-13 Thread Adrian Crum
/simonetripodi http://www.99soft.org/ On Mon, Aug 13, 2012 at 3:19 PM, Adrian Crum wrote: Apache OFBiz has a soft reference cache implementation. -Adrian On 8/13/2012 1:07 PM, Simone Tripodi wrote: guten morgen Bene, I have not a strong opinion about it, I am convinced anyway that the original BU

Re: [BeanUtils2] WeakHashMap is not a cache (?)

2012-08-13 Thread Adrian Crum
Apache OFBiz has a soft reference cache implementation. -Adrian On 8/13/2012 1:07 PM, Simone Tripodi wrote: guten morgen Bene, I have not a strong opinion about it, I am convinced anyway that the original BU authors (BU2 at the beginning was a tentative to refurbish BU) adopted the WeakHashMap

Re: [all] Is this disguised fishing?

2012-07-12 Thread Adrian Crum
I haven't received that specific email, but I always reply back that any discussions about Apache projects should be kept on the mailing lists. -Adrian On 7/12/2012 1:48 PM, Sébastien Brisard wrote: Dear all, please find below a message I've received. It was sent to my apache address, which I

Re: [ALL] Commons JMS Project

2012-07-10 Thread Adrian Crum
I would like to be involved with this once it has found a home. -Adrian On 7/9/2012 9:12 PM, Scott England-Sullivan wrote: Hello, I have developed a new component for the Apache Camel project written using pure Java JMS APIs (the current component is a Spring JMS wrapper). There have been req

Re: [collections] Cleanup of trunk

2012-06-24 Thread Adrian Crum
On 6/24/2012 12:25 PM, sebb wrote: On 24 June 2012 10:28, Thomas Neidhart wrote: Hi, I recently started to work more on collections and cleaning up the trunk to make it a candidate for a release and would like to ask a few questions: - there is still lots of javadoc missing, moving the sour

  1   2   >