RE: Re: [lang] StringUtils.abbreviate is not emoji aware, breaks surrogate pairs

2025-04-14 Thread Carsten Kirschner
Hello Gary, I updated the unit test, and removed the guessing part, I think. This page shows nicely how the Family Grapheme is composed https://utf-8-visualizer.ardis.lu/?q=%F0%9F%91%A8%F0%9F%8F%BB%E2%80%8D%F0%9F%91%A9%F0%9F%8F%BB%E2%80%8D%F0%9F%91%A6%F0%9F%8F%BB%E2%80%8D%F0%9F%91%A6%F0%9F%8F%BB

Re: [lang] StringUtils.abbreviate is not emoji aware, breaks surrogate pairs

2025-04-14 Thread Gary Gregory
Hi Carsten, Could you provide a unit test with the expected behavior? The example you gave has console output and assertions commented out, both of which are undesirable. Instead of me guessing, I'd rather you manage expectations and provide a failing/passing set of assertions. TY! Gary On Sun,

Re: [VOTE] Release Apache Commons JXPath 1.4.0 based on RC2

2025-04-14 Thread Henri Biestro
[+1] Build & tests ok, javadoc looks good, site & reports are functional. No deal breaker, 3 nits: - the 1.4 release notes are not accessible fro anywhere but changes report contains almost same info; - spotbugs & taglist reports could benefit from a closer look; - some coverage may be improved