Re: [CLI] Javadoc

2024-10-16 Thread Gary Gregory
Let's get back on topic here please: What I'm looking for is what the JAVADOC should say, in words, to set expectations for users/call sites and provide guidance for implementors. What matters more is what null means when it's allowed because telling me something is nullable with an annotation is

Re: [CLI] Javadoc

2024-10-16 Thread sebb
On Wed, 16 Oct 2024 at 16:15, Gary Gregory wrote: > > I don't think we need this, mostly because I prefer to not have issues with > annotation X vs. Y vs. Z. There are a ton of these types of annotations out > there and using one vs another because the Jetbrain IDE likes it is not a > good enough

Re: [CLI] Javadoc

2024-10-16 Thread Johannes Weberhofer
We had a discussion about the same thing a few month ago - I personally like this kind of annotations a lot. I found a very interesting project at https://jspecify.dev/ A good overview mentioning several implementations at https://stackoverflow.com/questions/4963300/which-notnull-java-annotati

Re: [CLI] Javadoc

2024-10-16 Thread Gary Gregory
I don't think we need this, mostly because I prefer to not have issues with annotation X vs. Y vs. Z. There are a ton of these types of annotations out there and using one vs another because the Jetbrain IDE likes it is not a good enough reason IMO. There's also a javax version, and a jakarta vers

Re: [CLI] Javadoc

2024-10-16 Thread Claude Warren
Yeah, it was the dependency question. I know that in general commons projects try to keep dependencies to a minimum. I like the idea and think I would agree with you after playing with the annotations. On Wed, Oct 16, 2024 at 3:17 PM Xeno Amess wrote: > apply jsr 305 annotations just make code

Re: [CLI] Javadoc

2024-10-16 Thread Xeno Amess
apply jsr 305 annotations just make codes neat (IMO) also good for quite some ide/analyzing tools when they try index/auto find bugs. well there be very many jsr-305 impls so if not jetbrains we can use google code or even impl our own one. negative point is we need another dependency(though usuall

Re: [collections] Multidimensional Bloom Filters (was BloomFilterExtractor.flatten)

2024-10-16 Thread Claude Warren
search is a matching operation against contained filters ... I don't think we want to call it match as that is then confused with the standard Bloom filter match. locate is an exact match -- byte for byte the same. Technically search results can be filtered for locate but in some implementations l

Re: [CLI] Javadoc

2024-10-16 Thread Claude Warren
What is the general stance on commons to import the annotations? Is there a reason not to? I'm happy to make the changes but want to make sure there is not a blocker first. Claude On Tue, Oct 15, 2024 at 9:56 AM Xeno Amess wrote: > yep, I always think, this kind of allow null not allow null t