On Sat, Oct 5, 2024 at 11:26 AM Claude Warren wrote:
> >
> > WrappedBloomFilter is not a WrappedBloomFilter,
>
>
> This is true in most useful cases for the test `
> assertEquals(bf1.getClass(), copy.getClass());
>
> In a proposed KIP (Kafka Improvement Proposal) there is a Bloom filter that
> i
On Sat, Oct 5, 2024 at 11:46 AM Claude Warren wrote:
> Your Fixture solution is close to correct.
>
> @Override
> > public WrappedBloomFilter copy() {
> > return new Fixture(getWrapped());
> > }
>
>
> should return new Fixture(getWrapped().copy());
>
Thank you for you
On Fri, Oct 4, 2024 at 1:30 PM Alex Herbert
wrote:
> You cannot return an empty BloomFilter when there is no array of
> BloomFilters to flatten. The BloomFilter is tied to a Shape. Without a
> shape you cannot know what size filter to create. So we have to return
> null or throw an exception. Wha
We have fixed a few bugs and added enhancements since Apache Commons Parent
76 was released, so I would like to release Apache Commons Parent 77.
Apache Commons Parent 77 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/parent/77-RC1 (svn
revision 72148)
The Gi
Your Fixture solution is close to correct.
@Override
> public WrappedBloomFilter copy() {
> return new Fixture(getWrapped());
> }
should return new Fixture(getWrapped().copy());
On Sat, Oct 5, 2024 at 4:42 PM Claude Warren wrote:
> Ignore my previous message. I do
Ignore my previous message. I don't know where my mind was.
On Sat, Oct 5, 2024 at 4:26 PM Claude Warren wrote:
> WrappedBloomFilter is not a WrappedBloomFilter,
>
>
> This is true in most useful cases for the test `
> assertEquals(bf1.getClass(), copy.getClass());
>
> In a proposed KIP (Kafka
>
> WrappedBloomFilter is not a WrappedBloomFilter,
This is true in most useful cases for the test `
assertEquals(bf1.getClass(), copy.getClass());
In a proposed KIP (Kafka Improvement Proposal) there is a Bloom filter that
is decorated with additional data (The timestamp for when it was create
The WrappedBloomFilterTest currently says [0][1] that a copy of a
WrappedBloomFilter is not a WrappedBloomFilter, which does not make sense
to me as non-SME.
Should the test be adjusted? It looks like the test is written in a
contrived way due to WrappedBloomFilter being abstract. I would make mor
