Re: [Codec] clearing input byte array vs not

2023-08-12 Thread Gary Gregory
I tend to agree and that's how I would write a new API today, but this is what we have had for years. I am guessing the behavior came from the C implementation (FreeBSD). Mark, any further thoughts? We do not have a concensus atm. Gary On Sat, Aug 12, 2023, 4:09 PM Elliotte Rusty Harold wrot

Re: [Codec] clearing input byte array vs not

2023-08-12 Thread Elliotte Rusty Harold
I still think the input byte array should not be cleared, period. Clearing is a separate operation that should be performed by the caller. On Sat, Aug 12, 2023 at 12:52 PM Gary Gregory wrote: > > Coming back around to this now that Mark fixed the mailing list noise. > > Git master now documents t

Re: [Codec] clearing input byte array vs not

2023-08-12 Thread Gary Gregory
Coming back around to this now that Mark fixed the mailing list noise. Git master now documents the existing clearing behavior as suggested by Mark in https://lists.apache.org/thread/cyrpgsqx4lnjlsf3frqwfo5pvbmpcycr Next, is how to document or change Crypt.crypt(byte[], String): The method clears