On Mon, Jul 3, 2023 at 12:20 AM Gary Gregory wrote:
>
> Hi Elliotte:
>
> Might you be looking at some old code in the PR?
>
Just looking at what was posted in the email thread. It's a weird
corner case not everyone thinks of.
> The current code is:
>
> /**
> * Checks if a throwable repr
I just noticed that the line
return !isChecked(throwable)
Means that if throwable is null then it will be considered unchecked. I
will fix that tomorrow by doing
Return throwable ! null && throwable instanceof Exception;
On Mon, 3 Jul 2023, 01:20 Gary Gregory, wrote:
> Hi Elliotte:
>
> Might you
Hi Elliotte. I never thought of that, but I don't think it is Apache's
problem if people exit the java convention
On Mon, 3 Jul 2023, 01:02 Elliotte Rusty Harold, wrote:
> On Sun, Jul 2, 2023 at 8:53 PM Alex Herbert
> wrote:
>
> > public static boolean isUnchecked(final Throwable throwable)
Hi Elliotte:
Might you be looking at some old code in the PR?
The current code is:
/**
* Checks if a throwable represents a checked exception
*
* @param throwable
*The throwable to check.
* @return True if the given Throwable is a checked exception.
On Sun, Jul 2, 2023 at 8:53 PM Alex Herbert wrote:
> public static boolean isUnchecked(final Throwable throwable) {
> return (throwable instanceof Error) || (throwable instanceof
> RuntimeException);
> }
Not quite. It's also possible for someone to define a subclass of
Throwable
Oops: "Apache Commons Builder Plugin 1.8.1" -> "Apache Commons Release
Plugin 1.8.1"
Sorry,
Gary
On Sun, Jul 2, 2023 at 7:23 PM Gary Gregory wrote:
>
> To the dev list only, hello all,
>
> We've released Apache Commons Builder Plugin 1.8.1, our internal build
> plugin to help RMs.
>
> https://co
To the dev list only, hello all,
We've released Apache Commons Build Plugin 1.13, our (other) internal build
plugin to help RMs.
https://commons.apache.org/proper/commons-build-plugin/
Gary
-
To unsubscribe, e-mail: dev-unsubsc
To the dev list only, hello all,
We've released Apache Commons Builder Plugin 1.8.1, our internal build
plugin to help RMs.
https://commons.apache.org/proper/commons-release-plugin/
Gary
-
To unsubscribe, e-mail: dev-unsubscr..
This change is not null-safe for isUnchecked. This case is missing
from the tests (and currently fails):
@Test
public void testIsUnchecked_null() {
assertFalse(ExceptionUtils.isUnchecked(null));
}
The case fails because it simply negates isChecked. Both methods
should return f
Oh, BTW, please don't take this as a strong position against making the
code thread-safe. I am trying to understand the source of the desire for
change, and playing a bit of devil's advocate.
Gary
On Sun, Jul 2, 2023, 07:46 Gary Gregory wrote:
> The question I have is whether thread safety is
The question I have is whether thread safety is something you require here
or think is a feature people will be surprised is absent.
Sometimes extra bells and whistles make the code harder to maintain. Once
advertised as such, it may become quite hard to fix bugs or add new
features. I would consi
I do not think concurrent write usage is a general use case for the
filter. So this seems like a specialisation. If implementing it would
harm performance then I would be against it for the base
implementation.
For specialisation I would prefer the JDK pattern used for
Synchronized collections whi
12 matches
Mail list logo
