Re: [COLLECTIONS] Trie subclassing

2023-04-17 Thread Gary Gregory
I am guessing that only what is required to be public is as to both maximize our flexibility in maintenance and minimize the public API surface to support. We could make it public if we are sure the API is documented and the code isbas good as we can reasonably make it. Gary On Mon, Apr 17, 202

Re: [IO] SymbolicLinkFileFilter

2023-04-17 Thread Miguel Muñoz
"The class per its javadoc filters for symbolic links on files." It sounds like it's only supposed to pass files that are symbolic links. If that's the idea, the class doesn't work at all. If not, we need a clearer description. As for unit tests, maybe the test should detect the Windows OS and ju

[COLLECTIONS] Trie subclassing

2023-04-17 Thread Claude Warren
I was looking at the Trie and PatriciaTree class structure from version 4.5 over the weekend. I wanted to build a different implementation with slight modifications. However, there does not seem to be a way to inherit from AbstractPatriciaTrie as it is package protected. Was this intentional or

Re: [IO] SymbolicLinkFileFilter

2023-04-17 Thread Miguel Muñoz
Here's a better idea for how to write the unit test. First, we put something in the SymbolicLinkFileFilter class like this: public class SymbolicLinkFileFilter { private static LinkTester linkTester = new LinkTester(); // defined below static setLinkTesterForUnitTests(LinkTester unitTestLinkT

[IO] IO-769: FileUtils copyDirectory() should not use COPY_ATTRIBUTES #377

2023-04-17 Thread Gary Gregory
Hi All, I would like to get some ideas and consensus on how to proceed with https://github.com/apache/commons-io/pull/377 Thank you, Gary