Re: [commons-compress] branch master updated: Address CodeQL issues in pack200/unpack200 packages.

2022-02-09 Thread Gilles Sadowski
Le mer. 9 févr. 2022 à 16:32, Gary Gregory a écrit : > > Crafting a compressed file for a test fixture that causes a integer > overflow deep in our code would be quite hard to reverse engineer. I of course agree that it would be overkill; hence the question, again: Why int size = ... size = E

Re: [commons-compress] branch master updated: Address CodeQL issues in pack200/unpack200 packages.

2022-02-09 Thread Gary Gregory
Crafting a compressed file for a test fixture that causes a integer overflow deep in our code would be quite hard to reverse engineer. Gary On Wed, Feb 9, 2022, 09:38 Gilles Sadowski wrote: > Le mer. 9 févr. 2022 à 15:16, Gary Gregory a > écrit : > > > > Observe > > Perhaps I'm dense, but my d

Re: [commons-compress] branch master updated: Address CodeQL issues in pack200/unpack200 packages.

2022-02-09 Thread Gilles Sadowski
Le mer. 9 févr. 2022 à 15:16, Gary Gregory a écrit : > > Observe Perhaps I'm dense, but my detailed remark about the commit reflects that I did. > that ExactMath delegates to Math after performing the necessary > additional Math calls. As per the first part of the remark, it is not obvious why

Re: [commons-compress] branch master updated: Address CodeQL issues in pack200/unpack200 packages.

2022-02-09 Thread Gary Gregory
Observe that ExactMath delegates to Math after performing the necessary additional Math calls. Gary On Wed, Feb 9, 2022, 08:12 Gilles Sadowski wrote: > Hello. > > Le mer. 9 févr. 2022 à 02:59, a écrit : > > > > This is an automated email from the ASF dual-hosted git repository. > > > > ggregor

Re: [All] GSoC 2022

2022-02-09 Thread Gilles Sadowski
Hi. >>> [...] > > > > > > Shall we open a "GSoC 2022" report in each concerned JIRA project? > > > > Yes. I think we just create some tickets and tag them with the > > appropriate tag (GSOC 2022 ?). There should be some left over from > > last time to repurpose or use as templates for new ones. >

Re: [commons-compress] branch master updated: Address CodeQL issues in pack200/unpack200 packages.

2022-02-09 Thread Gilles Sadowski
Hello. Le mer. 9 févr. 2022 à 02:59, a écrit : > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-compress.git > > > The following commit(s) were added to refs/heads/mast