Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Alex Herbert
I have removed the requirement for Java 9 from the build. It is still used in the performance testing module. Alex

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Strauss, Randy (ARC-TI)[KBR Wyle Services, LLC]
Note that the test could inspect the java version, or use reflection to see if the method BigDecimal.sqrt() exists... -r Randy Strauss, cell: 650-861-1537 On 6/9/21, 2:57 PM, "sebb" wrote: On Wed, 9 Jun 2021 at 19:58, Alex Herbert wrote: > > On Wed, 9 Jun 2021 at 17:56, sebb wrote

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread sebb
On Wed, 9 Jun 2021 at 19:58, Alex Herbert wrote: > > On Wed, 9 Jun 2021 at 17:56, sebb wrote: > > > On Wed, 9 Jun 2021 at 17:26, Alex Herbert > > wrote: > > > > > > On Wed, 9 Jun 2021 at 17:03, John Patrick > > wrote: > > > > > > > Have you tried "9" instead of "1.9"? > > > > > > > > > > I've c

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Gilles Sadowski
Le mer. 9 juin 2021 à 20:58, Alex Herbert a écrit : > > On Wed, 9 Jun 2021 at 17:56, sebb wrote: > > > On Wed, 9 Jun 2021 at 17:26, Alex Herbert > > wrote: > > > > > > On Wed, 9 Jun 2021 at 17:03, John Patrick > > wrote: > > > > > > > Have you tried "9" instead of "1.9"? > > > > > > > > > > I'v

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Alex Herbert
On Wed, 9 Jun 2021 at 17:56, sebb wrote: > On Wed, 9 Jun 2021 at 17:26, Alex Herbert > wrote: > > > > On Wed, 9 Jun 2021 at 17:03, John Patrick > wrote: > > > > > Have you tried "9" instead of "1.9"? > > > > > > > I've corrected that in the pom, thanks. > > > > I think the issue is that Gilles

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread sebb
On Wed, 9 Jun 2021 at 17:26, Alex Herbert wrote: > > On Wed, 9 Jun 2021 at 17:03, John Patrick wrote: > > > Have you tried "9" instead of "1.9"? > > > > I've corrected that in the pom, thanks. > > I think the issue is that Gilles used JDK 8 to try and build it. You can > run using the project's m

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Alex Herbert
On Wed, 9 Jun 2021 at 17:03, John Patrick wrote: > Have you tried "9" instead of "1.9"? > I've corrected that in the pom, thanks. I think the issue is that Gilles used JDK 8 to try and build it. You can run using the project's main artifacts using JDK 8, but the build now requires JDK 9 for the

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread John Patrick
Have you tried "9" instead of "1.9"? I believe the 1.x was dropped with Java 9's release. Also might want to bump it to Java 11 as that is a LTS release, as 9 was only supported for 6 months from september 2017 to march 2018. Also with 9 and newer, maven.compiler.source/maven.compiler.target have

Re: [Math] CI builds are missing problems

2021-06-09 Thread Alex Herbert
On Wed, 9 Jun 2021 at 16:04, Gilles Sadowski wrote: > Le mer. 9 juin 2021 à 16:07, Alex Herbert a > écrit : > > > > The math project does not build with the default goal in the pom: > > > > clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check > > javadoc:javadoc > > > > There

Re: [Math] CI builds are missing problems

2021-06-09 Thread Gilles Sadowski
Le mer. 9 juin 2021 à 16:07, Alex Herbert a écrit : > > The math project does not build with the default goal in the pom: > > clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check > javadoc:javadoc > > There is a spotbugs error in the Artificial neural networks module due to a >

Re: [math] Problems building Commons Math4 Legacy

2021-06-09 Thread Gilles Sadowski
Le mer. 9 juin 2021 à 16:10, Alex Herbert a écrit : > > On Wed, 9 Jun 2021 at 15:02, Gilles Sadowski wrote: > > > Le mer. 9 juin 2021 à 15:58, Alex Herbert a > > écrit : > > > > > I'm doing it... > > > > OK. I was trying to fix the math build using the default maven goal. > Currently there are i

[Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Gilles Sadowski
Hi. "Commons Numbers" POM of module "commons-numbers-core" contains ---CUT--- 1.9 1.9 ---CUT--- Running $ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64/ mvn test site site:stage fails: ---CUT--- [...] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:t

Re: [math] Problems building Commons Math4 Legacy

2021-06-09 Thread Alex Herbert
On Wed, 9 Jun 2021 at 15:02, Gilles Sadowski wrote: > Le mer. 9 juin 2021 à 15:58, Alex Herbert a > écrit : > > > I'm doing it... > OK. I was trying to fix the math build using the default maven goal. Currently there are issues. See separate e-mail thread on the CI build goals. I've pushed the

[Math] CI builds are missing problems

2021-06-09 Thread Alex Herbert
The math project does not build with the default goal in the pom: clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check javadoc:javadoc There is a spotbugs error in the Artificial neural networks module due to a case statement fall through. This is intentional so I added an excl

Re: [math] Problems building Commons Math4 Legacy

2021-06-09 Thread Gilles Sadowski
Le mer. 9 juin 2021 à 15:58, Alex Herbert a écrit : > > On Wed, 9 Jun 2021 at 14:55, Gilles Sadowski wrote: > > > Hello. > > > > Le mer. 9 juin 2021 à 15:49, Erik Svensson a > > écrit : > > > > > > Hi! > > > > > > > > > > > > I’m trying and failing to build commons-math and it looks like the cla

Re: [math] Problems building Commons Math4 Legacy

2021-06-09 Thread Alex Herbert
On Wed, 9 Jun 2021 at 14:55, Gilles Sadowski wrote: > Hello. > > Le mer. 9 juin 2021 à 15:49, Erik Svensson a > écrit : > > > > Hi! > > > > > > > > I’m trying and failing to build commons-math and it looks like the class > LinearCombination is either in the wrong package. > > > > In DerivativeSt

Re: [math] Problems building Commons Math4 Legacy

2021-06-09 Thread Gilles Sadowski
Hello. Le mer. 9 juin 2021 à 15:49, Erik Svensson a écrit : > > Hi! > > > > I’m trying and failing to build commons-math and it looks like the class > LinearCombination is either in the wrong package. > > In DerivativeStructure for instance, LinearCombination is declared as > org.apache.commons

[math] Problems building Commons Math4 Legacy

2021-06-09 Thread Erik Svensson
Hi! I’m trying and failing to build commons-math and it looks like the class LinearCombination is either in the wrong package. In DerivativeStructure for instance, LinearCombination is declared as org.apache.commons.numbers.arrays.LinearCombination instead of org.apache.commons.numbers.core.Lin