Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Gary Gregory
Well, it's in a 3rd party jar, just like JUnit and whatever else is needed to complete a decent build... On Mon, Feb 1, 2021, 17:22 sebb wrote: > On Mon, 1 Feb 2021 at 17:56, Matt Sicker wrote: > > > > Compile time annotations would only be necessary to build the commons > > component. > > i.e.

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread sebb
On Mon, 1 Feb 2021 at 17:56, Matt Sicker wrote: > > Compile time annotations would only be necessary to build the commons > component. i.e. consumers of the source code would be required to provide the annotations in some form. This does not sound ideal. > Unless they're runtime scope, but even

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Matt Sicker
Compile time annotations would only be necessary to build the commons component. Unless they're runtime scope, but even that can work without class loader errors provided you're not reflecting on it. On Mon, 1 Feb 2021 at 11:45, sebb wrote: > > On Mon, 1 Feb 2021 at 16:52, Tomo Suzuki wrote: > >

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread sebb
On Mon, 1 Feb 2021 at 16:52, Tomo Suzuki wrote: > > I like "javax.annotation namespace" too. > > Would you be willing to share more about why the annotation dependency > should have "provided" scope? If a library (commons-lang) requires a > dependency at runtime, I believe it should declare it as

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Tomo Suzuki
I like "javax.annotation namespace" too. Would you be willing to share more about why the annotation dependency should have "provided" scope? If a library (commons-lang) requires a dependency at runtime, I believe it should declare it as "compile" dependency. In past, I did troubleshooting for mis

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread sebb
The ASF releases source. Does the inclusion of these source annotations impose a burden on people who download and compile our source? On Mon, 1 Feb 2021 at 14:31, Julian Reschke wrote: > > Am 01.02.2021 um 15:04 schrieb Gilles Sadowski: > > Le lun. 1 févr. 2021 à 14:49, Jochen Wiedmann > > a é

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Julian Reschke
Am 01.02.2021 um 15:04 schrieb Gilles Sadowski: Le lun. 1 févr. 2021 à 14:49, Jochen Wiedmann a écrit : On Mon, Feb 1, 2021 at 2:34 PM Gary Gregory wrote: 1) Don't add and use custom annotations, this opens the door to each of our 20+ components doing the same thing, so pick a library and s

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Emmanuel Bourg
Le 01/02/2021 à 11:58, Jochen Wiedmann a écrit : > So, assuming that my proposal should be accepted: How do we proceed? I > see two alternatives: > > a) We had com.google.code.findbugs:jsr305:3.0.2 with a scope > "provided" to our dependencies. The scope will guarantee, that users > aren't affect

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Gilles Sadowski
Le lun. 1 févr. 2021 à 14:49, Jochen Wiedmann a écrit : > > On Mon, Feb 1, 2021 at 2:34 PM Gary Gregory wrote: > > > 1) Don't add and use custom annotations, this opens the door to each of our > > 20+ components doing the same thing, so pick a library and stick with it. > > I suggested starting w

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Gilles Sadowski
Le lun. 1 févr. 2021 à 14:34, Gary Gregory a écrit : > > My concerns are: > > 1) Don't add and use custom annotations, this opens the door to each of our > 20+ components doing the same thing, so pick a library and stick with it. +1 > 2) Make sure there are no licensing issues with that library.

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Jochen Wiedmann
On Mon, Feb 1, 2021 at 2:34 PM Gary Gregory wrote: > 1) Don't add and use custom annotations, this opens the door to each of our > 20+ components doing the same thing, so pick a library and stick with it. I suggested starting with lang, because that would be the template for most others. (At lea

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Gary Gregory
My concerns are: 1) Don't add and use custom annotations, this opens the door to each of our 20+ components doing the same thing, so pick a library and stick with it. 2) Make sure there are no licensing issues with that library. Gary On Mon, Feb 1, 2021, 05:58 Jochen Wiedmann wrote: > Hi, > >

Re: [lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Bruno P. Kinoshita
Thanks for the explanation. Looks like it would be helpful for IDE/static analyzers/etc, without any impact for the users runtime. I think a) makes sense, but b) would be OK too for me. Cheers Bruno On Monday, 1 February 2021, 11:58:23 pm NZDT, Jochen Wiedmann wrote: Hi, as a fol

[lang] Introduce @NonNull, and @Nullable

2021-02-01 Thread Jochen Wiedmann
Hi, as a followup to a discussion, that we had in August 2020, I'd like to propose, that we introduce the @NonNull, and @Nullable annotations into commons-lang. Since that discussion, I began to gradually introduce those annotations into my own code. From that, I have learned three things: