Re: Dependabot pr's

2020-10-15 Thread Mark Thomas
On 15/10/2020 19:30, Gary Gregory wrote: > On Thu, Oct 15, 2020 at 1:57 PM Bernd Eckenfels > wrote: > >> Before we do that, I need help. I am considering to ignore or unsubscribe >> the commit mailing list. Which is IMHO not a good thing (from the point of >> security reviews). However I cannot k

Re: Dependabot pr's

2020-10-15 Thread Gary Gregory
On Thu, Oct 15, 2020 at 1:57 PM Bernd Eckenfels wrote: > Before we do that, I need help. I am considering to ignore or unsubscribe > the commit mailing list. Which is IMHO not a good thing (from the point of > security reviews). However I cannot keep up with dependable suggestions > (and don’t ha

Re: Dependabot pr's

2020-10-15 Thread Gilles Sadowski
Hi. Le jeu. 15 oct. 2020 à 19:57, Bernd Eckenfels a écrit : > > Before we do that, I need help. I am considering to ignore or unsubscribe the > commit mailing list. Which is IMHO not a good thing (from the point of > security reviews). However I cannot keep up with dependable suggestions (and

Re: Dependabot pr's

2020-10-15 Thread Bernd Eckenfels
Before we do that, I need help. I am considering to ignore or unsubscribe the commit mailing list. Which is IMHO not a good thing (from the point of security reviews). However I cannot keep up with dependable suggestions (and don’t have an easy way to filter - and frankly I don’t want to spent a

Re: JUnit assertAll and assertThrows question

2020-10-15 Thread Gilles Sadowski
Hi. Le jeu. 15 oct. 2020 à 17:29, Alex Herbert a écrit : > > > > > On 15 Oct 2020, at 15:56, John Patrick wrote: > > > > <— snip --> > > > > Will look at vfs and maybe also rng regarding tidying up the tests etc. > > Did you mean ’tidying up math’? > > Regarding RNG, [...] I fully concur with A

Re: JUnit assertAll and assertThrows question

2020-10-15 Thread Gary Gregory
It's been a minor struggle to get components to Java 8, despite my efforts. Java 11 is a ways off especially since not all platforms support it yet (IBM iSeries IIRC, which matters to me). I'm all for getting all of Commons to Java 8. Gary On Thu, Oct 15, 2020, 10:57 John Patrick wrote: > Circ

Re: JUnit assertAll and assertThrows question

2020-10-15 Thread Alex Herbert
> On 15 Oct 2020, at 15:56, John Patrick wrote: > > <— snip --> > > Will look at vfs and maybe also rng regarding tidying up the tests etc. Did you mean ’tidying up math’? Regarding RNG, the test suite relies on the fact that statistical tests can fail and be rerun. This uses a feature in J

Re: JUnit assertAll and assertThrows question

2020-10-15 Thread John Patrick
Circa 2016 or 2017 I was trying to get commons projects ready for java 9, so trying to get Automatic-Module-Name added into the manifest. Moved onto other non commons projects for 2018 and 2019, helped with modules and jupiter upgrades. End of 2019 most of the java 9 work on other projects was bloc

Re: [VOTE][LAZY] Release Apache Commons Build Plugin Maven Mojo 1.12 based on RC1

2020-10-15 Thread Gary Gregory
+1 > Details of changes since 1.10 are in the release notes: You must mean since 1.11 ;-) Tested OK with src zip and 'mvn clean package site' Using: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: C:\Java\apache-maven-3.6.3\bin\.. Java version: 1.8.0_251, vendor: Oracl

Re: Dependabot pr's

2020-10-15 Thread Gary Gregory
-1 as is: Dependabot is only helpful if you have a GitHub Action build to verify that the update did not break anything. I'm not really paying attention to Travis CI these days but even this list contains components without a GHA or a TCI build. FYI I just added a GHA build to BSF. I have a separa

Re: [IO] Using file filters with Java NIO file tree walking

2020-10-15 Thread Gary Gregory
On Wed, Oct 14, 2020 at 5:56 PM Bruno P. Kinoshita wrote: > Had a look at the commit [1] and found no issues. Really impressive work > Gary. You've updated the code and also added a lot of examples in the > Javadocs. Really golden. > Thank Bruno! > I used simple code snippets to understand ho

Re: JUnit assertAll and assertThrows question

2020-10-15 Thread Gilles Sadowski
Hello. Le mer. 14 oct. 2020 à 21:41, John Patrick a écrit : > > before i waste time looking at upgrading tests... > > any objections if i upgrade tests to use assertAll and assertThrows > introduced in JUnit jupiter? > > I see it as less tech debt removal and I'm happy to spend time doing > the u

Re: JUnit assertAll and assertThrows question

2020-10-15 Thread John Patrick
Looking at commons-collections, commons-digester and commons-validator at the moment. Will look at commons-vfs next regarding getting to JUnit v4, then adding assertThrows afterwards. What are views about adding `1.8`? I've not done it at the moment as suspect builds are not setup for that and wil