Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Xeno Amess
> However, I've got a question: These annotations have @Retention(Runtime). (See https://www.javadoc.io/doc/com.google.code.findbugs/jsr305/latest/javax/annotation/Nullable.html .) Aren't we enforcing the presence of the respective jar at runtime? Hi. Usually, for Annotations, it have 3 ways to c

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Romain Manni-Bucau
Le mer. 26 août 2020 à 08:42, Xeno Amess a écrit : > > how do we guarantee our meta are right and don't create false positives > If we cannot even make the meta correct, then means we cannot make sure > which function can return Null, which can not, > Then why do you think our customers can do.

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Xeno Amess
> how do we guarantee our meta are right and don't create false positives If we cannot even make the meta correct, then means we cannot make sure which function can return Null, which can not, Then why do you think our customers can do. And if people who write these libs are not sure which functio

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Romain Manni-Bucau
For what it is worth: 1. Generally speaking - and IMHO - these annotations only make sense in a particular tooling setup(s) - like considering values which can be null by code analysis and not by spec (@NotNull) - which I'm not sure we have so it is mainly about making it consumer friendly but how

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Matt Sicker
Runtime retention still doesn’t require the annotations to be present on the classpath unless you perform reflection on them (I forget the specifics). It’s a feature specific to annotations. On Tue, Aug 25, 2020 at 14:36 Jochen Wiedmann wrote: > On Tue, Aug 25, 2020 at 9:08 PM sebb wrote: > > >

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Jochen Wiedmann
On Tue, Aug 25, 2020 at 9:08 PM sebb wrote: > AFAIK that means Maven won't download the dependency. > Surely that makes it harder for the developer? No, it means that Maven won't add the dependency to a distribution. However, I've got a question: These annotations have @Retention(Runtime). (See

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Matt Sicker
Annotations like this don't need to be present at runtime. They can exist only in the source code like that. On Tue, 25 Aug 2020 at 14:08, sebb wrote: > > On Tue, 25 Aug 2020 at 19:48, Xeno Amess wrote: > > > > in maven, dependency can be provided > > AFAIK that means Maven won't download the de

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread sebb
On Tue, 25 Aug 2020 at 19:48, Xeno Amess wrote: > > in maven, dependency can be provided AFAIK that means Maven won't download the dependency. Surely that makes it harder for the developer? > sebb 于2020年8月26日周三 上午2:45写道: > > > Won't this mean that every component has to have a dependency on the

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Xeno Amess
in maven, dependency can be provided sebb 于2020年8月26日周三 上午2:45写道: > Won't this mean that every component has to have a dependency on the > tag library? > > > On Tue, 25 Aug 2020 at 14:45, Matt Sicker wrote: > > > > We use the findbugs annotations fairly extensively in Jenkins, and with > the >

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread sebb
Won't this mean that every component has to have a dependency on the tag library? On Tue, 25 Aug 2020 at 14:45, Matt Sicker wrote: > > We use the findbugs annotations fairly extensively in Jenkins, and with the > proper plugins, it’s helped a lot for nullability checking. > > On Mon, Aug 24, 202

Re: [Crypto] requesting help testing native binaries

2020-08-25 Thread Alex Remily
Bruno, Are you certain that OpenSSL isn't installed on your Windows box? It's supposed to fail before it looks for "OpenSSL_version" if there's no OpenSSL installed. Alex On Tue, Aug 25, 2020 at 2:37 AM Bruno P. Kinoshita wrote: > > Hi Gary, > > I did a mvn clean test install from master, and i

Re: [DAEMON] Time for a release

2020-08-25 Thread Gary Gregory
Go for it :-) Gary On Tue, Aug 25, 2020 at 10:26 AM Mark Thomas wrote: > Hi all, > > It is about time we had another DAEMON release. I'd like to tag and get > the process started in the next day or so. > > If there is anything you'd like to get done before the DAEMON 1.2.3 > release, now is the

[DAEMON] Time for a release

2020-08-25 Thread Mark Thomas
Hi all, It is about time we had another DAEMON release. I'd like to tag and get the process started in the next day or so. If there is anything you'd like to get done before the DAEMON 1.2.3 release, now is the time to do it. Mark

Re: opinions about @NotNull and @Nullable ?

2020-08-25 Thread Matt Sicker
We use the findbugs annotations fairly extensively in Jenkins, and with the proper plugins, it’s helped a lot for nullability checking. On Mon, Aug 24, 2020 at 23:54 Xeno Amess wrote: > Hi. > > Today I see a pr have similar ideas with this, so I will suggest we > > consider it again. > > at [LAN

[lang, numbers] consider about deprecating Fraction in commons-lang and let user use Fraction in commons-number instead?

2020-08-25 Thread Xeno Amess
Hi. A discuss happened about whether we should consider about doing *deprecate in 3.x&remove in 4.x *upon class *Fraction* in commons-lang, and let user use class *Fraction* in commons-number instead. These two class have some different, but not quite much. The discuss happened at https://issues

Re: [commons-text] branch master updated (828ba0a -> 1da0cbb)

2020-08-25 Thread Gary Gregory
Bruno, I think you've been forgetting to update changes.xml Gary On Tue, Aug 25, 2020 at 2:30 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > kinow pushed a change to branch master > in repository https://gitbox.apache.org/repos/asf/commons-text.git. > > >