Re: Introducing Maven Wrapper

2020-08-19 Thread Gilles Sadowski
Hello John. Le mer. 19 août 2020 à 23:38, John Patrick a écrit : > > I've now closed all PR's, and deleted the source branches. > > Giles I've pushed the changes back into my commons-lang fork, so this > would recreate that branch > https://github.com/nhojpatrick/apache_commons-lang/pull/new/taka

Re: Introducing Maven Wrapper

2020-08-19 Thread John Patrick
I've now closed all PR's, and deleted the source branches. Giles I've pushed the changes back into my commons-lang fork, so this would recreate that branch https://github.com/nhojpatrick/apache_commons-lang/pull/new/takari.maven-wrapper. The PR if raised again, would include changes needed for gi

Re: Introducing Maven Wrapper

2020-08-19 Thread Gilles Sadowski
Le mer. 19 août 2020 à 22:49, Gary Gregory a écrit : > > The consensus is do nothing IMO. "Those who do the work" etc. (see below). > > What I really dislike is that if I have 20 components that over time end up > containing 20 different versions of these Cmd/Sh/JavaSource/PropertiesFiles > that

Re: Introducing Maven Wrapper

2020-08-19 Thread Gary Gregory
The consensus is do nothing IMO. What I really dislike is that if I have 20 components that over time end up containing 20 different versions of these Cmd/Sh/JavaSource/PropertiesFiles that point to 20 different versions of Maven, and I build everything, I'll end up with 20 different versions of M

Re: Introducing Maven Wrapper

2020-08-19 Thread Xeno Amess
me +0 for mvnw. I don't hate it and it is well implemented. But I have no idea whether we need it. Rob Tompkins 于2020年8月20日周四 上午4:36写道: > I’m still a +1 for mvnw….do we have a consensus here? > > -Rob > > > On Aug 19, 2020, at 4:27 PM, John Patrick > wrote: > > > > All the suggestions I'm seein

Re: Introducing Maven Wrapper

2020-08-19 Thread Rob Tompkins
I’m still a +1 for mvnw….do we have a consensus here? -Rob > On Aug 19, 2020, at 4:27 PM, John Patrick wrote: > > All the suggestions I'm seeing appear to be hard code solutions to > specific implementations, require defining things in multiple places, > or needing developers to select the corr

Re: Introducing Maven Wrapper

2020-08-19 Thread John Patrick
All the suggestions I'm seeing appear to be hard code solutions to specific implementations, require defining things in multiple places, or needing developers to select the correct version. https://github.com/marketplace/actions/setup-maven won't work on my laptop https://github.com/marketplace/ac

[Compress] SevenZOutputFile vs ArchiveOutputStream

2020-08-19 Thread Gary Gregory
Hi All, Why does SevenZOutputFile NOT extend ArchiveOutputStream? Thank you, Gary

Re: Introducing Maven Wrapper

2020-08-19 Thread Romain Manni-Bucau
Le mer. 19 août 2020 à 14:33, Gary Gregory a écrit : > On Wed, Aug 19, 2020 at 7:49 AM Gary Gregory > wrote: > > > -1 from me, use a set up action instead, for example: > > > > https://github.com/marketplace?type=actions&query=maven > > > > In particular: > > > > https://github.com/marketplace/a

Re: Introducing Maven Wrapper

2020-08-19 Thread Gary Gregory
On Wed, Aug 19, 2020 at 7:49 AM Gary Gregory wrote: > -1 from me, use a set up action instead, for example: > > https://github.com/marketplace?type=actions&query=maven > > In particular: > > https://github.com/marketplace/actions/setup-maven > > As recommended here: > https://github.com/actions/s

Re: Introducing Maven Wrapper

2020-08-19 Thread Gary Gregory
-1 from me, use a set up action instead, for example: https://github.com/marketplace?type=actions&query=maven In particular: https://github.com/marketplace/actions/setup-maven As recommended here: https://github.com/actions/setup-java/issues/40#issuecomment-675817329 Gary On Sat, Aug 15, 2020