Re: [VOTE] Release Apache Commons Geometry (full distribution) 1.0-beta1 based on RC1

Hi. I finished the review. Suggestions details are listed on https://github.com/apache/commons-geometry/pulls Notice that I am not familiar to this repo, nor a math expert, thus you should not fully trust my prs, you need to see them, and check if every change correct, because sometimes I make mist

Re: [VOTE] Release Apache Commons Geometry (full distribution) 1.0-beta1 based on RC1

Hi. I see in some places of the repo, two double fields are compared using ==. Shouldn't we use Double.compare? Or is it by design? example places: PolarCoordinates.equals SphericalCoordinates.equals Vector1D.angle Vector2D.equals Vector3D.equals Vectors.isRealNonZero Xeno Amess 于2020年7月4日周六 上午

[DBCP] testEvict fails

Hello, when I'm running mvn clean test on the current master branch, testEvict always fails with the same error. [ERROR] Failures: [ERROR] TestAbandonedBasicDataSource>TestBasicDataSource.testEvict:946 EvictionTimer thread was destroyed with numIdle=7(expected: less or equal than 5) [ERROR]

Re: [VOTE] Release Apache Commons Geometry (full distribution) 1.0-beta1 based on RC1

Hi. Please also consider about https://github.com/apache/commons-geometry/pull/85 I will perform more analyze opun this repo when you solve this two prs. Xeno Amess 于2020年7月4日周六 上午1:01写道： > Hi. > Please check https://github.com/apache/commons-geometry/pull/84 > In short, there be too many error

Re: [VOTE] Release Apache Commons Geometry (full distribution) 1.0-beta1 based on RC1

Hi. Please check https://github.com/apache/commons-geometry/pull/84 In short, there be too many errors in javadoc. (and this is the reason why I made https://github.com/apache/commons-parent/pull/7) There still exist some other problems, but I'd prefer check them after this pr, as resolve conflict

Re: [VOTE] Release Apache Commons Geometry (full distribution) 1.0-beta1 based on RC1

Hi. I see somethings not quite right already. Will start pr directly. Xeno Amess 于2020年7月3日周五 下午4:20写道： > I might review it tonight if I have time... > Only if I have time. > Really busy these days... >

Re: [Compress] COMPRESS-538 : about Zip64

On 2020-06-28, Peter Lee wrote: > Currently we will add a Zip64 extra field for the entries with uncompressed > size unspecified. And we will update the zip64 extra field in > ZipArchiveOutputStream.rewriteSizesAndCrc a little bit : if we actually > doesn't need a Zip64 extra, we will not remove i

Re: [VOTE] Release Apache Commons Geometry (full distribution) 1.0-beta1 based on RC1

I might review it tonight if I have time... Only if I have time. Really busy these days...