Re: [geometry] Transition from PolyhedronSet to ??? (RegionBSPTree3D ?)

2020-06-16 Thread Matt Juntunen
Hi Sven, If the createVertices and createFacets methods don't construct convex polygons then perhaps you could bypass them completely and just construct the tree directly from the boundaries. Assuming that I understand your use case correctly, the following methods should do what you want: pri

Re: [commons-parent] branch master updated: Update to latest plugins

2020-06-16 Thread Gary Gregory
The latest with an override on the bundle plugin (AFK) Gary On Tue, Jun 16, 2020, 15:10 sebb wrote: > On Tue, 16 Jun 2020 at 19:41, Gary Gregory wrote: > > > > FYI Commons Lang builds on Java 15 EA OK now. > > Which CP is it using? > > Does it build OK with CP 51-SNAPSHOT? > > > Gary > > > > O

Re: [commons-parent] branch master updated: Update to latest plugins

2020-06-16 Thread sebb
On Tue, 16 Jun 2020 at 19:41, Gary Gregory wrote: > > FYI Commons Lang builds on Java 15 EA OK now. Which CP is it using? Does it build OK with CP 51-SNAPSHOT? > Gary > > On Tue, Jun 16, 2020, 09:49 Xeno Amess wrote: > > > Hi. > > commons.build-helper's latest version is 3.1.0 > > should we up

Re: [commons-net] branch master updated: Fix Javadoc complaint

2020-06-16 Thread Gary Gregory
We should strive to create clean Javadocs that pass doclint. See also https://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html?m=1 Gary On Tue, Jun 16, 2020, 12:07 sebb wrote: > On Tue, 16 Jun 2020 at 16:57, Xeno Amess wrote: > > > > > Is Javadoc HTML? > > yep it is. > > But li

Re: About binary compatibility

2020-06-16 Thread Jochen Wiedmann
On Tue, Jun 16, 2020 at 1:07 AM Gary Gregory wrote: > I kind of like inaging1 even if it is weird and even though we do not have > a precedent here in Commons. I'm curious what others think. I'm always in favour of saving characters. So, let's avoid the additional 1. It is not strictly necessary

Re: [commons-parent] branch master updated: Update to latest plugins

2020-06-16 Thread Gary Gregory
FYI Commons Lang builds on Java 15 EA OK now. Gary On Tue, Jun 16, 2020, 09:49 Xeno Amess wrote: > Hi. > commons.build-helper's latest version is 3.1.0 > should we upgrade it also? > > btw, if you want to release a new version of parent I would +1 here. > And I think we can use the new version

Re: [commons-net] branch master updated: Fix Javadoc complaint

2020-06-16 Thread sebb
On Tue, 16 Jun 2020 at 16:57, Xeno Amess wrote: > > > Is Javadoc HTML? > yep it is. > But like I said I hate HTML for allowing people not to close tags. > In many ways I'd prefer XHTML. > > > Fixing the tags will be a lot of work. > Actually not that lot... > Give me several hours and I can clean

Re: [commons-net] branch master updated: Fix Javadoc complaint

2020-06-16 Thread Xeno Amess
> Is Javadoc HTML? yep it is. But like I said I hate HTML for allowing people not to close tags. In many ways I'd prefer XHTML. > Fixing the tags will be a lot of work. Actually not that lot... Give me several hours and I can clean them all... But I'd prefer listening about others' opinions first.

Re: [commons-net] branch master updated: Fix Javadoc complaint

2020-06-16 Thread sebb
On Tue, 16 Jun 2020 at 16:28, Xeno Amess wrote: > > It really can according to html. > But -1 for doing so. > btw that is why I hate html. Is Javadoc HTML? AFAIK there are a lot of Commons Javadoc with unclosed tags. So long as the generated docs look OK, I don't see any reason to spend any ti

Re: [commons-net] branch master updated: Fix Javadoc complaint

2020-06-16 Thread Xeno Amess
It really can according to html. But -1 for doing so. btw that is why I hate html. sebb 于2020年6月16日周二 下午11:25写道: > On Tue, 16 Jun 2020 at 14:28, Gary Gregory wrote: > > > > On Tue, Jun 16, 2020 at 8:53 AM wrote: > > > > > This is an automated email from the ASF dual-hosted git repository. > >

Re: [commons-net] branch master updated: Fix Javadoc complaint

2020-06-16 Thread sebb
On Tue, 16 Jun 2020 at 14:28, Gary Gregory wrote: > > On Tue, Jun 16, 2020 at 8:53 AM wrote: > > > This is an automated email from the ASF dual-hosted git repository. > > > > sebb pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/commons-net.git > > > > > > Th

Re: [commons-parent] branch master updated: Update to latest plugins

2020-06-16 Thread sebb
On Tue, 16 Jun 2020 at 14:49, Xeno Amess wrote: > > Hi. > commons.build-helper's latest version is 3.1.0 > should we upgrade it also? Can do. > btw, if you want to release a new version of parent I would +1 here. > And I think we can use the new version of parent to make lang can build on > java

Re: [commons-parent] branch master updated: Update to latest plugins

2020-06-16 Thread Xeno Amess
Hi. commons.build-helper's latest version is 3.1.0 should we upgrade it also? btw, if you want to release a new version of parent I would +1 here. And I think we can use the new version of parent to make lang can build on java-ea. Thus the release plan of lang 3.11 should be delayed to after the r

Re: [commons-net] branch master updated: Fix Javadoc complaint

2020-06-16 Thread Gary Gregory
On Tue, Jun 16, 2020 at 8:53 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-net.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [commons-parent] branch master updated: Update to latest plugins

2020-06-16 Thread sebb
I was thinking of that, however I don't know how to do the Git tagging properly On Tue, 16 Jun 2020 at 13:37, Gary Gregory wrote: > > Thanks Sebb! > > Do you feel like pushing out a release of commons-parent? > > Gary > > On Tue, Jun 16, 2020 at 8:10 AM wrote: > > > This is an automated email fr

Re: [commons-parent] branch master updated: Update to latest plugins

2020-06-16 Thread Gary Gregory
Thanks Sebb! Do you feel like pushing out a release of commons-parent? Gary On Tue, Jun 16, 2020 at 8:10 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-parent.

Re: [geometry] Transition from PolyhedronSet to ??? (RegionBSPTree3D ?)

2020-06-16 Thread Sven Rathgeber
Hi Matt, > 2. Yes, the LinecastPoint3D object that you get from linecasting contains the intersection point as well as the surface normal at the point of intersection. thanks - that did the job and I could do the whole refactoring, but the tests fail. We used the PolyHedronsSet to model non-con