Re: [all] How PRs could be better

2020-02-20 Thread Matt Sicker
Let's just say if you can manage to generically solve this problem, you should be nominated for the programming equivalent of a Nobel. On Thu, 20 Feb 2020 at 10:36, Xu Jin wrote: > > It is hard for github to detect what code is test... > Not all players follows the rule to puting tests into /test

回复: [all] How PRs could be better

2020-02-20 Thread Xu Jin
It is hard for github to detect what code is test... Not all players follows the rule to puting tests into /test/java... If you really want this feature maybe we shall write a maven plugin for loading tests from other version of a same project. 发件人: Gary Gregory

[all] How PRs could be better

2020-02-20 Thread Gary Gregory
Hi All: I wonder if any of you have an ideas regarding the following. When looking at _some_ PRs (that are green on GitHub, build with tests and other checks passing, able merge OK), I like to apply only the test changes locally and verify that the main code fails. Then I continue my evaluation.