[VOTE][RESULT] Release Apache Commons Pool 2.8.0 based on RC1

2019-12-10 Thread Gary Gregory
This VOTE passes with 3 binding votes and 1 non-binding vote: - Rob Tompkins - binding - Bruno P. Kinoshita - binding - Gary Gregory - binding - Phil Steitz - non-binding Gary On Tue, Dec 10, 2019 at 3:29 PM Phil Steitz wrote: > +1 (nonbinding) > > Checked build, sigs, reviewed changelog, rele

Re: [VOTE] Release Apache Commons Pool 2.8.0 based on RC1

2019-12-10 Thread Gary Gregory
May I get additional reviews from PMC members please? Gary On Tue, Dec 10, 2019 at 3:29 PM Phil Steitz wrote: > +1 (nonbinding) > > Checked build, sigs, reviewed changelog, release notes and ran my soak > tests. All looks good to me. > > Thanks, Gary! > > Phil > > On 12/10/19 7:57 AM, Gary Gre

Re: [VOTE] Release Apache Commons Pool 2.8.0 based on RC1

2019-12-10 Thread Phil Steitz
+1 (nonbinding) Checked build, sigs, reviewed changelog, release notes and ran my soak tests.  All looks good to me. Thanks, Gary! Phil On 12/10/19 7:57 AM, Gary Gregory wrote: My +1 Gary On Sat, Dec 7, 2019 at 6:09 PM Gary Gregory wrote: We have fixed a few bugs and provided enhanceme

Re: [numbers] Complex vs. reference current performance

2019-12-10 Thread Alex Herbert
> On 10 Dec 2019, at 17:22, Eric Barnhill wrote: > > Thank you for this great work. To the extent I implemented some of the > missing trig functions in Complex, I followed the implementations in > Complex.js , which seemed well worked out and supported. However I am sure > Boost would be much b

Re: [numbers] Complex vs. reference current performance

2019-12-10 Thread Eric Barnhill
Thank you for this great work. To the extent I implemented some of the missing trig functions in Complex, I followed the implementations in Complex.js , which seemed well worked out and supported. However I am sure Boost would be much better engineered still. So +1 On Tue, Dec 10, 2019 at 7:42 AM

[numbers] Complex vs. reference current performance

2019-12-10 Thread Alex Herbert
The latest round of fixes on Complex have made it fully C99 compliant for a range of -5 to +5 in the real and imaginary components. I have yet to finish the testing of overflow/underflow conditions. Here I report on the standard range data. I have updated the test of Complex to load test data

Re: [collection] NPE vs IAE in org.apache.commons.collections4.CollectionUtils

2019-12-10 Thread Gary Gregory
FTR, using requireNonNull is also an 'Effective Java' recommendation. Gary On Thu, Dec 5, 2019 at 4:54 PM Bruno P. Kinoshita wrote: > +1 for NPE > > On Friday, 6 December 2019, 5:22:34 am NZDT, Gary Gregory < > garydgreg...@gmail.com> wrote: > > Hi All: > > org.apache.commons.collections4

Re: [VOTE] Release Apache Commons Pool 2.8.0 based on RC1

2019-12-10 Thread Gary Gregory
My +1 Gary On Sat, Dec 7, 2019 at 6:09 PM Gary Gregory wrote: > We have fixed a few bugs and provided enhancements since Apache Commons > Pool 2.7.0 was released, so I would like to release Apache Commons Pool > 2.8.0. > > Apache Commons Pool 2.8.0 RC1 is available for review here: > https: