Re: [collection] NPE vs IAE in org.apache.commons.collections4.CollectionUtils

2019-12-05 Thread Bruno P. Kinoshita
+1 for NPE On Friday, 6 December 2019, 5:22:34 am NZDT, Gary Gregory wrote: Hi All: org.apache.commons.collections4.CollectionUtils contains a mix of checking for null inputs by throwing NullPointerExceptions in some methods and IllegalArgumentExceptions in others. I propose we stand

Re: [collection] NPE vs IAE in org.apache.commons.collections4.CollectionUtils

2019-12-05 Thread Matt Sicker
+1 for NPE. New Java versions are supposed to even auto generate useful error messages for them, too. On Thu, Dec 5, 2019 at 10:22 Gary Gregory wrote: > Hi All: > > org.apache.commons.collections4.CollectionUtils contains a mix of checking > for null inputs by throwing NullPointerExceptions in s

[general] Phishing emails mentioning Apache coming in after pull request submitted

2019-12-05 Thread Eric Barnhill
Some unsavory types are watching Apache activity. I submitted my first Apache PR in a long time yesterday, by morning I had two phishing emails mentioning Apache in both subject and body at the relevant email address. I hope the community is aware of this issue? I don't recall this happening even

[collection] NPE vs IAE in org.apache.commons.collections4.CollectionUtils

2019-12-05 Thread Gary Gregory
Hi All: org.apache.commons.collections4.CollectionUtils contains a mix of checking for null inputs by throwing NullPointerExceptions in some methods and IllegalArgumentExceptions in others. I propose we standardized to NPE simply because the JRE provides Objects.requireNonNull() just for this pur

Re: [Collections]Several PRs on github need reviews

2019-12-05 Thread Gary Gregory
Chen, Thank you for you contributions and patience. I'll take a look over the next few days... Gary On Mon, Dec 2, 2019 at 3:48 AM Chen Guoping1 wrote: > Hi all, > > I'm Chen and I'm new to commons-collections. I like commons-collections > cause it provides > many useful data structures. I'd l