Re: [commons-numbers] 04/04: Preserve even function in cosh

2019-12-04 Thread Alex Herbert
> On 5 Dec 2019, at 01:39, Gilles Sadowski wrote: > > Test failure here: > ---CUT--- > ERROR] Failures: > [ERROR] CStandardTest.testCosh:692->assertComplex:275 Operation > failed (z=(-Infinity,0.5)). Expected: (-Infinity,-Infinity) but was: > (Infinity,-Infinity) > —CUT— > Sorry. I thought

Re: [commons-numbers] 04/04: Preserve even function in cosh

2019-12-04 Thread Gilles Sadowski
Test failure here: ---CUT--- ERROR] Failures: [ERROR] CStandardTest.testCosh:692->assertComplex:275 Operation failed (z=(-Infinity,0.5)). Expected: (-Infinity,-Infinity) but was: (Infinity,-Infinity) ---CUT--- Gilles 2019-12-05 1:45 UTC+01:00, aherb...@apache.org : > This is an automated email

Re: [Numbers] Towards a release?

2019-12-04 Thread Alex Herbert
> On 4 Dec 2019, at 19:06, Eric Barnhill wrote: > > NUMBERS-136 was a pretty simple fix, I don't think it will interfere with > anything, so I submitted a PR anyway. Close it if you prefer but I think it > will be easy to integrate. > > Gilles, I saw no way to request you as reviewer, so only

Re: [Numbers] Towards a release?

2019-12-04 Thread Eric Barnhill
NUMBERS-136 was a pretty simple fix, I don't think it will interfere with anything, so I submitted a PR anyway. Close it if you prefer but I think it will be easy to integrate. Gilles, I saw no way to request you as reviewer, so only requested Alex. On Tue, Dec 3, 2019 at 3:37 PM Alex Herbert wr