Re: [RNG] LGTM analysis (Was: [...] branch master updated: Badge.)

2019-10-24 Thread sebb
On Thu, 24 Oct 2019 at 16:36, Alex Herbert wrote: > > > > > On 24 Oct 2019, at 16:23, Gilles Sadowski wrote: > > > > Hello. > > > > "Commons RNG" page on GitHub[1] now links to the LGTM report[2]. > > > > Unfortunately, the one "alert" there[3] is a false positive. > > Perhaps, we could make it g

Re: [RNG] LGTM analysis (Was: [...] branch master updated: Badge.)

2019-10-24 Thread Alex Herbert
> On 24 Oct 2019, at 16:23, Gilles Sadowski wrote: > > Hello. > > "Commons RNG" page on GitHub[1] now links to the LGTM report[2]. > > Unfortunately, the one "alert" there[3] is a false positive. > Perhaps, we could make it go away by rewriting the "while" loop > as a "for" loop... (or chang

[RNG] LGTM analysis (Was: [...] branch master updated: Badge.)

2019-10-24 Thread Gilles Sadowski
Hello. "Commons RNG" page on GitHub[1] now links to the LGTM report[2]. Unfortunately, the one "alert" there[3] is a false positive. Perhaps, we could make it go away by rewriting the "while" loop as a "for" loop... (or changing the bound to "size - 1"). Regards, Gilles [1] https://github.com/a

Re: Git status update

2019-10-24 Thread sebb
On Thu, 24 Oct 2019 at 12:54, Emmanuel Bourg wrote: > > Le 24/10/2019 à 12:54, sebb a écrit : > > > Without a fixed tag pointing to a commit, AIUI the commit can be > > eliminated through a force push. > > Force pushing a branch doesn't erase the tags along it nor its parent > commits. The commit

Re: Git status update

2019-10-24 Thread Emmanuel Bourg
Le 24/10/2019 à 12:54, sebb a écrit : > Without a fixed tag pointing to a commit, AIUI the commit can be > eliminated through a force push. Force pushing a branch doesn't erase the tags along it nor its parent commits. The commit and the tag still exist in the repository. > That is deliberate,

Re: Git status update

2019-10-24 Thread sebb
On Thu, 24 Oct 2019 at 09:28, Emmanuel Bourg wrote: > > Le 09/09/2019 à 17:29, Gary Gregory a écrit : > > > What I meant is that, when we successfully create a release, then the > > release tag should go under 'rel/' instead of ''. Sorry for the > > misunderstanding. > > If the vote mail mentions

Re: Git status update

2019-10-24 Thread Emmanuel Bourg
Le 09/09/2019 à 17:29, Gary Gregory a écrit : > What I meant is that, when we successfully create a release, then the > release tag should go under 'rel/' instead of ''. Sorry for the > misunderstanding. If the vote mail mentions the tag name and the commit hash I don't see the need to use read-o