Re: github karma

Thanks, Seb.  I was trying to merge a contributor's PR using the github gui.  I assumed that being unable to do that means I don't have karma to push.   I will try later via the command line. Phil On 9/23/19 5:11 PM, sebb wrote: On Tue, 24 Sep 2019 at 00:16, Phil Steitz wrote: I am set up,

Re: github karma

On Tue, 24 Sep 2019 at 00:16, Phil Steitz wrote: > > I am set up, but still can't seem to merge PRs. Is there some > commons-specific thing that has to be done? I used to be able to push > to at least [math] but I guess perms got changed since I last committed. What URL are you using? I find gi

Re: [rng] Documenting JumpableUniformRandomProvider

Hi. Le lun. 23 sept. 2019 à 22:38, Alex Herbert a écrit : >>> [...] > > > isLongJumpable() > > isJumpable() > > I’ve put these methods into a PR for RNG-116 [1]. > > I’ve also added: > > public int getSeedByteSize() > > However I note that the RandomSource has factory methods to create int[] and

Re: github karma

I am set up, but still can't seem to merge PRs.  Is there some commons-specific thing that has to be done?  I used to be able to push to at least [math] but I guess perms got changed since I last committed. Phil On 9/22/19 8:54 AM, Gary Gregory wrote: Hi Phil, Login to https://id.apache.org

Re: New Sub-project Proposal.

On Mon, 23 Sep 2019 at 20:18, Claude Warren wrote: > > > At first sight, I'd say that serialization is out-of-scope (we > > should let application developers deal with that using the > > available accessors). > > How does one serialize a bloom filter if to do so you need to implement the > private

Re: [rng] Documenting JumpableUniformRandomProvider

> On 21 Sep 2019, at 19:40, Alex Herbert wrote: > > > >> On 21 Sep 2019, at 17:46, Gilles Sadowski > > wrote: >> >> Hello. >> >> [...] >> >>> >>> 2. Add a method BitSet getSupport() to the RandomSource enum, where T >>> is an enum that can

Re: New Sub-project Proposal.

> At first sight, I'd say that serialization is out-of-scope (we > should let application developers deal with that using the > available accessors). How does one serialize a bloom filter if to do so you need to implement the private Object writeReplace() method? A list of proto bloom filters is

Re: New Sub-project Proposal.

Hi. Le lun. 23 sept. 2019 à 12:59, Claude Warren a écrit : > > I will rework to remove the package private and other access issues noted. > > In Builder there is a difference between with() and build(). This follows > the pattern established by MessageDigest[1] where it is possible to build a >

Re: Advice on project logo

Le lun. 23 sept. 2019 à 15:31, Rob Tompkins a écrit : > > My thunderbird install didn’t properly handle Kenneth and Sally in the CC > here. Adding them so that they can hear the conversation. What conversation? Many of the below messages were not sent to this ML. Where are the proposals? Gilles

Re: Advice on project logo

My thunderbird install didn’t properly handle Kenneth and Sally in the CC here. Adding them so that they can hear the conversation. -Rob > On Sep 23, 2019, at 9:29 AM, Rob Tompkins wrote: > > Hey folks, > > > > I think that what Kenneth has provided here is worth adding to the > Jirath

Re: New Sub-project Proposal.

On 23/09/2019 11:13, Claude Warren wrote: For the style issues is there an Eclipse style package that meets the commons style or some other tool that will correctly configure the format and style options in Eclipse? The Commons style across most projects is loosely based on the Java coding

Re: New Sub-project Proposal.

I will rework to remove the package private and other access issues noted. In Builder there is a difference between with() and build(). This follows the pattern established by MessageDigest[1] where it is possible to build a digest in one call or by adding multiple items and then calling digest.

Re: New Sub-project Proposal.

For the style issues is there an Eclipse style package that meets the commons style or some other tool that will correctly configure the format and style options in Eclipse? On Mon, Sep 23, 2019 at 10:54 AM Gilles Sadowski wrote: > Hello. > > Here are a few comment from a quick browse of tod

Re: New Sub-project Proposal.

Hello. Here are a few comment from a quick browse of today's update of PR #83. * "package private for testing" is not a good reason (IMO) * There are spurious blank spaces in some of the file ("git diff" shows them in red) * You should always perform "git rebase master" * In "Builder": ** Field "