On Wed, Sep 4, 2019 at 4:51 PM Xeno Amess wrote:
> Well, if you do think repeating the similar codes for 100+ times is
> better than reflection and be more elegant or easier to read or
> something, then you can try maintain them.
> There is 100+ Throwable classes who have string constructor in JD
Well, if you do think repeating the similar codes for 100+ times is
better than reflection and be more elegant or easier to read or
something, then you can try maintain them.
There is 100+ Throwable classes who have string constructor in JDK IMO.
And don't forget some of them might only be in some
On Wed, Sep 4, 2019 at 8:34 AM Xeno Amess wrote:
> No I still don't think it a good idea to have such a util class.
> 1. most Throwable classes, they all have a constructor with a String.
> 2. IllegalArgumentException is not special in this way.
> 3. If we make a public Util class for IllegalArgu
That Builder can throw an unexpected exception if you forget to call
withFormat, because the format and args remain null.
Regarding the reflection code, the null checks are unnecessary.
getDeclaredConstructor cannot return null, it throws an exception
instead if the constructor cannot be found
I believe Commons was contacted directly with this due to past
participation in GSoC. Otherwise, we’ve emailed committers@ along with some
specific lists related to GSoC and Outreachy.
On Wed, Sep 4, 2019 at 06:44, Gilles Sadowski wrote:
> Le mar. 3 sept. 2019 à 23:48, Matt Sicker a écrit :
> >
Le mer. 4 sept. 2019 à 14:34, Xeno Amess a écrit :
>
> No I still don't think it a good idea to have such a util class.
> 1. most Throwable classes, they all have a constructor with a String.
> 2. IllegalArgumentException is not special in this way.
For a library such as [Lang], that seems quite
No I still don't think it a good idea to have such a util class.
1. most Throwable classes, they all have a constructor with a String.
2. IllegalArgumentException is not special in this way.
3. If we make a public Util class for IllegalArgumentException, then
we shall make similar public Util class
Le mar. 3 sept. 2019 à 23:48, Matt Sicker a écrit :
>
> Well, if anyone has project ideas or would like to mentor, then yes.
> I'm avoiding mentoring this round since I'm a coordinator, though I
> might be mentoring for a Jenkins project anyways.
We (Alex, Eric, Rob and I) tried something with GS
Hi.
Le mer. 4 sept. 2019 à 02:53, Gary Gregory a écrit :
>
> Here is the PR with [lang]'s own call sites updated to use the new code.
>
> Gary
>
> On Tue, Sep 3, 2019 at 2:13 PM Gary Gregory wrote:
>
> > On Tue, Sep 3, 2019 at 1:19 PM Rob Spoor wrote:
> >
> >> Why limit this to IllegalArgument?
