Re: [LANG-1478] Do we need to wait for a major release for this one?

2019-08-24 Thread James Carman
In fact, you don’t even need to change the minor version (assuming this is the only thing being done). You can just do a “point release”, changing only the third digit, or 3.9.1 On Sat, Aug 24, 2019 at 9:43 PM Bruno P. Kinoshita wrote: > I think it makes sense, good to go with 3.x then. Thanks

Re: [LANG-1478] Do we need to wait for a major release for this one?

2019-08-24 Thread Bruno P. Kinoshita
I think it makes sense, good to go with 3.x then. Thanks sebb! On Sunday, 25 August 2019, 1:35:41 pm NZST, sebb wrote: On Sun, 25 Aug 2019 at 00:57, Bruno P. Kinoshita wrote: > >  Sorry, wrong PR [1] link: https://github.com/apache/commons-lang/pull/445/ >    On Sunday, 25 August 2019,

Re: [LANG-1478] Do we need to wait for a major release for this one?

2019-08-24 Thread sebb
On Sun, 25 Aug 2019 at 00:57, Bruno P. Kinoshita wrote: > > Sorry, wrong PR [1] link: https://github.com/apache/commons-lang/pull/445/ > On Sunday, 25 August 2019, 11:51:47 am NZST, Bruno P. Kinoshita > wrote: > > Hi, > In LANG-1478, a contributor provided a PR for ClassUtils.getAbbreviate

Re: [LANG-1478] Do we need to wait for a major release for this one?

2019-08-24 Thread Bruno P. Kinoshita
Sorry, wrong PR [1] link: https://github.com/apache/commons-lang/pull/445/ On Sunday, 25 August 2019, 11:51:47 am NZST, Bruno P. Kinoshita wrote: Hi, In LANG-1478, a contributor provided a PR for ClassUtils.getAbbreviatedName. If you have a class name with 10 characters (e.g. "ab.de.Ghi

[LANG-1478] Do we need to wait for a major release for this one?

2019-08-24 Thread Bruno P. Kinoshita
Hi, In LANG-1478, a contributor provided a PR for ClassUtils.getAbbreviatedName. If you have a class name with 10 characters (e.g. "ab.de.Ghij"), and calls the method getAbbreviatedName passing the length argument of 10, you get a 9 characters long string back "a.de.Ghij". The Javadoc for the len

Re: [VOTE] Release Compress 1.19 Based on RC1

2019-08-24 Thread Bruno P. Kinoshita
 [X] +1 Release these artifacts Build passing with `mvn clean test install site` on Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_222, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk

Re: [VOTE] Release Compress 1.19 Based on RC1

2019-08-24 Thread Gary Gregory
+1 >From git tag: - Apache RAT check OK. - Apache CLIRR check OK. - Release notes typo "can not" -> "cannot". - Build with 'mvn clean install site -P jacoco -P japicmp' OK using: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache

[VOTE] Release Compress 1.19 Based on RC1

2019-08-24 Thread Stefan Bodewig
It's been more than a year since the last release of Commons Compress and it is about time to get the fixes and enhancements out of the door. Compress 1.19 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 35357) The tag is here: ht

JDK 13 is now in the Release Candidate Phase & JDK 14 build 11 is available.

2019-08-24 Thread Rory O'Donnell
Hi Benedikt, *JDK 13 is now in the Release Candidate Phase * Per the JDK 13 schedule [1], we are now in the Release Candidate phase. The stabilization repository, jdk/jdk13, is open for P1 bug fixes per the JDK Release Process (JEP 3) [2]. All changes require approval via the Fix-Request Proce