Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-20 Thread Matt Juntunen
Gilles, ConvexSubPlane is the main class representing 3D facets. There are convenience methods in the RegionBSPTree3D.Builder class for adding facets directly from vertices since that's the most common way to represent them. These methods ultimately end up creating ConvexSubPlane instances, eit

Re: MATH-1494 Non-iterative Exponential Fitting

2019-08-20 Thread Gilles Sadowski
Hi. Le mar. 20 août 2019 à 17:38, Tom Prodehl a écrit : > > The proposed contribution does not fit within the current design of > theo.a.c.m.fittingpackage. > The radically different approach to estimate the parameters makes it > unsuitable to simply drop it there. > > Design decisions >

MATH-1494 Non-iterative Exponential Fitting

2019-08-20 Thread Tom Prodehl
The proposed contribution does not fit within the current design of theo.a.c.m.fittingpackage. The radically different approach to estimate the parameters makes it unsuitable to simply drop it there. Design decisions must ha

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-20 Thread Gilles Sadowski
Hello. Le lun. 19 août 2019 à 05:14, Matt Juntunen a écrit : > > Hi Gilles, > > I did intend on adding more convenience methods for generating standard > shapes but I definitely think we should abstract it like you're suggesting. > Your design got me thinking and I believe we could take the ide

[collections]A potential typo in the code's comment

2019-08-20 Thread XiangzheXu
Hi, I was wondering whether there’s a typo in the @throws IndexOutOfBoundsException condition for the setIterator(final int index, final Iterator iterator) method in the class org.apache.commons.collections4.iterators.CollatingIterator. The method and its Javadoc comment are shown as follows.