Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-16 Thread Matt Juntunen
Hi Gilles, 1. I just rebased from master so hopefully that fixed the repo weirdness. 2. The best place to start working with the new code is probably the RegionBSPTreeXD classes. These are the replacements for the old IntervalsSet, PolygonsSet, and PolyhedronsSet classes. I'm including a s

Re: [compress] Need Feedback for COMPRESS-479

2019-08-16 Thread Stefan Bodewig
On 2019-08-14, Matt Sicker wrote: > Yes, I think you understand us. A strategy pattern with default sensible > strategies to choose. Done now. I'm going to tweak the implementation a little more but the API of ExtraFieldParsingBehavior seems to work quite well. Thanks Stefan -

Re: Fix for the ArrayIndexOutOfBoundsException on calling NaturalRanking#rank() on an array of all NaNs

2019-08-16 Thread Gilles Sadowski
Le ven. 16 août 2019 à 17:25, Alex Herbert a écrit : > > > > > On 16 Aug 2019, at 16:06, Gilles Sadowski wrote: > > > > Hello. > > > > Le jeu. 15 août 2019 à 11:33, akash srivastava a > > écrit : > >> > >> Here is the link for the related bug: > >> https://issues.apache.org/jira/browse/MATH-149

Re: [geometry] GEOMTRY-32 Feedback Requested

2019-08-16 Thread Gilles Sadowski
Hello Matt. Thanks for continuing to work on this. Le jeu. 15 août 2019 à 17:56, Matt Juntunen a écrit : > > Hi all, > > I've been working on the BSP tree refactor and general API cleanup for a > while now and I finally have the core and Euclidean classes complete. I have > the code in a draft

Re: Fix for the ArrayIndexOutOfBoundsException on calling NaturalRanking#rank() on an array of all NaNs

2019-08-16 Thread Alex Herbert
> On 16 Aug 2019, at 16:06, Gilles Sadowski wrote: > > Hello. > > Le jeu. 15 août 2019 à 11:33, akash srivastava a écrit > : >> >> Here is the link for the related bug: >> https://issues.apache.org/jira/browse/MATH-1495 >> >> I have suggested two possible fixes when NaturalRanking#rank()

Re: Fix for the ArrayIndexOutOfBoundsException on calling NaturalRanking#rank() on an array of all NaNs

2019-08-16 Thread Gilles Sadowski
Hello. Le jeu. 15 août 2019 à 11:33, akash srivastava a écrit : > > Here is the link for the related bug: > https://issues.apache.org/jira/browse/MATH-1495 > > I have suggested two possible fixes when NaturalRanking#rank() is called on > an array of all NaNs: > 1) throwing an IllegalArgumentExcep