[GSoC] Required assignment for July 22nd milestone

2019-07-17 Thread Eric Barnhill
Phase 2 Evals are coming up starting July 22nd. For this eval we will be emphasizing the necessity for the mentees to submit code on the same quality level as typical commons contributors; let's get to a small amount of code that is production-level. We therefore present the following assignment f

Re: [numbers-fraction] Double approximation constructor/factory method overhaul

2019-07-17 Thread Heinrich Bohne
It just occured to me that you might have misunderstood my sentence: I am even more confused by your suggestion seeing as it was you who banned BigInteger from Fraction.addSub(Fraction, boolean) in https://issues.apache.org/jira/browse/NUMBERS-79  , which, even though you were not aware of it at

Re: [numbers-fraction] Double approximation constructor/factory method overhaul

2019-07-17 Thread Heinrich Bohne
The reason it was done was because Knuth proved (as in mathematical proof) that a long is insufficient for certain fraction multiplications where both numerator and denominator are large ints; 65 rather than 64 bits are necessary and a long will not suffice. You seem to have missed my comment in