[GitHub] coveralls edited a comment on issue #62: IO-578: Support java.nio.Path and non-default file systems for ReversedLinesFileReader

coveralls edited a comment on issue #62: IO-578: Support java.nio.Path and non-default file systems for ReversedLinesFileReader URL: https://github.com/apache/commons-io/pull/62#issuecomment-393731222 [](https://coveralls.io

[GitHub] coveralls edited a comment on issue #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

coveralls edited a comment on issue #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#issuecomment-467565691 [](https://coveralls.io/builds/21886364) Cover

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260927842 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r26092 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] mches edited a comment on issue #62: IO-578: Support java.nio.Path and non-default file systems for ReversedLinesFileReader

mches edited a comment on issue #62: IO-578: Support java.nio.Path and non-default file systems for ReversedLinesFileReader URL: https://github.com/apache/commons-io/pull/62#issuecomment-434504566 Squashed and rebased onto latest master -

[GitHub] mches commented on issue #62: IO-578: Support java.nio.Path and non-default file systems for ReversedLinesFileReader

mches commented on issue #62: IO-578: Support java.nio.Path and non-default file systems for ReversedLinesFileReader URL: https://github.com/apache/commons-io/pull/62#issuecomment-467976126 Rebased onto latest master This is

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260869818 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java ##

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260868918 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java ##

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260868918 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java ##

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260867964 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java ##

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260867481 ## File path: src/test/java/org/apache/commons/text/similarity/SorensenDicesSimilarityTest.java ##

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260866952 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java ##

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260867021 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java ##

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260866733 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java ##

[GitHub] garydgregory commented on issue #30: [CSV-226] Add CSVParser test case for standard charsets.

garydgregory commented on issue #30: [CSV-226] Add CSVParser test case for standard charsets. URL: https://github.com/apache/commons-csv/pull/30#issuecomment-467914564 Hi @aeschwabe, May you please rebase this PR on master so that conflicts are resolved? Thank you, Gary --

[GitHub] asfgit closed pull request #39: [CSV-238] Escape quotes in CLOBs

asfgit closed pull request #39: [CSV-238] Escape quotes in CLOBs URL: https://github.com/apache/commons-csv/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] garydgregory commented on issue #30: Seems a trivial change to me, should I create a Jira?

garydgregory commented on issue #30: Seems a trivial change to me, should I create a Jira? URL: https://github.com/apache/commons-dbcp/pull/30#issuecomment-467872978 You can also then update the `changes.xml` file. This is an

[GitHub] garydgregory commented on issue #30: Seems a trivial change to me, should I create a Jira?

garydgregory commented on issue #30: Seems a trivial change to me, should I create a Jira? URL: https://github.com/apache/commons-dbcp/pull/30#issuecomment-467872836 @JacquesLeRoux Thank you for your patch. Yes, we need a JIRA for changes like this. While you are at

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260720252 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260712894 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260711148 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] JacquesLeRoux commented on issue #30: Seems a trivial change to me, should I create a Jira?

JacquesLeRoux commented on issue #30: Seems a trivial change to me, should I create a Jira? URL: https://github.com/apache/commons-dbcp/pull/30#issuecomment-467826354 Oops, this merge fixes a typo (missed a comma :/) This is

[GitHub] JacquesLeRoux opened a new pull request #30: Seems a trivial change to me, should I create a Jira?

JacquesLeRoux opened a new pull request #30: Seems a trivial change to me, should I create a Jira? URL: https://github.com/apache/commons-dbcp/pull/30 In OFBiz we implemented DebugManagedDataSource http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/ja

[GitHub] aherbert commented on issue #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

aherbert commented on issue #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#issuecomment-467821107 Hi @ameyjadiye. Thanks for the contribution. I've had a look at this similarity as it is essentially a binary scoring metric: