[crypto] Implementing HMAC and CMAC

2019-02-21 Thread Alex Remily
Team, What do you think about adding HMAC and CMAC functionality to commons crypto? I have a project I'd like to use it for, so I don't mind working on the implementation, but I don't want to make the effort if there's no support for the idea. Thoughts? Alex

[GitHub] luyseyal commented on issue #39: [CSV-234] Enable escaping of quotes in CLOBs

2019-02-21 Thread GitBox
luyseyal commented on issue #39: [CSV-234] Enable escaping of quotes in CLOBs URL: https://github.com/apache/commons-csv/pull/39#issuecomment-466009900 @britter Can you review this? Gary's code in master does fix the general idea behind outputting CLOBs but it doesn't escape quotes embedde

[GitHub] kinow commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report

2019-02-21 Thread GitBox
kinow commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report URL: https://github.com/apache/commons-text/pull/102#issuecomment-465915589 >The magic numbers probably could be resolved by adding: I am not sure if Checkstyle issues are a blocker f

[GitHub] jmkeil commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report

2019-02-21 Thread GitBox
jmkeil commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report URL: https://github.com/apache/commons-text/pull/102#issuecomment-465908787 The magic numbers probably could be resolved by adding: ```java private final static int COMMON_PREFIX_LENG

[GitHub] kinow commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report

2019-02-21 Thread GitBox
kinow commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report URL: https://github.com/apache/commons-text/pull/102#issuecomment-465900565 Yeah, not too sure what to do about these checkstyle errors. They were already in the project before... then I fi

[GitHub] PascalSchumacher commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report

2019-02-21 Thread GitBox
PascalSchumacher commented on issue #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report URL: https://github.com/apache/commons-text/pull/102#issuecomment-465899574 >[INFO] There are 5 errors reported by Checkstyle 8.17 with /home/travis/build/apache/commons-text/che