Re: [VOTE] Release Apache Commons Pool 2.6.1 based on RC2

2019-02-12 Thread Rob Tompkins
+1 > On Feb 12, 2019, at 9:03 AM, Gary Gregory wrote: > > My +1 > > Gary > >> On Sat, Feb 9, 2019 at 2:10 PM Gary Gregory wrote: >> >> We have fixed quite a few bugs and added some significant enhancements >> since Apache Commons Pool 2.6.0 was released, so I would like to release >> Apache

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread Marcelo Vanzin
On Tue, Feb 12, 2019 at 5:03 PM sebb wrote: > > Interesting, never seen that. Even just looked at one of my forks and > > couldn't find it... > > It appears when I click on branches. > This shows Overview/Yours/Active/Stale/All branches Ah, I see. Guess I've never used that view. IMO it doesn't

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread sebb
On Wed, 13 Feb 2019 at 00:47, Marcelo Vanzin wrote: > > On Tue, Feb 12, 2019 at 4:44 PM sebb wrote: > > > > On Wed, 13 Feb 2019 at 00:31, Marcelo Vanzin > > wrote: > > > > > > On Tue, Feb 12, 2019 at 4:25 PM sebb wrote: > > > > It's shown as one of 'my' branches, but I guess I can live with tha

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread Marcelo Vanzin
On Tue, Feb 12, 2019 at 4:44 PM sebb wrote: > > On Wed, 13 Feb 2019 at 00:31, Marcelo Vanzin > wrote: > > > > On Tue, Feb 12, 2019 at 4:25 PM sebb wrote: > > > It's shown as one of 'my' branches, but I guess I can live with that. > > > > Not sure what you mean by that? > > GitHub lists the resto

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread sebb
On Wed, 13 Feb 2019 at 00:31, Marcelo Vanzin wrote: > > On Tue, Feb 12, 2019 at 4:25 PM sebb wrote: > > It's shown as one of 'my' branches, but I guess I can live with that. > > Not sure what you mean by that? GitHub lists the restored branch under the tab 'Yours', along with a couple of branche

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread Marcelo Vanzin
On Tue, Feb 12, 2019 at 4:25 PM sebb wrote: > It's shown as one of 'my' branches, but I guess I can live with that. Not sure what you mean by that? The branches in your fork don't really have any relation to the original repo. They may have the same name and even reference the same commit, but y

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread sebb
On Wed, 13 Feb 2019 at 00:08, Marcelo Vanzin wrote: > > On Tue, Feb 12, 2019 at 3:58 PM sebb wrote: > > Deleted from local and remote. > > But it still exists in the upstream from which the Github repo was forked > > > > It is still in the upstream source - that is a 3rd party repo > > How can I

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread Marcelo Vanzin
On Tue, Feb 12, 2019 at 3:58 PM sebb wrote: > Deleted from local and remote. > But it still exists in the upstream from which the Github repo was forked > > It is still in the upstream source - that is a 3rd party repo > How can I restore it from there? It's easy then: - make sure you have the u

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread sebb
On Tue, 12 Feb 2019 at 22:34, Marcelo Vanzin wrote: > > If: > > - you deleted the branch from the remote > > Just push your local branch to the remote. > > - you deleted the branch from the local repo only > > Just checkout the remote branch again. If you had local changes that > are not in the re

[LANG] DurationUtils pull request

2019-02-12 Thread Aleksander Ściborek
Hi, I've just opened a pull request for class DurationUtils which contains methods for rounding duration Aleksander

Re: [OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread Marcelo Vanzin
If: - you deleted the branch from the remote Just push your local branch to the remote. - you deleted the branch from the local repo only Just checkout the remote branch again. If you had local changes that are not in the remote, continue below. - you deleted the branch from local and it did n

[OT][GIT help] How to restore a branch in a github fork

2019-02-12 Thread sebb
I have a github fork of a 3rd party repo. Unfortunately I deleted a branch for which I wish to provide patches. Anyone know how to restore/recreate an upstream branch in a Github fork? I cannot destroy and recreate the fork as it has some outstanding PRs. I suppose I could create a second fork,

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Alex Herbert
commons-parent has an empty profile jdk7-plugin-fix-version that activates for Java 7. I created a similar profile in the parent for commons-rng that activates for Java 8 and moved the checkstyle configuration into there. It now works with the latest checkstyle version. So the target remains

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Pascal Schumacher
Am 11.02.2019 um 22:15 schrieb sebb: Aren't there different profiles for different Java versions? There was at least one plugin which needed different versions, so maybe take the same approach here. It's a bit more work to set up the pom, but it saves a lot of work downstream fixing component po

Re: Reply-To settings (was: [vote] fix the misconfiguration of the dev@ mailing list)

2019-02-12 Thread Gilles Sadowski
Hi. Le mar. 12 févr. 2019 à 17:49, Eitan Adler a écrit : > > (please make sure to add me to the CC as the mailing list is presently broken) I confirm that with either "Reply" or "Reply all", the Gmail web interface will *not* add your address to the CC. :-( > On Mon, 11 Feb 2019 at 07:08, sebb

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Gilles Sadowski
Hi. Le mar. 12 févr. 2019 à 11:22, Alex Herbert a écrit : > > If checkstyle 7+ requires Java 8 then this is a blocker for common-rng. > That still supports Java 1.6. This is the target (so that it can *run* on older JRE). But the build/validation tools can well have different requirements. > I

Re: [vote] fix the misconfiguration of the dev@ mailing list

2019-02-12 Thread Mark Thomas
On 12/02/2019 16:26, Eitan Adler wrote: > (please make sure to add me to CC directly as the mailing is presently broken) > On Mon, 11 Feb 2019 at 00:47, Mark Thomas wrote: >> >> -1 >> >> Changing the reply-to configuration increases the chances of message >> threads being moved off-list by acciden

Re: Reply-To settings (was: [vote] fix the misconfiguration of the dev@ mailing list)

2019-02-12 Thread Eitan Adler
(please make sure to add me to the CC as the mailing list is presently broken) On Mon, 11 Feb 2019 at 07:08, sebb wrote: > > On Mon, 11 Feb 2019 at 12:33, Gilles Sadowski wrote: > > > > Le lun. 11 févr. 2019 à 11:16, sebb a écrit : > > > > > > On Mon, 11 Feb 2019 at 09:24, Gilles Sadowski > >

Re: [vote] fix the misconfiguration of the dev@ mailing list

2019-02-12 Thread sebb
On Tue, 12 Feb 2019 at 16:26, Eitan Adler wrote: > > (please make sure to add me to CC directly as the mailing is presently broken) > On Mon, 11 Feb 2019 at 00:47, Mark Thomas wrote: > > > > -1 > > > > Changing the reply-to configuration increases the chances of message > > threads being moved of

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC3

2019-02-12 Thread Eitan Adler
On Sat, 9 Feb 2019 at 05:58, Rob Tompkins wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Codec 1.11 was released, so I would like to release Apache > Commons Codec 1.12. +1 (non-binding) -- Eitan Adler

Re: [ALL] Broken builds

2019-02-12 Thread Matt Sicker
Using something like prow via Jenkins X or similar helps in automating merging PRs after they've been approved and the build has passed. Otherwise, making it a manual process will just cause headaches. On Sun, 10 Feb 2019 at 08:52, Gary Gregory wrote: > > On Sun, Feb 10, 2019 at 9:20 AM Pascal Sc

Re: [vote] fix the misconfiguration of the dev@ mailing list

2019-02-12 Thread Eitan Adler
(please make sure to add me to CC directly as the mailing is presently broken) On Mon, 11 Feb 2019 at 00:47, Mark Thomas wrote: > > -1 > > Changing the reply-to configuration increases the chances of message > threads being moved off-list by accident. I am concerned about the risk > of harm to the

Re: [VOTE] Release Apache Commons Codec 1.12 based on RC3

2019-02-12 Thread Rob Tompkins
Here’s my +1. > On Feb 9, 2019, at 8:58 AM, Rob Tompkins wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Codec 1.11 was released, so I would like to release Apache > Commons Codec 1.12. > > Apache Commons Codec 1.12 RC3 is available for

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Gary Gregory
On Tue, Feb 12, 2019 at 5:22 AM Alex Herbert wrote: > If checkstyle 7+ requires Java 8 then this is a blocker for common-rng. > That still supports Java 1.6. > Java 6? Let's bump that to Java 7 if not 8. Gary > > I did not intend to update commons-parent, only the project. The topic > of the

Re: [VOTE] Release Apache Commons Pool 2.6.1 based on RC2

2019-02-12 Thread Gary Gregory
My +1 Gary On Sat, Feb 9, 2019 at 2:10 PM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Pool 2.6.0 was released, so I would like to release > Apache Commons Pool 2.6.1. > > Apache Commons Pool 2.6.1 RC2 is available for revie

Re: [RNG, ALL] Checkstyle version

2019-02-12 Thread Alex Herbert
If checkstyle 7+ requires Java 8 then this is a blocker for common-rng. That still supports Java 1.6. I did not intend to update commons-parent, only the project. The topic of the parent was introduced just to state that there was no management of checkstyle. The consensus appears to be that c