Re: [VOTE][RC2] Commons collections 4.3

2019-01-30 Thread Maxim Solodovnik
This release need your VOTES :))) On Sun, 27 Jan 2019 at 19:47, Maxim Solodovnik wrote: > Hello All, > > Thanks to the Rob, I was able to create "compatibility report" using > japicmp > It looks green :) > > Would it be OK if I will replace clirr report in generated site with > japicmp report? >

Re: [LANG] Checked Functions PR

2019-01-30 Thread Aleksander Ściborek
Yes i saw https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob_plain;f=src/main/java/org/apache/commons/lang3/Functions.java;h=5eaed0c6fa8dbb8ed7a2ba37d499130ba62f138b;hb=HEAD, unfortunately it was created after I had developed my interfaces. I saw there are some difference, like no metho

Re: [LANG] Checked Functions PR

2019-01-30 Thread Pascal Schumacher
Am 30.01.2019 um 20:27 schrieb Jochen Wiedmann: Have you seen [1]? 1: https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob_plain;f=src/main/java/org/apache/commons/lang3/Functions.java;h=5eaed0c6fa8dbb8ed7a2ba37d499130ba62f138b;hb=HEAD By the way: https://github.com/apache/commons-l

Re: [LANG] Checked Functions PR

2019-01-30 Thread Jochen Wiedmann
On Tue, Jan 29, 2019 at 1:04 AM Aleksander Ściborek wrote: > The idea behind this is that you can create an instance of a function which > throws a checked exception and then using a static method create an > instance of standard function which invocation of a checked functions. Have you seen [1

[GitHub] coveralls commented on issue #19: reformat code & fixed some typo

2019-01-30 Thread GitBox
coveralls commented on issue #19: reformat code & fixed some typo URL: https://github.com/apache/commons-pool/pull/19#issuecomment-459016181 [![Coverage Status](https://coveralls.io/builds/21360279/badge)](https://coveralls.io/builds/21360279) Coverage increased (+0.03%) to 85.2%

[GitHub] liony opened a new pull request #19: reformat code & fixed some typo

2019-01-30 Thread GitBox
liony opened a new pull request #19: reformat code & fixed some typo URL: https://github.com/apache/commons-pool/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[ANNOUNCE] Commons Release Plugin 1.5 released.

2019-01-30 Thread Rob Tompkins
[This announcement is only going to the dev list.] The Apache Commons Release Plugin team is pleased to announce the release of Apache Commons Release Plugin 1.5. The Apache Commons Release Plugin is a collection of Java based Maven mojos for Apache Commons Release process. These mojos are intend

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-30 Thread Rob Tompkins
I believe that the [VOTE] thread is still out there. As I’ve already done build validation, I’m going to do signature validation now. I’ll dig the thread up and add my vote. -Rob > On Jan 30, 2019, at 9:02 AM, Gilles Sadowski wrote: > > Le mer. 30 janv. 2019 à 14:56, Maxim Solodovnik

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-30 Thread Gilles Sadowski
Le mer. 30 janv. 2019 à 14:56, Maxim Solodovnik a écrit : > > Latest version of test [2] shows all errors are false positive Great; I missed that (sorry). Then, there is no reason to change the major version number. Is this still the [VOTE] thread? Regards, Gilles > > On Wed, 30 Jan 2019

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-30 Thread Gary Gregory
The RC seems fine. The new test can be added post release. Gary On Wed, Jan 30, 2019, 08:23 Gilles Sadowski Hi. > > Le mer. 30 janv. 2019 à 13:16, Rob Tompkins a écrit : > > > > > > > > > On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik > wrote: > > > > > > Hello All, > > > > > > It seems my prev

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-30 Thread Maxim Solodovnik
Latest version of test [2] shows all errors are false positive On Wed, 30 Jan 2019 at 20:23, Gilles Sadowski wrote: > Hi. > > Le mer. 30 janv. 2019 à 13:16, Rob Tompkins a écrit : > > > > > > > > > On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik > wrote: > > > > > > Hello All, > > > > > > I

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-30 Thread Gilles Sadowski
Hi. Le mer. 30 janv. 2019 à 13:16, Rob Tompkins a écrit : > > > > > On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik wrote: > > > > Hello All, > > > > It seems my previous post was missed somehow > > so will re-post here: > > > > I have added japicmp report here: [1] is has none issues > > > > What

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-30 Thread Rob Tompkins
> On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik wrote: > > Hello All, > > It seems my previous post was missed somehow > so will re-post here: > > I have added japicmp report here: [1] is has none issues > What do folks think about [1]? It looks much more promising than the clirr report.

Re: Math Sparse Linear Programing -- Math Commons

2019-01-30 Thread Gilles Sadowski
Hi Bill. Did you open a JIRA report? A unit test would be welcome (one that makes the current implementation crash but produces the expected results with your modifications). Regards, Gilles Le lun. 28 janv. 2019 à 23:58, Eric Barnhill a écrit : > > It sounds like this is a worthwhile upgrade t

[GitHub] garydgregory commented on a change in pull request #5: optimize map columns 2 properties code

2019-01-30 Thread GitBox
garydgregory commented on a change in pull request #5: optimize map columns 2 properties code URL: https://github.com/apache/commons-dbutils/pull/5#discussion_r252210114 ## File path: src/main/java/org/apache/commons/dbutils/BeanProcessor.java ## @@ -465,9 +465,6 @@ protec

Re: [LANG] Checked Functions PR

2019-01-30 Thread Aleksander Ściborek
I'm going to add those functionalities (default methods). On Tue, 29 Jan 2019 at 16:56, Matt Sicker wrote: > I like this idea in theory. What would really make this shine is > including similar default methods as the unchecked classes. > Matt Sicker > >