Re: [VOTE][RC2] Commons collections 4.3

2019-01-19 Thread Maxim Solodovnik
I can see there is activity with replacing clirr with japicmp, maybe it worth to hold this release until commons-parent v48 will be released? On Sun, 20 Jan 2019 at 05:52, Gilles Sadowski wrote: > Hi. > > Le sam. 19 janv. 2019 à 11:36, Maxim Solodovnik a > écrit : > > > > I'm afraid I need help

[all] svn -> gitbox migration

2019-01-19 Thread Rob Tompkins
Hey guys, I’m curious if you saw my conversation with Chris Lambertus over in INFRA about what to do with our SVN repos [1]? I’m not quite sure what to do now that we have the vote [2], to move the repos over. It seems that they want to “freeze” svn and make it read only in the migration. Do we

[GitHub] kinow merged pull request #65: Fix simple Checkstyle and PMD issues introduced in 4.3

2019-01-19 Thread GitBox
kinow merged pull request #65: Fix simple Checkstyle and PMD issues introduced in 4.3 URL: https://github.com/apache/commons-collections/pull/65 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

2019-01-19 Thread GitBox
chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455834253 CuriousI've not seen that before. Will likely try it. -

[all] japicmp/parent

2019-01-19 Thread Rob Tompkins
I think we may be at a place where we may want a new parent build because japicmp 0.13 seems to work. @britter seems to want to use it in [collections] (I’m a +1 to that). Also, @britter, @bodewig did some good work on the last release of [compress] surrounding japicmp to get it to work properl

[GitHub] CasualSuperman commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

2019-01-19 Thread GitBox
CasualSuperman commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455834018 > Yeah I did that. If the artifact is a pom only module, japicmp kinda blows up and falls over. S

[GitHub] chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

2019-01-19 Thread GitBox
chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455833862 @britter - try japicmp version 0.13 ---

[GitHub] chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

2019-01-19 Thread GitBox
chtompki commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455833842 Yeah I did that. If the artifact is a pom only module, japicmp kinda blows up and falls over. So we hav

[GitHub] CasualSuperman commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul…

2019-01-19 Thread GitBox
CasualSuperman commented on issue #54: Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… URL: https://github.com/apache/commons-collections/pull/54#issuecomment-455831752 Looks like it's set up to skip in [commons-parent](https://github.com/apache/commons-parent/blob/

[GitHub] grimreaper commented on issue #66: COLLECTIONS-709 Set Entry count to 0 after remove

2019-01-19 Thread GitBox
grimreaper commented on issue #66: COLLECTIONS-709 Set Entry count to 0 after remove URL: https://github.com/apache/commons-collections/pull/66#issuecomment-455824429 This seems reasonable to me. This is an automated message

[GitHub] CasualSuperman opened a new pull request #66: COLLECTIONS-709 Set Entry count to 0 after remove

2019-01-19 Thread GitBox
CasualSuperman opened a new pull request #66: COLLECTIONS-709 Set Entry count to 0 after remove URL: https://github.com/apache/commons-collections/pull/66 After removing the last element of a MultiSet, the Entry doesn't have a count of 0. This makes the count accurate after removing the la

Re: [VOTE][RC2] Commons collections 4.3

2019-01-19 Thread Gilles Sadowski
Hi. Le sam. 19 janv. 2019 à 11:36, Maxim Solodovnik a écrit : > > I'm afraid I need help with this > since I don't understand why clirr reports these errors Nobody knows around here; but your test demonstrates that one of the errors is a false positive. So I suggest that, for good measure, you a

Re: [commons] svn -> gitbox migration?

2019-01-19 Thread Rob Tompkins
> On Jan 19, 2019, at 3:20 PM, Chris Lambertus wrote: > > > >> On Jan 19, 2019, at 12:00 PM, Rob Tompkins wrote: >> >> Hello infra, >> >> Before opening a ton of JIRAs (which I’ve naively done in the past), I >> figured I’d ask how to migrate an SVN repo (mirrored in github) to being a

Re: [commons] svn -> gitbox migration?

2019-01-19 Thread Chris Lambertus
> On Jan 19, 2019, at 12:00 PM, Rob Tompkins wrote: > > Hello infra, > > Before opening a ton of JIRAs (which I’ve naively done in the past), I > figured I’d ask how to migrate an SVN repo (mirrored in github) to being a > gitbox repository? I have in the past done git-wip migrations where

[commons] svn -> gitbox migration?

2019-01-19 Thread Rob Tompkins
Hello infra, Before opening a ton of JIRAs (which I’ve naively done in the past), I figured I’d ask how to migrate an SVN repo (mirrored in github) to being a gitbox repository? I have in the past done git-wip migrations where all I needed ask after completing the migration was to re-point the

Re: [VOTE][RC2] Commons collections 4.3

2019-01-19 Thread Maxim Solodovnik
I'm afraid I need help with this since I don't understand why clirr reports these errors On Sat, 19 Jan 2019 at 17:32, sebb wrote: > On Sat, 19 Jan 2019 at 03:40, Maxim Solodovnik > wrote: > > > > Hello All, > > > > Am I right thinking it is OK to add something like > > "Clirr errors reported f

Re: [VOTE][RC2] Commons collections 4.3

2019-01-19 Thread sebb
On Sat, 19 Jan 2019 at 03:40, Maxim Solodovnik wrote: > > Hello All, > > Am I right thinking it is OK to add something like > "Clirr errors reported for this version can be ignored" to release NOTES > and proceed with VOTE? Something like that, but IMO it needs to explain why each type of error i