Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Gilles
On Fri, 28 Dec 2018 14:00:48 -0500, Rob Tompkins wrote: On Dec 28, 2018, at 1:31 PM, Gilles wrote: On Fri, 28 Dec 2018 13:18:41 -0500, Rob Tompkins wrote: Yes. I agree that makes sense. It is a considerable amount of work to do that migration in a single go. So, I’m not sure if we should go

Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Gary Gregory
It all depends if one brave soul wants to do all that at once ;-) not me in the near term... Gary On Fri, Dec 28, 2018, 13:18 Rob Tompkins Yes. I agree that makes sense. It is a considerable amount of work to do > that migration in a single go. So, I’m not sure if we should go at it > piecemeal

Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Rob Tompkins
> On Dec 28, 2018, at 1:31 PM, Gilles wrote: > > On Fri, 28 Dec 2018 13:18:41 -0500, Rob Tompkins wrote: >> Yes. I agree that makes sense. It is a considerable amount of work to >> do that migration in a single go. So, I’m not sure if we should go at >> it piecemeal or as a complete lump of wo

Re: [codec] Preparing for 1.12

2018-12-28 Thread Rob Tompkins
I’m going to prepare the release on branch 1_12 in svn. Feel free to push changes there. After the release I’ll merge it all back into trunk. Further, I won’t likely be touching any java files, so you won’t have to worry about stepping on my toes at all. -Rob > On Dec 28, 2018, at 9:55 AM, Gar

Re: [commons-numbers] [...] NUMBERS-91: Added ofInt() factory methods [...]

2018-12-28 Thread Gilles
On Fri, 28 Dec 2018 09:17:08 -0800, Eric Barnhill wrote: Fractions are constructed using either ints or doubles. In the case of ints, the numerator and denominator are passed (or the denominator is assumed to be one). Constructing fractions from doubles is more algorithmic work: if I pass a kno

Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Gilles
On Fri, 28 Dec 2018 13:18:41 -0500, Rob Tompkins wrote: Yes. I agree that makes sense. It is a considerable amount of work to do that migration in a single go. So, I’m not sure if we should go at it piecemeal or as a complete lump of work. -Rob On Dec 28, 2018, at 11:41 AM, Jochen Wiedmann wr

Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Rob Tompkins
Yes. I agree that makes sense. It is a considerable amount of work to do that migration in a single go. So, I’m not sure if we should go at it piecemeal or as a complete lump of work. -Rob > On Dec 28, 2018, at 11:41 AM, Jochen Wiedmann > wrote: > > Weren't we going to fo that for *all* of

Re: [commons-numbers] [...] NUMBERS-91: Added ofInt() factory methods [...]

2018-12-28 Thread Stephen Colebourne
I'd suggest `of` and `ofXxx` for factories that perform little work, such as assigning to instance fields, and `from` and `fromXxx` for factories that perform meaningful work or conversion. Stephen On Fri, 28 Dec 2018 at 17:24, Eric Barnhill wrote: > > Fractions are constructed using either int

Re: [commons-numbers] [...] NUMBERS-91: Added ofInt() factory methods [...]

2018-12-28 Thread Eric Barnhill
Fractions are constructed using either ints or doubles. In the case of ints, the numerator and denominator are passed (or the denominator is assumed to be one). Constructing fractions from doubles is more algorithmic work: if I pass a known fixed quantity such as 0.6 of course it will not be hard f

Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Jochen Wiedmann
Weren't we going to fo that for *all* of our projects? On Fri, Dec 28, 2018 at 4:17 PM Pascal Schumacher wrote: > > +1 > > Am 28.12.2018 um 15:51 schrieb Rob Tompkins: > > After doing the 1.12 release I propose we move commons-codec to gitbox. > > This is a [LAZY] consensus [VOTE] for doing such

Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Pascal Schumacher
+1 Am 28.12.2018 um 15:51 schrieb Rob Tompkins: After doing the 1.12 release I propose we move commons-codec to gitbox. This is a [LAZY] consensus [VOTE] for doing such after I get through the release. This [LAZY][VOTE] will be open for at least 72 hours form now. Cheers, -Rob ---

Re: [VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Gary Gregory
+1 Gary On Fri, Dec 28, 2018, 09:51 Rob Tompkins After doing the 1.12 release I propose we move commons-codec to gitbox. > This is a [LAZY] consensus [VOTE] for doing such after I get through the > release. This [LAZY][VOTE] will be open for at least 72 hours form now. > > Cheers, > -Rob > -

Re: [codec] Preparing for 1.12

2018-12-28 Thread Gary Gregory
Yes and thank you. I had some pending changes on my laptop that died. While I am getting a new laptop today, I've lost those changes WRT adding SHA-3 methods in DigestUtils. I will have to check if I pushed anything. Thank you, Gary On Fri, Dec 28, 2018, 09:44 Rob Tompkins I’m going to prepare a

[VOTE][LAZY] Move commons-codec to gitbox after 1.12 release.

2018-12-28 Thread Rob Tompkins
After doing the 1.12 release I propose we move commons-codec to gitbox. This is a [LAZY] consensus [VOTE] for doing such after I get through the release. This [LAZY][VOTE] will be open for at least 72 hours form now. Cheers, -Rob --

[codec] Preparing for 1.12

2018-12-28 Thread Rob Tompkins
I’m going to prepare a 1.12 release if anyone is interested. Cheers, -Rob - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [commons-numbers] [...] NUMBERS-91: Added ofInt() factory methods [...]

2018-12-28 Thread Gilles
Hello Eric. On Thu, 27 Dec 2018 17:00:15 -0800, Eric Barnhill wrote: I am overloading: public static BigFraction ofInt(final BigInteger num) { return new BigFraction(num, BigInteger.ONE); } public static BigFraction ofInt(BigInteger num, BigInteger den) { return new BigFrac