[GitHub] emopers opened a new pull request #28: Close ObjectOutputStream before calling toByteArray on underlying ByteArrayOutputStream

2018-12-27 Thread GitBox
emopers opened a new pull request #28: Close ObjectOutputStream before calling toByteArray on underlying ByteArrayOutputStream URL: https://github.com/apache/commons-dbcp/pull/28 When an `ObjectOutputStream` instance wraps an underlying `ByteArrayOutputStream` instance, it is recommende

[GitHub] ossdev07 commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

2018-12-27 Thread GitBox
ossdev07 commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-450281751 can any maintainer have a look on this PR .. -

Re: [commons-fileupload] branch master updated: Changing Maven Coordinates, and package name, as required for binary incompatible changes.

2018-12-27 Thread Rob Tompkins
> On Dec 27, 2018, at 4:08 PM, Jochen Wiedmann > wrote: > > Hi, Rob, > > On Thu, Dec 27, 2018 at 2:35 PM Rob Tompkins wrote: >> >> @Jochen I’m going to have a go at merging in 1.4 to master such that it >> causes no conflicts. Is that ok??? > > I wasn't aware of that, so excuse me, if I

Re: [commons-numbers] branch fraction-dev updated: NUMBERS-91: Added ofInt() factory methods and made BigInteger-based constructor private

2018-12-27 Thread Eric Barnhill
I am overloading: public static BigFraction ofInt(final BigInteger num) { return new BigFraction(num, BigInteger.ONE); } public static BigFraction ofInt(BigInteger num, BigInteger den) { return new BigFraction(num, den); } private BigFraction(BigInteger num, BigIntege

Re: [commons-numbers] branch fraction-dev updated: NUMBERS-91: Added ofInt() factory methods and made BigInteger-based constructor private

2018-12-27 Thread Gilles
On Thu, 27 Dec 2018 23:54:57 +, ericbarnh...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. ericbarnhill pushed a commit to branch fraction-dev in repository https://gitbox.apache.org/repos/asf/commons-numbers.git The following commit(s) were added to

[GitHub] paroxayte opened a new pull request #28: add support priority based iteration over options supplied to CommandLine

2018-12-27 Thread GitBox
paroxayte opened a new pull request #28: add support priority based iteration over options supplied to CommandLine URL: https://github.com/apache/commons-cli/pull/28 CommandLine stores the options parsed as ArrayList. I changed this to what is essentially an iterable priority queue. I twea

Re: [numbers] propose making BigFraction an extension of Fraction

2018-12-27 Thread Gilles
Hi Eric. On Thu, 27 Dec 2018 11:53:39 -0800, Eric Barnhill wrote: Thanks for this response and it took me some time to think your various points through. On Thu, Dec 13, 2018 at 4:59 PM Gilles wrote: On Thu, 13 Dec 2018 11:20:12 -0800, Eric Barnhill wrote: > Among the elegancies afforde

Re: [commons-fileupload] branch master updated: Changing Maven Coordinates, and package name, as required for binary incompatible changes.

2018-12-27 Thread Jochen Wiedmann
Hi, Rob, On Thu, Dec 27, 2018 at 2:35 PM Rob Tompkins wrote: > > @Jochen I’m going to have a go at merging in 1.4 to master such that it > causes no conflicts. Is that ok??? I wasn't aware of that, so excuse me, if I have been too fast. Just commit, whatever seems to make sense, or rollback my

Re: [numbers] propose making BigFraction an extension of Fraction

2018-12-27 Thread Eric Barnhill
Thanks for this response and it took me some time to think your various points through. On Thu, Dec 13, 2018 at 4:59 PM Gilles wrote: > > On Thu, 13 Dec 2018 11:20:12 -0800, Eric Barnhill wrote: > > > Among the elegancies afforded by this change, if a Fraction operation > > causes overflow as pr

[GitHub] jvz commented on a change in pull request #72: [IO-596] Add DeleteFiles utility class

2018-12-27 Thread GitBox
jvz commented on a change in pull request #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72#discussion_r244167531 ## File path: src/main/java/org/apache/commons/io/DeleteFiles.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apa

Re: [commons-fileupload] branch master updated: Changing Maven Coordinates, and package name, as required for binary incompatible changes.

2018-12-27 Thread Rob Tompkins
@Jochen I’m going to have a go at merging in 1.4 to master such that it causes no conflicts. Is that ok??? -Rob > On Dec 27, 2018, at 8:33 AM, joc...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > jochen pushed a commit to branch master > in repos

[RESULT][VOTE] Release Apache Commons FileUpload 1.4 based on RC2

2018-12-27 Thread Rob Tompkins
Hello all, Many thanks for the [VOTE] over the holidays and for the discussions about the release. The validations came from: Bruno Kinoshita: +1, Bernd Eckenfels: +1, and Rob Tompkins: +1. I will do the release promotion and begin working on the documentation surrounding the release. Cheers,

Re: [VOTE] Release Apache Commons FileUpload 1.4 based on RC2

2018-12-27 Thread Rob Tompkins
Here’s my +1. -Rob > On Dec 24, 2018, at 6:09 AM, Bernd Eckenfels wrote: > > Hello, > > +1 > > (checked jar cheksums, , compiled java11/mvn3.3.1 on win10, read Reports) > > With nits, there is a „No client code changes are required to migrate from > version 1.3.0 to 1.3.1.“ sentence which c