Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Maxim Solodovnik
This is the way Wicketstuff build is performed [1] The project consist of ~285 modules and it is wise to create tag only if build is already in Nexus :) [1] https://github.com/wicketstuff/core/wiki/Wicket-Stuff-Core-Release-Process On Wed, 26 Dec 2018 at 08:11, Rob Tompkins wrote: > > > > On De

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Rob Tompkins
> On Dec 25, 2018, at 8:04 PM, Maxim Solodovnik wrote: > > In both git and svn you need a branch to create tag > But since git has local and remote repository, steps can be: > > 1) create local branch > 2) made "release" changes > 3) create tag > 4) push the tag > > In this case only tag wil

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Maxim Solodovnik
In both git and svn you need a branch to create tag But since git has local and remote repository, steps can be: 1) create local branch 2) made "release" changes 3) create tag 4) push the tag In this case only tag will be pushed, and there will be no useless branches with minimal "release" change

[CANCELED] [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Maxim Solodovnik
Hello All, I will cancel the VOTE due to issues found in this RC Will try to create RC2 ASAP Thanks for your help! On Wed, 26 Dec 2018 at 05:40, Gilles wrote: > Hi. > > On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote: > > Hello Gilles, > > > > Actually if release is made based on gi

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Gilles
Hi. On Tue, 25 Dec 2018 22:22:43 +0700, Maxim Solodovnik wrote: Hello Gilles, Actually if release is made based on git it is not necessary to perform commits ? I don't know other ways to perform the release; I follow the practice established for "svn", that was then adapted for "git" when we

Re: [VOTE][RC1] Commons collections 4.3

2018-12-25 Thread Maxim Solodovnik
Hello Gilles, Actually if release is made based on git it is not necessary to perform commits into local branch you are using to create RC tag this why I previously ask if I can drop useless branch I can fix issues with site manually, but it will be impossible to modify pom without canceling rele