Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Maxim Solodovnik
My bad, Here is the analysis (please correct me if I'm wrong) Errors: 1) `org.apache.commons.collections4.BidiMap:: Method 'public java.util.Collection values()' has been added to an interface` 2) `org.apache.commons.collections4.ListValuedMap:: Method 'public java.util.Collection get(java.lang.Ob

Re: [All][RNG] Fixing the download page

2018-12-19 Thread sebb
On Wed, 19 Dec 2018 at 15:54, Gilles wrote: > > On Wed, 19 Dec 2018 15:11:59 +, sebb wrote: > > On Wed, 19 Dec 2018 at 14:50, Gilles > > wrote: > >> > >> On Wed, 19 Dec 2018 09:48:30 +, sebb wrote: > >> > On Wed, 19 Dec 2018 at 00:05, Gilles > >> > >> > wrote: > >> >> > >> >> On Mon, 17

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread sebb
On Wed, 19 Dec 2018 at 16:09, Maxim Solodovnik wrote: > > Thanks for checking Gilles, > > Regarding clirr errors instruction states [1] to check errors only for > minor release That is not the understanding I have of how to handle Clirr errors, nor does the doc [1] actually say that. The cited do

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Gilles
On Wed, 19 Dec 2018 23:08:44 +0700, Maxim Solodovnik wrote: Thanks for checking Gilles, Regarding clirr errors instruction states [1] to check errors only for minor release Since it is 4.3.0 and not 4.2.1 I thought it is OK .. 4.X is a minor release ("Y.0" is a major one). Usually (with no

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-19 Thread Maxim Solodovnik
Hello Rob, The instruction [1] is good but seems to me "too universal" it would be easier to start with instruction specific to particular project :) I was my first release of commons-collections so I was unsure on every step :)) [1] https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Maxim Solodovnik
Thanks for checking Gilles, Regarding clirr errors instruction states [1] to check errors only for minor release Since it is 4.3.0 and not 4.2.1 I thought it is OK .. How this should be properly addressed? release_4_3.html was not genarated during build :( How can I generate it? Is it possible t

Re: [All][RNG] Fixing the download page

2018-12-19 Thread Gilles
On Wed, 19 Dec 2018 15:11:59 +, sebb wrote: On Wed, 19 Dec 2018 at 14:50, Gilles wrote: On Wed, 19 Dec 2018 09:48:30 +, sebb wrote: > On Wed, 19 Dec 2018 at 00:05, Gilles > wrote: >> >> On Mon, 17 Dec 2018 15:28:46 +0100, Gilles wrote: >> > Ping? >> >> I found this: >> >> >> https:

Re: [All][RNG] Fixing the download page

2018-12-19 Thread sebb
On Wed, 19 Dec 2018 at 14:50, Gilles wrote: > > On Wed, 19 Dec 2018 09:48:30 +, sebb wrote: > > On Wed, 19 Dec 2018 at 00:05, Gilles > > wrote: > >> > >> On Mon, 17 Dec 2018 15:28:46 +0100, Gilles wrote: > >> > Ping? > >> > >> I found this: > >> > >> > >> https://gitbox.apache.org/repos/asf?p

Re: [VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Gilles
Hi. Congratulations for getting that far in a fairly short time. ;-) The BC report (Clirr) notes several incompatible changes: https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC1/site/clirr-report.html [No idea whether that was expected. If so, perhaps there should be a remar

Re: [All][RNG] Fixing the download page

2018-12-19 Thread Gilles
On Wed, 19 Dec 2018 09:48:30 +, sebb wrote: On Wed, 19 Dec 2018 at 00:05, Gilles wrote: On Mon, 17 Dec 2018 15:28:46 +0100, Gilles wrote: > Ping? I found this: https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commitdiff;h=f73546863611e5dd850fd311277f2019259489ce;hp=288c8b5196ab29

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-19 Thread Rob Tompkins
> On Dec 19, 2018, at 8:29 AM, Maxim Solodovnik wrote: > > The build was successful > Staging repo is closed > > Thanks a lot for the help! How were the docs on using the release plugin? Just curious…as I wrote the plugin and the docs. -Rob > > On Wed, 19 Dec 2018 at 08:54, Rob Tompkins

[VOTE][RC1] Commons collections 4.3

2018-12-19 Thread Maxim Solodovnik
commons-collections4-4.3-src.zip.sha256This is a [VOTE] for releasing Apache Commons collections 4.3 Tag name: collections-4.3-RC1 (signature can be checked from git using 'git tag -v') Tag URL: https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=5f959fd8e77bf28f6286cfb4

Re: Help with migrating one of OpenJPA classes to commons-collections4

2018-12-19 Thread Maxim Solodovnik
The build was successful Staging repo is closed Thanks a lot for the help! On Wed, 19 Dec 2018 at 08:54, Rob Tompkins wrote: > > > > On Dec 18, 2018, at 7:51 PM, Maxim Solodovnik > wrote: > > > > Is it possible staging-distribution fails because there is already > 4.2-RC1/ > > at dist-dev? > >

Re: [All][RNG] Fixing the download page (Was: [Release-plugin] Auto-generated download page is wrong (Was: Returned post for annou...@apache.org))

2018-12-19 Thread sebb
On Wed, 19 Dec 2018 at 00:05, Gilles wrote: > > On Mon, 17 Dec 2018 15:28:46 +0100, Gilles wrote: > > Ping? > > I found this: > > https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commitdiff;h=f73546863611e5dd850fd311277f2019259489ce;hp=288c8b5196ab29e0e2ca50182a28f217e0828833 > > Please con