[GitHub] commons-imaging issue #38: Cleaned up PNG component.

2018-11-29 Thread SukantPal
Github user SukantPal commented on the issue: https://github.com/apache/commons-imaging/pull/38 This is the ASF JIRA issue related to this improvement: https://issues.apache.org/jira/projects/IMAGING/issues/IMAGING-218?filter=allopenissues&orderby=priority+DESC%2C+updated+DESC. ---

[GitHub] commons-imaging pull request #38: Cleaned up PNG component.

2018-11-29 Thread SukantPal
GitHub user SukantPal opened a pull request: https://github.com/apache/commons-imaging/pull/38 Cleaned up PNG component. Following changes were made (overview): PngWriter.ImageHeader removed (replaced by making PngChunkIhdr mutable); divided PngWriter.writeImage (by creating pixel

Re: [Lang] CheckedFunction#unchecked

2018-11-29 Thread ajs6f
Please do! This is a pretty common need and it would be nice to present a really well-designed set of types for it. ajs6f > On Nov 29, 2018, at 2:41 PM, Aleksander Ściborek > wrote: > > Ok, so I'm going to continue snd in the near future I will create pull > request with a lot of checked fun

Re: [Lang] CheckedFunction#unchecked

2018-11-29 Thread Aleksander Ściborek
Ok, so I'm going to continue snd in the near future I will create pull request with a lot of checked functions like Consumer, Predicate BinaryFuncton etc. On Sat, Nov 24, 2018, 15:01 ajs6f In that case you might want to also look at some other choices people have > made like > > https://github.c

[GitHub] commons-io pull request #71: [IO-592] Modified FileUtilsDirectoryContainsTes...

2018-11-29 Thread rerewww
GitHub user rerewww opened a pull request: https://github.com/apache/commons-io/pull/71 [IO-592] Modified FileUtilsDirectoryContainsTestCase File - Add directory is null test case in FileUtilsDirectoryContainsTestCase - The exception case has modified with meaningful verification

Re: [numbers] Making Quaternion a VALJO

2018-11-29 Thread Gilles
Hello. On Thu, 29 Nov 2018 08:43:22 +, Steve Bosman wrote: Hi I had a look last night at making Quaternion a VALJO. I've done the following * changed the constructors to private and added equivalent of methods. * added a parse method * altered equals so that (like Complex) it uses Doubl

[numbers] Making Quaternion a VALJO

2018-11-29 Thread Steve Bosman
Hi I had a look last night at making Quaternion a VALJO. I've done the following * changed the constructors to private and added equivalent of methods. * added a parse method * altered equals so that (like Complex) it uses Double.equals - gets round an edge case where Quaternions with the equiva