[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-20 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-pool/pull/17 hrm... or at least its not consistent. I just ran it twice more and failed only once. ∴mvn test -Dtest=TestGenericObjectPool#testCloseMultiplePools I'm not generally the biggest

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-20 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-pool/pull/17 The new test doesn't fail for me if I reverse the original change: ``` [INFO] --- [INFO] T E S T S [INFO] --

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-20 Thread mswintermeyer
Github user mswintermeyer commented on the issue: https://github.com/apache/commons-pool/pull/17 Also, thank you for merging in the meantime, as well as for contributing your time to maintain the project! --- - To u

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-20 Thread mswintermeyer
Github user mswintermeyer commented on the issue: https://github.com/apache/commons-pool/pull/17 @garydgregory the test was failing on my machine without the main code change, so thanks for flagging that it was not consistent! I've updated the test, and I believe this time it's a cons

Re: [IO] Provenance of copied code in InfiniteCircularInputStream

2018-11-20 Thread Gary Gregory
On Tue, Nov 20, 2018 at 8:31 AM Sharon Corbett < sharon.corb...@eclipse-foundation.org> wrote: > Thanks for the quick investigation and response. > > It's appreciated! > You're welcome Sharon. I removed the comment in commit b487c9e8bc8410c7c0ca94f9494bcff90613946a Gary > > Regards, > Sharon

[GitHub] commons-rng pull request #13: RNG-61: Remove unnecessary conditional from in...

2018-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rng/pull/13 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rng pull request #12: RNG-57: Cache values for provision of nextBool...

2018-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rng/pull/12 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rng pull request #14: fix: removed 1.8 annotation to ensure 1.7 comp...

2018-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rng/pull/14 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [IO] Provenance of copied code in InfiniteCircularInputStream

2018-11-20 Thread Sharon Corbett
Thanks for the quick investigation and response. It's appreciated! Regards, Sharon On Mon, Nov 19, 2018 at 4:36 PM Gary Gregory wrote: > Hi All: > > I agree that the 0xff usage does not need to be documented, and while I do > see it used in ByteArrayInputStream#read() in Oracle Java 6, I rea

Re: [pool] test failures

2018-11-20 Thread Phil Steitz
Look at the source for the failing tests.  What you will likely see is a lot of threads being started, a delay waiting for them to complete / hit conditions and then some assertions.  If the threads run into scheduling delays, they may not complete / hit conditions in time.  The timings are gen