[GitHub] commons-exec pull request #2: add jvmLaunchers

2018-11-18 Thread harbby
GitHub user harbby opened a pull request: https://github.com/apache/commons-exec/pull/2 add jvmLaunchers When you need to perform some operations through a child process, it is very cumbersome and requires a lot of coding. I have an api below to simplify this process and make it el

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-18 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-pool/pull/17 Works for me. Blocked on INFRA-17267 travis fails for unrelated reasons, but tests pass locally: ``` [INFO]

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-18 Thread mswintermeyer
Github user mswintermeyer commented on the issue: https://github.com/apache/commons-pool/pull/17 If `cancel` should not be called more than once, then I believe that would require a greater re-architecture. `GenericObjectPool`'s would need to keep track of whether another object pool

Re: [1/3] commons-compress git commit: COMPRESS-470 make sure all ScatterZipOutputStreams are closed

2018-11-18 Thread Gary Gregory
ensureStreamsAreClosed() seems like an over the top name. Why not simply closeAll()? Or close(). Gary On Sun, Nov 18, 2018, 09:02 Repository: commons-compress > Updated Branches: > refs/heads/master 979260717 -> f132d6c50 > > > COMPRESS-470 make sure all ScatterZipOutputStreams are closed > >