Re: [numbers] Fraction() and Knuth 4.5.1 -- overflow, BigInteger, long, and rounding

2018-11-08 Thread Gary Gregory
I'm all for the Javadoc made to reflect the reality of the code. It is fine to have an additional section that points out Knuth and how we may want to change things as a hint or request to contributors. Gary On Wed, Nov 7, 2018 at 10:52 AM Eric Barnhill wrote: > I read Kunth's "Art of Computer

[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...

2018-11-08 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-collections/pull/57 Hi @drajakumar , I'm not sure this patch makes sense. Take a look at ```org.apache.commons.collections4.list.Collections701Test```: For ```ArrayList``` and ```HashSet```, ad

Re: [numbers] Fraction() and Knuth 4.5.1 -- overflow, BigInteger, long, and rounding

2018-11-08 Thread Gilles
Hi. On Wed, 7 Nov 2018 09:52:30 -0800, Eric Barnhill wrote: I read Kunth's "Art of Computer Programming 4.5.1" that is referenced many times in the doc as the guidance for the commons-math/commons-numbers Fraction class. It is an interesting read. Also, for all the times it is cited in the doc

[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...

2018-11-08 Thread drajakumar
GitHub user drajakumar opened a pull request: https://github.com/apache/commons-collections/pull/57 COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion… … when it receives itself You can merge this pull request into a Git repository by running: $ git pull

[GitHub] commons-text pull request #92: TEXT-138 TextStringBuilder append sub-sequenc...

2018-11-08 Thread drajakumar
Github user drajakumar closed the pull request at: https://github.com/apache/commons-text/pull/92 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #92: TEXT-138 TextStringBuilder append sub-sequence not c...

2018-11-08 Thread drajakumar
Github user drajakumar commented on the issue: https://github.com/apache/commons-text/pull/92 closing as its consider in this commit https://github.com/apache/commons-text/commit/70c080b146e8e6fb79cd97f780b65f863d4ec6d8 --- ---