[GitHub] commons-io pull request #67: IO-170: Scalable Iterator for files, better tha...

GitHub user detinho opened a pull request: https://github.com/apache/commons-io/pull/67 IO-170: Scalable Iterator for files, better than FileUtils.iterateFiles I took an aproach of implementing a separate class with the iterator logic. While this brings a little code duplication,

Re: build failes for commons-io

I think I've found actually reasos for my problems, it's seems it was caused by long path and spaces in directories names - I run mvn clean package in tmp folder and everything has passed On Tue, 16 Oct 2018 at 00:29, sebb wrote: > On Mon, 15 Oct 2018 at 23:04, Aleksander Ściborek > wrote: > >

Re: build failes for commons-io

On Mon, 15 Oct 2018 at 23:04, Aleksander Ściborek wrote: > > Github indicates 1.67 KB, on my computer it shows 1,7 KB but this is > probably just rounded value That looks OK. However, the assertion message means that the code detected a size of 0. No idea why that should be. I think you will h

Re: build failes for commons-io

Github indicates 1.67 KB, on my computer it shows 1,7 KB but this is probably just rounded value On Mon, 15 Oct 2018 at 23:54, sebb wrote: > On Mon, 15 Oct 2018 at 22:44, Aleksander Ściborek > wrote: > > > > Ok, so this is list of errors: > > FileUtilsTestCase.testContentEqualsIgnoreEOL:672 >

Re: build failes for commons-io

On Mon, 15 Oct 2018 at 22:44, Aleksander Ściborek wrote: > > Ok, so this is list of errors: > FileUtilsTestCase.testContentEqualsIgnoreEOL:672 > IOUtilsTestCase.testResourceToByteArray_ExistingResourceAtRootPackage:1251 > expected:<0> but was:<1705> What is the size of the following file: src/

Re: build failes for commons-io

Ok, so this is list of errors: FileUtilsTestCase.testContentEqualsIgnoreEOL:672 IOUtilsTestCase.testResourceToByteArray_ExistingResourceAtRootPackage:1251 expected:<0> but was:<1705> IOUtilsTestCase.testResourceToByteArray_ExistingResourceAtRootPackage_WithClassLoader:1258 expected:<0> but was:

Re: build failes for commons-io

On Mon, 15 Oct 2018 at 21:56, Aleksander Ściborek wrote: > > Ok. soon I will add more information, but actually you can see that it > fails on github: https://travis-ci.org/apache/commons-io Those appear to be Checkstyle errors, not test errors. > On Mon, 15 Oct 2018 at 22:51, sebb wrote: > > >

Re: build failes for commons-io

Ok. soon I will add more information, but actually you can see that it fails on github: https://travis-ci.org/apache/commons-io On Mon, 15 Oct 2018 at 22:51, sebb wrote: > On Mon, 15 Oct 2018 at 21:11, Aleksander Ściborek > wrote: > > > > Hi, > > I had forked commons-io and pulled it from githu

Re: build failes for commons-io

On Mon, 15 Oct 2018 at 21:11, Aleksander Ściborek wrote: > > Hi, > I had forked commons-io and pulled it from github and later on I run mvn > clean package. I've got 9 failures - One from FileUtilsTestCase and more > from IOUtilsTestCase. It works for me using the following software. Apache Mave

build failes for commons-io

Hi, I had forked commons-io and pulled it from github and later on I run mvn clean package. I've got 9 failures - One from FileUtilsTestCase and more from IOUtilsTestCase. Aleksander

Re: GitHub Pull Requests

Dear Zack, I gave a shot at it. I have some comments and see if they make sense. Regards, Sudeendra Nadager On 13/10/18, 01:33, "Pascal Schumacher" wrote: Hi Zack, there is no hard and fast rule when pull request get reviewed and/or commented on. It happens whenever

JDK 12 Early Access build 15 is available

Hi Benedikt, *JDK 12 Early Access build 15 is available at : - jdk.java.net/12/* * JDK 12 Schedule is confirmed. o 2018/12/13 Rampdown Phase One o 2019/01/17 Rampdown Phase Two o 2019/02/07 Release-Cand