[GitHub] commons-collections pull request #51: AbstractReferenceMap made easier for s...

Github user solomax closed the pull request at: https://github.com/apache/commons-collections/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache

[GitHub] commons-collections pull request #51: AbstractReferenceMap made easier for s...

Github user solomax closed the pull request at: https://github.com/apache/commons-collections/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache

[GitHub] darkma773r opened a new pull request #12: Geometry 19

darkma773r opened a new pull request #12: Geometry 19 URL: https://github.com/apache/commons-geometry/pull/12 Build updates to support JDK 10. This is an automated message from the Apache Git Service. To respond to the message

Re: [VOTE] Release Apache Commons CSV 1.6 based on RC1

+1 bin zip: ASC, SHA512 OK src zip: ASC, SHA512 OK >From src zip: Builds OK with 'mvn -V clean package site' using Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T12:33:14-06:00) Maven home: C:\Java\apache-maven-3.5.4\bin\.. Java version: 1.8.0_181, vendor: Oracle Corpo

Re: [VOTE] Release Apache Commons Lang 3.8.1 based on RC1

Note, only Pom changes from 3.8 tag. -Rob > On Sep 19, 2018, at 3:21 PM, Gary Gregory wrote: > > Also: RAT and CLIRR checks OK. > > Gary > > On Wed, Sep 19, 2018 at 11:58 AM Gary Gregory > wrote: > >> +1 but please fix the following before publishing the site: >> >> The POM says Java 8 bu

Re: [VOTE] Release Apache Commons Lang 3.8.1 based on RC1

Also: RAT and CLIRR checks OK. Gary On Wed, Sep 19, 2018 at 11:58 AM Gary Gregory wrote: > +1 but please fix the following before publishing the site: > > The POM says Java 8 but the site says: > >- The current stable release 3.8.1 > >

Re: [VOTE] Release Apache Commons Lang 3.8.1 based on RC1

+1 but please fix the following before publishing the site: The POM says Java 8 but the site says: - The current stable release 3.8.1 [Java 7 and up]" The page https://dist.apache.org/rep

[VOTE] Release Apache Commons Lang 3.8.1 based on RC1

We have fixed LANG-1419 "Restore BundleSymbolicName / regression in version 3.8.0", so I would like to release Apache Commons Lang 3.8.1. Apache Commons Lang 3.8.1 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/lang/3.8.1-RC1 (svn revision 29514) The Git t

Re: [All] CP definitions (Was: svn commit: r1841296 [...])

On Wed, Sep 19, 2018 at 8:30 AM Rob Tompkins wrote: > I think the plan moving forward here is that we should do the following: > > math > math4 > > And change [parent] back to > > > https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid} > > > Yeah?

Re: [All] CP definitions

On Wed, 19 Sep 2018 10:28:50 -0400, Rob Tompkins wrote: I think the plan moving forward here is that we should do the following: math math4 See my other post for an alternative. And change [parent] back to https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${co

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Do we have a JIRA for this? > On Sep 19, 2018, at 7:59 AM, Benedikt Ritter wrote: > > Hi, > > Am Mi., 19. Sep. 2018 um 13:44 Uhr schrieb Rob Tompkins >> : > >> >> >>> On Sep 19, 2018, at 4:25 AM, Benedikt Ritter >> > wrote: >>> >>> ...

Re: [All] CP definitions (Was: svn commit: r1841296 [...])

I think the plan moving forward here is that we should do the following: math math4 And change [parent] back to https://svn.apache.org/repos/infra/websites/production/commons/content/proper/${commons.componentid} Yeah? -Rob > On Sep 19, 2018, at 9:36 AM, Rob Tompkins wrote: > > > >> On Se

Re: [All] CP definitions

On Wed, 19 Sep 2018 09:36:25 -0400, Rob Tompkins wrote: On Sep 19, 2018, at 9:28 AM, Gilles wrote: On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote: The difference is to account for artifact ids that contain a version like commons-lang3. The component id is then just commons-lang. You

Re: [VOTE] Release Apache Commons CSV 1.6 based on RC1

On Wed, Sep 19, 2018 at 7:03 AM Benedikt Ritter wrote: > Hello Gary, > > Am Mi., 19. Sep. 2018 um 14:51 Uhr schrieb Gary Gregory < > garydgreg...@gmail.com>: > > > Note that we are NOT supposed to use SHA1 or MD5 anymore. Your vote > message > > should provide SHA256 or SHA512. Note that the dist

[GitHub] commons-collections pull request #53: updating containsKey method in Passive...

GitHub user thePatmanMI opened a pull request: https://github.com/apache/commons-collections/pull/53 updating containsKey method in PassiveExpiringMap correcting the containsKey method to remove all expired entries to match the class and method javadoc statements You can merge this

Re: [All] CP definitions

Hi Rob. On Wed, 19 Sep 2018 09:08:51 -0400, Rob Tompkins wrote: My impression was that we had this conversation, and we decided that we wanted this the other way around and to fix the components respectively due to the semantics of the issue at hand based on what Gary said below. It is not cle

Re: [All] CP definitions (Was: svn commit: r1841296 [...])

> On Sep 19, 2018, at 9:28 AM, Gilles wrote: > >> On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote: >> The difference is to account for artifact ids that contain a version like >> commons-lang3. The component id is then just commons-lang. You must not >> have versions in names for certai

Re: [All] CP definitions (Was: svn commit: r1841296 [...])

On Wed, 19 Sep 2018 06:45:13 -0600, Gary Gregory wrote: The difference is to account for artifact ids that contain a version like commons-lang3. The component id is then just commons-lang. You must not have versions in names for certain names like in the download page. This change will probabl

Re: [All] CP definitions (Was: svn commit: r1841296 [...])

My impression was that we had this conversation, and we decided that we wanted this the other way around and to fix the components respectively due to the semantics of the issue at hand based on what Gary said below. -Rob > On Sep 19, 2018, at 8:45 AM, Gary Gregory wrote: > > The difference

Re: [VOTE] Release Apache Commons CSV 1.6 based on RC1

Hello Gary, Am Mi., 19. Sep. 2018 um 14:51 Uhr schrieb Gary Gregory < garydgreg...@gmail.com>: > Note that we are NOT supposed to use SHA1 or MD5 anymore. Your vote message > should provide SHA256 or SHA512. Note that the dist files do provide proper > SHA file. > As far as I understood maven ce

Re: [VOTE] Release Apache Commons CSV 1.6 based on RC1

Note that we are NOT supposed to use SHA1 or MD5 anymore. Your vote message should provide SHA256 or SHA512. Note that the dist files do provide proper SHA file. Gary On Wed, Sep 19, 2018, 06:31 Benedikt Ritter wrote: > Hi, > > we have fixed some bugs and added some features since Commons CSV 1

Re: [All] CP definitions (Was: svn commit: r1841296 [...])

The difference is to account for artifact ids that contain a version like commons-lang3. The component id is then just commons-lang. You must not have versions in names for certain names like in the download page. This change will probably break builds like pool, dbcp, lang, and so on. Gary On We

[VOTE] Release Apache Commons CSV 1.6 based on RC1

Hi, we have fixed some bugs and added some features since Commons CSV 1.5 has been released, so I would like to release Commons CSV 1.6 based on RC1 Commons CSV 1.6 is available for review here: https://dist.apache.org/repos/dist/dev/commons/csv/1.6-RC1/ (r29508) The tag is here: https://git-

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

Hi, Am Mi., 19. Sep. 2018 um 13:44 Uhr schrieb Rob Tompkins : > > > > On Sep 19, 2018, at 4:25 AM, Benedikt Ritter wrote: > > > > ... bringing this to the developers list... > > > > I think this issue has been caused by this change: > > > http://svn.apache.org/viewvc/commons/proper/commons-paren

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

> On Sep 19, 2018, at 4:25 AM, Benedikt Ritter wrote: > > ... bringing this to the developers list... > > I think this issue has been caused by this change: > http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926 Do we roll a 3.8.1? -Rob > > I don't

Re: [ALL] Multiple things broken in commons build infrastructure

Hi. On Wed, 19 Sep 2018 11:41:53 +0200, Benedikt Ritter wrote: Hello, I'm trying to release commons-csv and there are multiple things broken at the moment: - the site build does not work because of COMMONSSITE-124 - the OSGi bundle symbolic name is generated incorrectly because fo COMMONSSIT

[All] CP definitions (Was: svn commit: r1841296 [...])

Hi. Are we sure that the fix/revert below to work as intended for *all* components? Common usage should be enforced (e.g. to allow anyone to help releasing any component), and ancient inconsistencies fixed. With a concrete example of a component that has had major version changes (and top-level

[ALL] Multiple things broken in commons build infrastructure

Hello, I'm trying to release commons-csv and there are multiple things broken at the moment: - the site build does not work because of COMMONSSITE-124 - the OSGi bundle symbolic name is generated incorrectly because fo COMMONSSITE-125 - the commons-build-plugin goal prefix has been changed to fro

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

I've checked the commons-csv build, since commons-lang is somehow special because of the componentId being lang3 (we talked about this on the other thread). It looks like this change also broke commons-csv. I think we should revert it. Benedikt Am Mi., 19. Sep. 2018 um 10:25 Uhr schrieb Benedikt

Re: [lang3] Problem with the OSGi metadata: Bundle-SymbolicName / breaking change between 3.7 and 3.8

... bringing this to the developers list... I think this issue has been caused by this change: http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1833874&r2=1833926 I don't understand why an update of the commons build plugin had to change the OSGi meta data being generat

Re: [parent] change in commons.scmPubUrl in Parent 47

Am Do., 6. Sep. 2018 um 09:52 Uhr schrieb Benedikt Ritter < brit...@apache.org>: > I have created COMMONSSITE-124 [1] in order to fix this. Will implement a > fix later today. > > Benedikt > > [1] https://issues.apache.org/jira/browse/COMMONSSITE-124 > COMMONSSITE-124 has been resolved in r184129