Re: [LANG] Minimum required Java version for 3.9

2018-08-22 Thread Benedikt Ritter
Hi, Am Mo., 20. Aug. 2018 um 19:09 Uhr schrieb Benedikt Ritter < brit...@apache.org>: > Hi, > > any objections against raising the minimum required Java version for lang > 3.9 to Java 1.8? > Since there where no objections, I've created a PR for this change: https://github.com/apache/commons-lan

Re: [CSV] Inconsistent record separator behavior

2018-08-22 Thread Benedikt Ritter
Hey sebb, Am Do., 23. Aug. 2018 um 01:23 Uhr schrieb sebb : > On 23 August 2018 at 00:01, Bruno P. Kinoshita > wrote: > > > >>Maybe I'm just not getting it, but it feels pretty messed up :-) > > > > > > Mutual feeling, and +1 for consistency. From what I understood, users > should be able to par

Re: [CSV] Inconsistent record separator behavior

2018-08-22 Thread Bruno P. Kinoshita
Very good arguments (as always) Sebb. I'd also be OK with leaving as is, until we have a user with a good reason for changing the send/create. And thanks for including the author of the quote. Going through his Wikipedia page, lots of things to read later. Bruno

Re: [CSV] Inconsistent record separator behavior

2018-08-22 Thread sebb
On 23 August 2018 at 00:01, Bruno P. Kinoshita wrote: > >>Maybe I'm just not getting it, but it feels pretty messed up :-) > > > Mutual feeling, and +1 for consistency. From what I understood, users should > be able to parse these crazy CVS's, but if they tried to re-create them, with > comments

Re: [CSV] Inconsistent record separator behavior

2018-08-22 Thread Bruno P. Kinoshita
>Maybe I'm just not getting it, but it feels pretty messed up :-) Mutual feeling, and +1 for consistency. From what I understood, users should be able to parse these crazy CVS's, but if they tried to re-create them, with comments, then they wouldn't be able to avoid the println/newline (so it

Re: [VOTE] Release Apache Commons Pool 2.6.1 based on RC1

2018-08-22 Thread Thomas Vandahl
On 17.08.18 18:07, Gary Gregory wrote: > These are the Maven artifacts and their hashes in Nexus: > > #Release SHA-256s > #Fri Aug 17 09:52:45 MDT 2018 > commons-pool2-2.6.1-bin-zip.asc=c557973fdb9b917eb9bd3aea01db5ec1fd9ba81dc44de3ebbfcf0d30d3034457 My understanding of the new release policy is

Re: [lang] (fix) Add missing @Test annotation

2018-08-22 Thread Benedikt Ritter
Nice one! Am Mi., 22. Aug. 2018 um 13:13 Uhr schrieb : > Repository: commons-lang > Updated Branches: > refs/heads/master d1e72ebed -> ce178d8e8 > > > (fix) Add missing @Test annotation > > > Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo > Commit: > http://git-wip-us.apache.

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Benedikt Ritter
Am Mi., 22. Aug. 2018 um 14:33 Uhr schrieb Gilles < gil...@harfang.homelinux.org>: > On Wed, 22 Aug 2018 08:11:03 -0400, Rob Tompkins wrote: > >> On Aug 22, 2018, at 1:47 AM, Benedikt Ritter > >> wrote: > >> > >> Hi, > >> > >> I don't understand this discussion. Changes in Commons Parent have > >

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Benedikt Ritter
Am Mi., 22. Aug. 2018 um 16:55 Uhr schrieb Gilles < gil...@harfang.homelinux.org>: > On Wed, 22 Aug 2018 16:24:57 +0200, Stefan Bodewig wrote: > > On 2018-08-22, Rob Tompkins wrote: > > > >>> On Aug 22, 2018, at 9:03 AM, Stefan Bodewig > >>> wrote: > > > >>> On 2018-08-22, Rob Tompkins wrote: > >

Re: Build failed in Jenkins: commons-csv #88

2018-08-22 Thread Benedikt Ritter
Am Mi., 22. Aug. 2018 um 19:15 Uhr schrieb sebb : > I discovered yesterday that not all of the beam* nodes are set up with > creds for deploying snapshots: > > https://issues.apache.org/jira/browse/INFRA-16935 > > Unless otherwise advised, jobs should be set up to run on ubuntu nodes. > > This mea

Re: [VOTE] Release Apache Commons Pool 2.6.1 based on RC1

2018-08-22 Thread Benedikt Ritter
Hi Gary, Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory < garydgreg...@gmail.com>: > WRT signing tags, ATM, I cannot git's -s option to work with GPG on > Windows. Any clues? > Sorry, I'm on macOS. For that to work I needed to have the gpg-agent running. But I don't know whether this is

Re: [CSV] Inconsistent record separator behavior

2018-08-22 Thread Benedikt Ritter
Hi Bruno, Am Mi., 22. Aug. 2018 um 15:10 Uhr schrieb Bruno P. Kinoshita : > Hi, > > > Will try to look at the code and give a better answer during the weekend. > But risking a silly question, would it mean that users are not able to > parse a CSV unless each CSV row is separated by LF or CRLF?

Re: [release-plugin] Preparing for 1.4.

2018-08-22 Thread Gilles
On Wed, 22 Aug 2018 18:04:59 +0100, sebb wrote: On 22 August 2018 at 15:04, Gary Gregory wrote: On Wed, Aug 22, 2018 at 7:53 AM Rob Tompkins wrote: > On Aug 22, 2018, at 9:38 AM, Gary Gregory wrote: > > Wait a second. If we are talking about our own release plugin, I think we > have a

Re: Build failed in Jenkins: commons-csv #88

2018-08-22 Thread sebb
I discovered yesterday that not all of the beam* nodes are set up with creds for deploying snapshots: https://issues.apache.org/jira/browse/INFRA-16935 Unless otherwise advised, jobs should be set up to run on ubuntu nodes. This means ensuring that you enable: "Restrict where this project can

Re: [release-plugin] Preparing for 1.4.

2018-08-22 Thread sebb
On 22 August 2018 at 15:04, Gary Gregory wrote: > On Wed, Aug 22, 2018 at 7:53 AM Rob Tompkins wrote: > >> >> >> > On Aug 22, 2018, at 9:38 AM, Gary Gregory >> wrote: >> > >> > Wait a second. If we are talking about our own release plugin, I think we >> > have a different beast here since this i

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Gilles
On Wed, 22 Aug 2018 16:24:57 +0200, Stefan Bodewig wrote: On 2018-08-22, Rob Tompkins wrote: On Aug 22, 2018, at 9:03 AM, Stefan Bodewig wrote: On 2018-08-22, Rob Tompkins wrote: On Aug 22, 2018, at 1:47 AM, Benedikt Ritter wrote: Hi, I don't understand this discussion. Changes in

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Stefan Bodewig
On 2018-08-22, Rob Tompkins wrote: >> On Aug 22, 2018, at 9:03 AM, Stefan Bodewig wrote: >> On 2018-08-22, Rob Tompkins wrote: On Aug 22, 2018, at 1:47 AM, Benedikt Ritter wrote: Hi, I don't understand this discussion. Changes in Commons Parent have broken the commons-com

Re: FW: Java 11 Compatibility Check of libraries : Commons-beanutils, Commons-cli, Commons-codec, Commons-collections, Commons-csv, Commons-digester, Commons-discovery, Commons-fileupload, Commons-io,

2018-08-22 Thread Gary Gregory
Please stop spamming Apache mailing lists, AGAIN. Gary On Wed, Aug 22, 2018 at 8:14 AM Dragan, Krzysztof wrote: > Hi, > Your software is very important and helpful to us. > We would like to ask about Compatibility of your libraries with java 11. > Could you help us by answering the following qu

FW: Java 11 Compatibility Check of libraries : Commons-beanutils, Commons-cli, Commons-codec, Commons-collections, Commons-csv, Commons-digester, Commons-discovery, Commons-fileupload, Commons-io, Com

2018-08-22 Thread Dragan, Krzysztof
Hi, Your software is very important and helpful to us. We would like to ask about Compatibility of your libraries with java 11. Could you help us by answering the following questions: 1. Library Name: 2. Latest version: 3. Latest version Is the library compatible with Java 11 Compatible? (Y/N) 4

Re: [release-plugin] Preparing for 1.4.

2018-08-22 Thread Gary Gregory
On Wed, Aug 22, 2018 at 7:53 AM Rob Tompkins wrote: > > > > On Aug 22, 2018, at 9:38 AM, Gary Gregory > wrote: > > > > Wait a second. If we are talking about our own release plugin, I think we > > have a different beast here since this is only used by us. BUT... I like > > consistency, so we mig

Re: [VOTE] Release Apache Commons Pool 2.6.1 based on RC1

2018-08-22 Thread Gary Gregory
WRT signing tags, ATM, I cannot git's -s option to work with GPG on Windows. Any clues? Gary On Tue, Aug 21, 2018 at 1:06 AM Benedikt Ritter wrote: > Hello Gary, > > -1, I there are several issues that we need to fix this before we can > release 2.6.1. > > I think the RELEASE NOTES need more wo

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Rob Tompkins
> On Aug 22, 2018, at 9:03 AM, Stefan Bodewig wrote: > > On 2018-08-22, Rob Tompkins wrote: > >>> On Aug 22, 2018, at 1:47 AM, Benedikt Ritter wrote: > >>> Hi, > >>> I don't understand this discussion. Changes in Commons Parent have broken >>> the commons-compress build. So we should either

Re: [release-plugin] Preparing for 1.4.

2018-08-22 Thread Rob Tompkins
> On Aug 22, 2018, at 9:38 AM, Gary Gregory wrote: > > Wait a second. If we are talking about our own release plugin, I think we > have a different beast here since this is only used by us. BUT... I like > consistency, so we might as well eat our own dog food. For major version > changes that

Re: [release-plugin] Preparing for 1.4.

2018-08-22 Thread Gary Gregory
Wait a second. If we are talking about our own release plugin, I think we have a different beast here since this is only used by us. BUT... I like consistency, so we might as well eat our own dog food. For major version changes that break BC we must change both the artifact ID and Java package name

Re: [CSV] Inconsistent record separator behavior

2018-08-22 Thread Bruno P. Kinoshita
Hi, Will try to look at the code and give a better answer during the weekend. But risking a silly question, would it mean that users are not able to parse a CSV unless each CSV row is separated by LF or CRLF? I remember getting a CSV in a government website some time ago that was formatted in

Re: [release-plugin] Preparing for 1.4.

2018-08-22 Thread Rob Tompkins
Seems reasonable. Should we go with 2.0? -Rob > On Aug 22, 2018, at 6:35 AM, Gilles wrote: > > On Tue, 21 Aug 2018 22:04:12 -0400, Rob Tompkins wrote: >> I’m curious to gauge what people think here. My general thought is no >> breaking BC without a major version change. So, even though this is

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Stefan Bodewig
On 2018-08-22, Rob Tompkins wrote: >> On Aug 22, 2018, at 1:47 AM, Benedikt Ritter wrote: >> Hi, >> I don't understand this discussion. Changes in Commons Parent have broken >> the commons-compress build. So we should either roll this changes back or >> those who need the changes in commons par

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Rob Tompkins
> On Aug 22, 2018, at 8:32 AM, Gilles wrote: > > On Wed, 22 Aug 2018 08:11:03 -0400, Rob Tompkins wrote: >>> On Aug 22, 2018, at 1:47 AM, Benedikt Ritter wrote: >>> >>> Hi, >>> >>> I don't understand this discussion. Changes in Commons Parent have broken >>> the commons-compress build. So we

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Gilles
On Wed, 22 Aug 2018 08:11:03 -0400, Rob Tompkins wrote: On Aug 22, 2018, at 1:47 AM, Benedikt Ritter wrote: Hi, I don't understand this discussion. Changes in Commons Parent have broken the commons-compress build. So we should either roll this changes back or those who need the changes in

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Rob Tompkins
> On Aug 22, 2018, at 1:47 AM, Benedikt Ritter wrote: > > Hi, > > I don't understand this discussion. Changes in Commons Parent have broken > the commons-compress build. So we should either roll this changes back or > those who need the changes in commons parent should fix the commons > compre

Re: [LANG] Minimum required Java version for 3.9

2018-08-22 Thread Francesco Chicchiriccò
On 2018/08/22 09:45:29, Benedikt Ritter wrote: > Hi, > > Am Mi., 22. Aug. 2018 um 10:52 Uhr schrieb Francesco Chicchiriccò < > ilgro...@apache.org>: > > > On 2018/08/20 17:09:27, Benedikt Ritter wrote: > > > Hi, > > > > > > any objections against raising the minimum required Java version for l

Re: [release-plugin] Preparing for 1.4.

2018-08-22 Thread Gilles
On Tue, 21 Aug 2018 22:04:12 -0400, Rob Tompkins wrote: I’m curious to gauge what people think here. My general thought is no breaking BC without a major version change. So, even though this is an internal component, we stick with the rules because we never know who else might be using the comp

Re: [LANG] Minimum required Java version for 3.9

2018-08-22 Thread Benedikt Ritter
Hi, Am Mi., 22. Aug. 2018 um 10:52 Uhr schrieb Francesco Chicchiriccò < ilgro...@apache.org>: > On 2018/08/20 17:09:27, Benedikt Ritter wrote: > > Hi, > > > > any objections against raising the minimum required Java version for lang > > 3.9 to Java 1.8? > > +1 > > Wouldn't 4.0 express better the

Re: [LANG] Minimum required Java version for 3.9

2018-08-22 Thread Francesco Chicchiriccò
On 2018/08/20 17:09:27, Benedikt Ritter wrote: > Hi, > > any objections against raising the minimum required Java version for lang > 3.9 to Java 1.8? +1 Wouldn't 4.0 express better the change for the minimum required Java version? Regards. ---

Re: [parent] change in commons.scmPubUrl in Parent 47

2018-08-22 Thread Stefan Bodewig
On 2018-08-22, Benedikt Ritter wrote: > I don't understand this discussion. Changes in Commons Parent have broken > the commons-compress build. So we should either roll this changes back or > those who need the changes in commons parent should fix the commons > compress build. I have already fixe