Re: [VOTE] Release Apache Commons Pool 2.6.1 based on RC1

2018-08-17 Thread Bruno P. Kinoshita
[ X ] +1 Release these artifacts Not much time to review signatures, but tested the build with `mvn clean test site` against commit sha from git Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java version: 1.8.0_1

Re: [LANG] Adding isEmpty and isNotEmpty methods to ObjectUtils

2018-08-17 Thread Gary Gregory
I must admit to playing a bit of devil's advocate here ;-) with my laundry list of sizeable kind of objects but I am sure you get my point: As soon as we add a method like this, the we will get requests for adding more to it release after release. I'm not against it, but it make you wonder about ad

Re: [RNG] Build failure on "master"

2018-08-17 Thread Rob Tompkins
> On Aug 15, 2018, at 6:41 PM, Gilles wrote: > > Hi. > > Build on "master" fails after the batch of commits post-release. > See console output excerpt below. > This is indeed weird. I’ve seen a bunch of things that cite aspect weaving as the root cause of the issue (specifically it’s us [b

Re: [DBCP] Abandoned trace should use CopyOnWriteArrayList instead of custom sync

2018-08-17 Thread Phil Steitz
On 8/17/18 10:13 AM, Gary Gregory wrote: A CopyOnWriteArrayList won't work since it does not support remove()... but the idea is to replace the ArrayList with a java.utl.concurrent structure... Interesting idea.  The thing to check is how method activations depend on the locks.  A quick look

Re: [DBCP] Abandoned trace should use CopyOnWriteArrayList instead of custom sync

2018-08-17 Thread Gary Gregory
org.apache.commons.dbcp2.AbandonedTrace.getTrace() is a protected method which folks might be calling from custom subclasses. So if we did change the internal representation we might have to do a conversion to support this method. Gary On Fri, Aug 17, 2018 at 11:13 AM Gary Gregory wrote: > A C

Re: [DBCP] Abandoned trace should use CopyOnWriteArrayList instead of custom sync

2018-08-17 Thread Gary Gregory
A CopyOnWriteArrayList won't work since it does not support remove()... but the idea is to replace the ArrayList with a java.utl.concurrent structure... Gary On Fri, Aug 17, 2018 at 11:05 AM Gary Gregory wrote: > Hi All and Phil: > > In [DBCP] Abandoned trace we use an Array with synchronized b

[DBCP] Abandoned trace should use CopyOnWriteArrayList instead of custom sync

2018-08-17 Thread Gary Gregory
Hi All and Phil: In [DBCP] Abandoned trace we use an Array with synchronized blocks. Should we replace this usage with a CopyOnWriteArrayList and no custom blocks? Gary

Re: [LANG] Adding isEmpty and isNotEmpty methods to ObjectUtils

2018-08-17 Thread Alexander Tsvetkov
Hi Gary, Yes, you can make the argument that the user might expect *every* class with a length(), size() or isEmpty() method to be covered by the implementation, but IMO as long as the Javadoc clearly states what is supported and what is not, then it's better to have at least a partial implementat

[VOTE] Release Apache Commons Pool 2.6.1 based on RC1

2018-08-17 Thread Gary Gregory
We have fixed one bug and updated optional dependencies since Apache Commons Pool 2.6.0 was released, so I would like to release Apache Commons Pool 2.6.1. Apache Commons Pool 2.6.1 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1 (svn revision 28

Re: [LANG] Adding isEmpty and isNotEmpty methods to ObjectUtils

2018-08-17 Thread Gary Gregory
If we open that Pandora's box, then I want to add: - File, empty if length is 0 - Path, empty if name length is 0 - Buffer, what? - StringBuffer - StringBuilder - java.sql.Clob - java.sql.Lob - The content of an AtomicReference - ZipFile - on and on for anything that has a "size()" or "length" or

Re: Java 11 Compatibility check: Commons-beanutils, Commons-cli, Commons-codec, Commons-collections, Commons-csv, Commons-digester, Commons-discovery, Commons-fileupload, Commons-io, Commons-lang, Com

2018-08-17 Thread Gary Gregory
On Fri, Aug 17, 2018 at 4:44 AM Stephen Colebourne wrote: > Spamming multiple open source projects with the same question is not > appropriate behaviour for a company. Open source does not have > "support". Its up to users to try the code, see if it works and report > issues. Please cease and des

[ALL] GitLab?

2018-08-17 Thread Gary Gregory
Hi All: I see https://gitlab.com/ApacheMirror I wonder if this is our official mirror on GL and whether we should mirror our Commons projects there. Gary

Re: [LANG] Adding isEmpty and isNotEmpty methods to ObjectUtils

2018-08-17 Thread Benedikt Ritter
Hello Alexander, Am Fr., 17. Aug. 2018 um 15:09 Uhr schrieb Alexander Tsvetkov < alexander.tsvetkov...@gmail.com>: > Hi Benedikt, > > Yes, ObjectUtils.isEmpty(null) would return true. You can review the pull > request (https://github.com/apache/commons-lang/pull/342) if you'd like to > see the en

Re: [VOTE] Release Apache Commons Lang 3.8 based on RC1

2018-08-17 Thread Benedikt Ritter
Hello Rob, this RC looks good to me. +1 Good job! Benedikt Am Do., 16. Aug. 2018 um 03:54 Uhr schrieb Rob Tompkins : > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Lang 3.7 was released, so I would like to release > Apache Commons Lang 3.8. > > A

Re: [LANG] Adding isEmpty and isNotEmpty methods to ObjectUtils

2018-08-17 Thread Alexander Tsvetkov
Hi Benedikt, Yes, ObjectUtils.isEmpty(null) would return true. You can review the pull request (https://github.com/apache/commons-lang/pull/342) if you'd like to see the entire implementation in its current state. Thanks and best regards, Alexander 2018-08-17 15:41 GMT+03:00 Benedikt Ritter : >

Re: [LANG] Adding isEmpty and isNotEmpty methods to ObjectUtils

2018-08-17 Thread Benedikt Ritter
Hello Alexander, welcome to the mailing list and thanks for your contribution. Am Fr., 17. Aug. 2018 um 10:43 Uhr schrieb Alexander Tsvetkov < alexander.tsvetkov...@gmail.com>: > Hi all, > > First of all, apologies if I have messed something up - this is my first > attempt at contributing to Apa

Re: Java 11 Compatibility check: Commons-beanutils, Commons-cli, Commons-codec, Commons-collections, Commons-csv, Commons-digester, Commons-discovery, Commons-fileupload, Commons-io, Commons-lang, Com

2018-08-17 Thread Stephen Colebourne
Spamming multiple open source projects with the same question is not appropriate behaviour for a company. Open source does not have "support". Its up to users to try the code, see if it works and report issues. Please cease and desist your spamming. Stephen On 17 August 2018 at 08:37, Dragan, Krz

[LANG] Adding isEmpty and isNotEmpty methods to ObjectUtils

2018-08-17 Thread Alexander Tsvetkov
Hi all, First of all, apologies if I have messed something up - this is my first attempt at contributing to Apache. With that said, I'd like to propose adding two new methods to Commons Lang's ObjectUtils class: - isEmpty() - isNotEmpty() These would check whether the object is empty (or not

Re: [imaging] IMAGING-154 remove Debug class

2018-08-17 Thread Bruno P. Kinoshita
Work on java.util.logging was done some days ago, and I've just updated it following suggestions from comments in GitHub. https://github.com/apache/commons-imaging/pull/35 Will start working on the maven plugin versions, copying things from the pom.xml of rng & lang to match commons-parent ver

[GitHub] commons-imaging issue #35: IMAGING-154 Removed Debug class

2018-08-17 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/35 Agreed on not using INFO level @sebbASF & @garydgregory . Moved what was in FINE to FINEST level. And moved what was in INFO to FINE. My plan for the web site information is to

Java 11 Compatibility check: Commons-beanutils, Commons-cli, Commons-codec, Commons-collections, Commons-csv, Commons-digester, Commons-discovery, Commons-fileupload, Commons-io, Commons-lang, Commons

2018-08-17 Thread Dragan, Krzysztof
Hi, We are reaching out to you to check Java 11 compatibility of the following libraries: Commons-beanutils, Commons-cli, Commons-codec, Commons-collections, Commons-csv, Commons-digester, Commons-discovery, Commons-fileupload, Commons-io, Commons-lang, Commons-lang3, Commons-logging, Commons-ne