Re: [release-plugin] size.zip still there

2018-07-04 Thread Gary Gregory
On Wed, Jul 4, 2018 at 8:40 AM Rob Tompkins wrote: > > > > On Jul 4, 2018, at 9:34 AM, Gary Gregory wrote: > > > > Hi Rob, > > > > I fixed a bug in git master where we did not check the result of the > > checkout svn command. Fixing that helped me straighten out Commons Pool > > 2.6.0 RC1. That

Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-04 Thread Gary Gregory
On Wed, Jul 4, 2018 at 1:51 PM Oliver Heger wrote: > Build works fine with Java 8 on Windows 10. Artifacts and site look good. > > +1 > Thank you for your review Oliver. > > One minor point I noticed is that the release notes say that "Version 2 > requires JDK level 1.6 or above", but the mini

Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-04 Thread Oliver Heger
Build works fine with Java 8 on Windows 10. Artifacts and site look good. +1 One minor point I noticed is that the release notes say that "Version 2 requires JDK level 1.6 or above", but the minimum JDK for 2.6 is 1.7. There are also a few checkstyle errors that could be fixed with not too much

Re: [release-plugin] size.zip still there

2018-07-04 Thread Rob Tompkins
> On Jul 4, 2018, at 9:34 AM, Gary Gregory wrote: > > Hi Rob, > > I fixed a bug in git master where we did not check the result of the > checkout svn command. Fixing that helped me straighten out Commons Pool > 2.6.0 RC1. That will be in the next release. > > Where are we WRT having the plug

Re: [release-plugin] size.zip still there

2018-07-04 Thread Gary Gregory
Hi Rob, I fixed a bug in git master where we did not check the result of the checkout svn command. Fixing that helped me straighten out Commons Pool 2.6.0 RC1. That will be in the next release. Where are we WRT having the plugin perform the svnmucc command? Gary On Tue, Jul 3, 2018 at 6:23 PM R